)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50b6f2e191a36a6da1e5eca67d5d2634907bf86e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"d6cd761e_04712cca","updated":"2023-03-11 02:12:45.000000000","message":"no activity for long time, and as this repo is almost inactive I will propose it to retire soon but if you would like to maintain it, ping us on #openstack-qa IRC OFTC channel","commit_id":"4d9eecf931786971b19398b5034ddcff6f16f9b0"}],"patrole_tempest_plugin/tests/api/network/test_subnets_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"282345e42e45127cfe8bd7bca4434dc993174980","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @utils.requires_ext(extension\u003d\u0027segment\u0027, service\u003d\u0027network\u0027)"},{"line_number":54,"context_line":"    @decorators.idempotent_id(\u0027c02618e7-bb20-1a3a-83c8-6eec2af08752\u0027)"},{"line_number":55,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":56,"context_line":"                                 rule\u003d\"get_subnet:segment_id\")"},{"line_number":57,"context_line":"    def test_show_subnet_with_segment_id(self):"},{"line_number":58,"context_line":"        \"\"\"Show subnet with segment_id."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_754089a3","line":56,"updated":"2018-07-13 00:11:16.000000000","message":"I\u0027m not 100%, but usually Neutron raises a 404 for failed GET authorization requests. Please see: https://docs.openstack.org/neutron/pike/contributor/internals/policy.html#request-authorization\n\nIn which case we should add the following kwarg underneath rules:\n\n    expected_error_codes\u003d[404]\n\nThere are some examples of this behavior here: http://git.openstack.org/cgit/openstack/patrole/tree/patrole_tempest_plugin/tests/api/network/test_security_groups_rbac.py#n91","commit_id":"e988416c84472bdcc64b1250dc4be3e087e6c8f3"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"cabe39766773798555cde2798f03e8add9811fc7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @utils.requires_ext(extension\u003d\u0027segment\u0027, service\u003d\u0027network\u0027)"},{"line_number":54,"context_line":"    @decorators.idempotent_id(\u0027c02618e7-bb20-1a3a-83c8-6eec2af08752\u0027)"},{"line_number":55,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":56,"context_line":"                                 rule\u003d\"get_subnet:segment_id\")"},{"line_number":57,"context_line":"    def test_show_subnet_with_segment_id(self):"},{"line_number":58,"context_line":"        \"\"\"Show subnet with segment_id."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d494ec43","line":56,"in_reply_to":"5f7c97a3_754089a3","updated":"2018-07-13 18:56:29.000000000","message":"Done","commit_id":"e988416c84472bdcc64b1250dc4be3e087e6c8f3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"282345e42e45127cfe8bd7bca4434dc993174980","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        net \u003d self.create_network()"},{"line_number":63,"context_line":"        self.addCleanup(self.networks_client.delete_network, net[\u0027id\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        seg \u003d self.segments_client.create_segment(network_id\u003dnet[\u0027id\u0027],"},{"line_number":66,"context_line":"                                                  network_type\u003d\"gre\","},{"line_number":67,"context_line":"                                                  segmentation_id\u003d1234)"},{"line_number":68,"context_line":"        self.addCleanup("},{"line_number":69,"context_line":"            self.segments_client.delete_segment, seg[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_554a2dad","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":71},"updated":"2018-07-13 00:11:16.000000000","message":"The test is failing in the logs here which means this is a Tempest/deployment failure: 404 POST https://198.72.124.132:9696/v2.0/segments 0.028s","commit_id":"e988416c84472bdcc64b1250dc4be3e087e6c8f3"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"cabe39766773798555cde2798f03e8add9811fc7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        net \u003d self.create_network()"},{"line_number":63,"context_line":"        self.addCleanup(self.networks_client.delete_network, net[\u0027id\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        seg \u003d self.segments_client.create_segment(network_id\u003dnet[\u0027id\u0027],"},{"line_number":66,"context_line":"                                                  network_type\u003d\"gre\","},{"line_number":67,"context_line":"                                                  segmentation_id\u003d1234)"},{"line_number":68,"context_line":"        self.addCleanup("},{"line_number":69,"context_line":"            self.segments_client.delete_segment, seg[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b499307b","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":71},"in_reply_to":"5f7c97a3_554a2dad","updated":"2018-07-13 18:56:29.000000000","message":"Done","commit_id":"e988416c84472bdcc64b1250dc4be3e087e6c8f3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"282345e42e45127cfe8bd7bca4434dc993174980","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.addCleanup(self.subnets_client.delete_subnet, subnet[\u0027id\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":78,"context_line":"            self.subnets_client.show_subnet(self.subnet[\u0027id\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @utils.requires_ext(extension\u003d\u0027segment\u0027, service\u003d\u0027network\u0027)"},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u0027c02618e7-bb20-1a3b-83c8-6eec2af08753\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9539a541","line":78,"range":{"start_line":78,"start_character":44,"end_line":78,"end_character":61},"updated":"2018-07-13 00:11:16.000000000","message":"I think you mean to show subnet here (the one you create on L71) since that one will contain the segment information you expect.","commit_id":"e988416c84472bdcc64b1250dc4be3e087e6c8f3"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"cabe39766773798555cde2798f03e8add9811fc7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.addCleanup(self.subnets_client.delete_subnet, subnet[\u0027id\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":78,"context_line":"            self.subnets_client.show_subnet(self.subnet[\u0027id\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @utils.requires_ext(extension\u003d\u0027segment\u0027, service\u003d\u0027network\u0027)"},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u0027c02618e7-bb20-1a3b-83c8-6eec2af08753\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d4638caa","line":78,"range":{"start_line":78,"start_character":44,"end_line":78,"end_character":61},"in_reply_to":"5f7c97a3_9539a541","updated":"2018-07-13 18:56:29.000000000","message":"Done","commit_id":"e988416c84472bdcc64b1250dc4be3e087e6c8f3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b9a383d441cc5c9a3caa18fbbbae4ca2ea0fb027","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":126,"context_line":"            self.create_subnet("},{"line_number":127,"context_line":"                self.network,"},{"line_number":128,"context_line":"                service_types\u003d[\"network:floatingip_agent_gateway\"])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u0027f36cd821-aa11-4bd0-b43d-110fc4b553eb\u0027)"},{"line_number":131,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_17a17892","line":128,"updated":"2018-07-20 04:03:29.000000000","message":"I even tried this in Neutron itself and it fails: https://review.openstack.org/#/c/584217/\n\nNot sure what gives. This is admin_only and not even the is_visible check works: even without permission it returns the service_types in the resp body.","commit_id":"a0b9fb16da22e3cc482b5d2b68e0830c5c3c1c45"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f10e0c7f5735e59bf23a52122c5ad6257056d1c9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    @decorators.idempotent_id(\u0027c02618e7-bb20-1a3a-83c8-6eec2af08752\u0027)"},{"line_number":150,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":151,"context_line":"                                 rules\u003d[\"get_subnet\","},{"line_number":152,"context_line":"                                        \"get_subnet:segment_id\"],"},{"line_number":153,"context_line":"                                 expected_error_codes\u003d[404, 404])"},{"line_number":154,"context_line":"    def test_show_subnet_with_segment_id(self):"},{"line_number":155,"context_line":"        \"\"\"Show subnet with segment_id."}],"source_content_type":"text/x-python","patch_set":25,"id":"3f79a3b5_5070f4da","line":152,"range":{"start_line":152,"start_character":40,"end_line":152,"end_character":63},"updated":"2018-08-30 20:10:48.000000000","message":"Based on neutron doc you can not specify anything but subnet_id in GET:\n\nhttps://developer.openstack.org/api-ref/network/v2/index.html#id220\n\nI can assume it\u0027s out-of-date/third-part thing and can be skipped?","commit_id":"af9f2fc35f05e516ec62f154d5f5ea8506b255e7"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f10e0c7f5735e59bf23a52122c5ad6257056d1c9","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":168,"context_line":"            self.subnets_client.show_subnet(subnet[\u0027id\u0027])"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @decorators.idempotent_id(\u0027c02618e7-bb20-1a3b-83c8-6eec2af08753\u0027)"},{"line_number":171,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":172,"context_line":"                                 rules\u003d[\"create_subnet\","},{"line_number":173,"context_line":"                                        \"create_subnet:segment_id\"])"},{"line_number":174,"context_line":"    def test_create_subnet_with_segment_id(self):"},{"line_number":175,"context_line":"        \"\"\"Create subnet with segment_id."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        RBAC test for the neutron \"get_subnet:segment_id\" policy"},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        # We can\u0027t use network from setup_resources, since all subnets of"},{"line_number":180,"context_line":"        # network should be of same kind."},{"line_number":181,"context_line":"        network \u003d self.create_network()"},{"line_number":182,"context_line":"        seg \u003d self.create_segment(network)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":185,"context_line":"            self.create_subnet("},{"line_number":186,"context_line":"                network, segment_id\u003dseg[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":187,"context_line":"                cidr\u003dnetaddr.IPNetwork(\"172.25.123.0/24\"), mask_bits\u003d24)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f79a3b5_f0a90024","line":187,"range":{"start_line":170,"start_character":0,"end_line":187,"end_character":72},"updated":"2018-08-30 20:10:48.000000000","message":"This test may be fixed in neutron-lib with:\n\nhttps://review.openstack.org/598334\n\nOriginal attempt as part of neutron seems to be not working:\n\nhttps://review.openstack.org/#/c/584601/","commit_id":"af9f2fc35f05e516ec62f154d5f5ea8506b255e7"}]}