)]}'
{"patrole_tempest_plugin/tests/api/network/test_networks_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"421ef05a374d765e83aba87243da28bac5d038d9","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if admin is not None:"},{"line_number":79,"context_line":"            kwargs[\u0027admin_state_up\u0027] \u003d admin"},{"line_number":80,"context_line":"        elif shared_network is not None:"},{"line_number":81,"context_line":"            kwargs[\u0027shared\u0027] \u003d shared_network"},{"line_number":82,"context_line":"        elif router_external is not None:"},{"line_number":83,"context_line":"            kwargs[\u0027router:external\u0027] \u003d router_external"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d89b3613","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":12},"updated":"2018-07-19 22:54:04.000000000","message":"May we change all of these to `if`? See my direct comment below on L170-171. While it\u0027s not directly related to this patchset, it expands on currently bad implementation. We should provide the ability to provide multiple inputs, not just one (which doesn\u0027t make sense).","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"98242501e7efb979638a12124790ba854aff07b2","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if admin is not None:"},{"line_number":79,"context_line":"            kwargs[\u0027admin_state_up\u0027] \u003d admin"},{"line_number":80,"context_line":"        elif shared_network is not None:"},{"line_number":81,"context_line":"            kwargs[\u0027shared\u0027] \u003d shared_network"},{"line_number":82,"context_line":"        elif router_external is not None:"},{"line_number":83,"context_line":"            kwargs[\u0027router:external\u0027] \u003d router_external"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_98061e21","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":12},"in_reply_to":"5f7c97a3_d89b3613","updated":"2018-07-19 22:56:45.000000000","message":"Yeah I was wondering about that. Will do!","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"421ef05a374d765e83aba87243da28bac5d038d9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            kwargs[\u0027router:external\u0027] \u003d router_external"},{"line_number":84,"context_line":"        elif router_private is not None:"},{"line_number":85,"context_line":"            kwargs[\u0027router:private\u0027] \u003d router_private"},{"line_number":86,"context_line":"        elif provider_network_type is not None:"},{"line_number":87,"context_line":"            kwargs[\u0027provider:network_type\u0027] \u003d provider_network_type"},{"line_number":88,"context_line":"        elif provider_physical_network is not None:"},{"line_number":89,"context_line":"            kwargs[\u0027provider:physical_network\u0027] \u003d provider_physical_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7886a2bc","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":12},"updated":"2018-07-19 22:54:04.000000000","message":"Ditto for all of these new additions.","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"421ef05a374d765e83aba87243da28bac5d038d9","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        RBAC test for the neutron create_network:provider:segmentation_id"},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":170,"context_line":"            self._create_network(provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":171,"context_line":"                                 provider_segmentation_id\u003d200)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":174,"context_line":"                                 rules\u003d[\"get_network\", \"update_network\"],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f892b2fb","line":171,"range":{"start_line":170,"start_character":0,"end_line":171,"end_character":62},"updated":"2018-07-19 22:54:04.000000000","message":"Technically what you just added to the helper above fixes this.","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"797ea0b0513ff56db60ce70c29f07f8328b56141","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        RBAC test for the neutron create_network:provider:segmentation_id"},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":170,"context_line":"            self._create_network(provider_network_type\u003d\u0027vxlan\u0027,"},{"line_number":171,"context_line":"                                 provider_segmentation_id\u003d200)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":174,"context_line":"                                 rules\u003d[\"get_network\", \"update_network\"],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_787462d0","line":171,"range":{"start_line":170,"start_character":0,"end_line":171,"end_character":62},"in_reply_to":"5f7c97a3_f892b2fb","updated":"2018-07-19 22:55:16.000000000","message":"Oh, I was looking at _update_network. Even still, I don\u0027t see why update would use if/elif logic but create just uses if logic.","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"421ef05a374d765e83aba87243da28bac5d038d9","unresolved":false,"context_lines":[{"line_number":227,"context_line":"               \"update_network:provider:network_type\"],"},{"line_number":228,"context_line":"        expected_error_codes\u003d[404, 403, 403])"},{"line_number":229,"context_line":"    @decorators.idempotent_id(\u0027d064ef96-662b-47b6-94b7-9106dcd7ba8c\u0027)"},{"line_number":230,"context_line":"    def test_update_network_provider_network_type(self):"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        \"\"\"Update Network Provider Network Type Test"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5844069f","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":49},"updated":"2018-07-19 22:54:04.000000000","message":"2018-07-19 20:41:04.064 30121 DEBUG patrole_tempest_plugin.rbac_rule_validation [-] test_update_network_provider_network_type: Expecting 403 to be raised for policy name: update_network:provider:network_type wrapper /opt/stack/patrole/patrole_tempest_plugin/rbac_rule_validation.py:178\n\n2018-07-19 20:41:05.865 30121 INFO tempest.lib.common.rest_client [req-d55c9f7f-0ef8-42c2-90b1-5bbb30579b9e ] Request (NetworksRbacTest:test_update_network_provider_network_type): 403 PUT https://198.72.124.196:9696/v2.0/networks/df8cb2d5-3c69-4c6c-aa73-9720d5e9e705 0.463s\n\nChecks out.","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"421ef05a374d765e83aba87243da28bac5d038d9","unresolved":false,"context_lines":[{"line_number":252,"context_line":"               \"update_network:provider:physical_network\"],"},{"line_number":253,"context_line":"        expected_error_codes\u003d[404, 403, 403])"},{"line_number":254,"context_line":"    @decorators.idempotent_id(\u0027e3a55660-f75c-494e-a1b1-a8b36cc789ef\u0027)"},{"line_number":255,"context_line":"    def test_update_network_provider_physical_network(self):"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        \"\"\"Update Network Provider Physical Network Test"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b8b19a93","line":255,"range":{"start_line":255,"start_character":8,"end_line":255,"end_character":53},"updated":"2018-07-19 22:54:04.000000000","message":"2018-07-19 20:41:07.230 30121 DEBUG patrole_tempest_plugin.rbac_rule_validation [-] test_update_network_provider_physical_network: Expecting 403 to be raised for policy name: update_network:provider:physical_network wrapper /opt/stack/patrole/patrole_tempest_plugin/rbac_rule_validation.py:178\n\n018-07-19 20:41:09.112 30121 INFO tempest.lib.common.rest_client [req-bc5d935a-9d8a-4b15-8803-d4b21e691753 ] Request (NetworksRbacTest:test_update_network_provider_physical_network): 403 PUT https://198.72.124.196:9696/v2.0/networks/df8cb2d5-3c69-4c6c-aa73-9720d5e9e705 0.245s\n\nChecks out.","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"421ef05a374d765e83aba87243da28bac5d038d9","unresolved":false,"context_lines":[{"line_number":277,"context_line":"               \"update_network:provider:segmentation_id\"],"},{"line_number":278,"context_line":"        expected_error_codes\u003d[404, 403, 403])"},{"line_number":279,"context_line":"    @decorators.idempotent_id(\u0027f6164228-b670-45fd-9ff9-b101930318c7\u0027)"},{"line_number":280,"context_line":"    def test_update_network_provider_segmentation_id(self):"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        \"\"\"Update Network Provider Segmentation Id Test"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_78af822a","line":280,"range":{"start_line":280,"start_character":8,"end_line":280,"end_character":52},"updated":"2018-07-19 22:54:04.000000000","message":"2018-07-19 20:41:10.618 30121 DEBUG patrole_tempest_plugin.rbac_rule_validation [-] test_update_network_provider_segmentation_id: Expecting 403 to be raised for policy name: update_network:provider:segmentation_id wrapper /opt/stack/patrole/patrole_tempest_plugin/rbac_rule_validation.py:178\n\n2018-07-19 20:41:12.471 30121 INFO tempest.lib.common.rest_client [req-9143989d-b539-4eff-9538-6e786efa9cbf ] Request (NetworksRbacTest:test_update_network_provider_segmentation_id): 403 PUT https://198.72.124.196:9696/v2.0/networks/df8cb2d5-3c69-4c6c-aa73-9720d5e9e705 0.259s\n\nChecks out.","commit_id":"2587afc38535bc11c0e6efaa08ffece16538d65f"}]}