)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"38d7390d11e3798c64081d3aafed735b40b57c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a99a70b8_5a25a5ac","updated":"2023-03-11 02:11:29.000000000","message":"no activity for long time, and as this repo is almost inactive I will propose it to retire soon but if you would like to maintain it, ping us on #openstack-qa IRC OFTC channel","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"}],"devstack/plugin.sh":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8559421d4ad9d3fc56caee979b92163794930104","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled volume_extension_volume_actions_unreserve_policy False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Policies used by Patrole testing that were newly introduced in Rocky."},{"line_number":31,"context_line":"        # TODO(felipemonteiro): Remove these once stable/pike becomes EOL."},{"line_number":32,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled create_port_fixed_ips_policy False"},{"line_number":33,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled update_port_fixed_ips_policy False"},{"line_number":34,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled create_router_external_gateway_info_policy False"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f79a3b5_da1a77ca","line":31,"range":{"start_line":31,"start_character":57,"end_line":31,"end_character":61},"updated":"2018-08-13 13:42:42.000000000","message":"queens","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0eef5bee88fbc6327d618d0d43a0d094415cce6a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled volume_extension_volume_actions_unreserve_policy False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Policies used by Patrole testing that were newly introduced in Rocky."},{"line_number":31,"context_line":"        # TODO(felipemonteiro): Remove these once stable/pike becomes EOL."},{"line_number":32,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled create_port_fixed_ips_policy False"},{"line_number":33,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled update_port_fixed_ips_policy False"},{"line_number":34,"context_line":"        iniset $TEMPEST_CONFIG policy-feature-enabled create_router_external_gateway_info_policy False"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f79a3b5_ce0cf9a6","line":31,"range":{"start_line":31,"start_character":57,"end_line":31,"end_character":61},"in_reply_to":"3f79a3b5_da1a77ca","updated":"2018-08-13 16:06:10.000000000","message":"ah, pike is good here as it is for pike branch.","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"}],"patrole_tempest_plugin/config.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e9aeb15ddfef9767b15ac0afd4fb586342878180","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                help\u003d\"\"\"Is the Neutron policy"},{"line_number":137,"context_line":"\"update_port:fixed_ips:ip_address\" available in the cloud? This policy was"},{"line_number":138,"context_line":"changed in a backwards-incompatible way.\"\"\"),"},{"line_number":139,"context_line":"    # TODO(felipemonteiro): The 2 feature flags below should be removed after"},{"line_number":140,"context_line":"    # Queens is EOL."},{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027create_port_fixed_ips\u0027,"},{"line_number":142,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2d31a658","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":33},"updated":"2018-07-21 21:34:14.000000000","message":"4","commit_id":"18b31425658db6cde1cc625ab06c42b1f7b52cfd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0eef5bee88fbc6327d618d0d43a0d094415cce6a","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # TODO(felipemonteiro): The 4 feature flags below should be removed after"},{"line_number":141,"context_line":"    # Queens is EOL."},{"line_number":142,"context_line":"    cfg.BoolOpt(\u0027create_port_fixed_ips_policy\u0027,"},{"line_number":143,"context_line":"                default\u003dTrue,"},{"line_number":144,"context_line":"                help\u003d\"\"\"Is the Neutron policy \"create_port:fixed_ips\" available"},{"line_number":145,"context_line":"in the cloud? This policy was introduced in Rocky.\"\"\"),"},{"line_number":146,"context_line":"    cfg.BoolOpt(\u0027update_port_fixed_ips_policy\u0027,"},{"line_number":147,"context_line":"                default\u003dTrue,"},{"line_number":148,"context_line":"                help\u003d\"\"\"Is the Neutron policy \"update_port:fixed_ips\" available"},{"line_number":149,"context_line":"in the cloud? This policy was introduced in Rocky.\"\"\"),"},{"line_number":150,"context_line":"    cfg.BoolOpt(\u0027create_router_external_gateway_info_policy\u0027,"},{"line_number":151,"context_line":"                default\u003dTrue,"},{"line_number":152,"context_line":"                help\u003d\"\"\"Is the Neutron policy"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_4e8789b6","line":149,"range":{"start_line":142,"start_character":0,"end_line":149,"end_character":55},"updated":"2018-08-13 16:06:10.000000000","message":"let\u0027s make it as single flag something like - port_fixed_ips_policy as both are added together. \n\neach policy does not need to be separate feature flag till they were being introduced in separate cycle. \nbut how about adding a single flag per cycle, something like added_neutron_policy_rocky and we skip tests testing each new rocky policy based on this flag and flag will be removed once rocky is EOl. it should work right?. \n\nif so it will make life easy and will avoid lot of config options.","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a3be27b65cc3fbc9d141aaecdc0e83b49fb4d951","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # TODO(felipemonteiro): The 4 feature flags below should be removed after"},{"line_number":141,"context_line":"    # Queens is EOL."},{"line_number":142,"context_line":"    cfg.BoolOpt(\u0027create_port_fixed_ips_policy\u0027,"},{"line_number":143,"context_line":"                default\u003dTrue,"},{"line_number":144,"context_line":"                help\u003d\"\"\"Is the Neutron policy \"create_port:fixed_ips\" available"},{"line_number":145,"context_line":"in the cloud? This policy was introduced in Rocky.\"\"\"),"},{"line_number":146,"context_line":"    cfg.BoolOpt(\u0027update_port_fixed_ips_policy\u0027,"},{"line_number":147,"context_line":"                default\u003dTrue,"},{"line_number":148,"context_line":"                help\u003d\"\"\"Is the Neutron policy \"update_port:fixed_ips\" available"},{"line_number":149,"context_line":"in the cloud? This policy was introduced in Rocky.\"\"\"),"},{"line_number":150,"context_line":"    cfg.BoolOpt(\u0027create_router_external_gateway_info_policy\u0027,"},{"line_number":151,"context_line":"                default\u003dTrue,"},{"line_number":152,"context_line":"                help\u003d\"\"\"Is the Neutron policy"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_ae32dd0e","line":149,"range":{"start_line":142,"start_character":0,"end_line":149,"end_character":55},"in_reply_to":"3f79a3b5_4e8789b6","updated":"2018-08-13 16:09:52.000000000","message":"and why single flag per cycle can work here is, added/removed policies will not be dynamically configured feature so that user can enable them separately.","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8559421d4ad9d3fc56caee979b92163794930104","unresolved":false,"context_lines":[{"line_number":158,"context_line":"\"create_router:external_gateway_info:network_id\" available in the cloud? This"},{"line_number":159,"context_line":"policy was introduced in Rocky.\"\"\"),"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    # TODO(felipemonteiro): The 4 feature flags below should be removed after"},{"line_number":162,"context_line":"    # Pike is EOL."},{"line_number":163,"context_line":"    cfg.BoolOpt(\u0027limits_extension_used_limits_policy\u0027,"},{"line_number":164,"context_line":"                default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d\"\"\"Is the Cinder policy"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5a6bc71c","line":162,"range":{"start_line":161,"start_character":0,"end_line":162,"end_character":18},"updated":"2018-08-13 13:42:42.000000000","message":"let\u0027s keep them in their original position and new one in last so that it will be easy to remove them once corresponding stable branch is EOL.","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"}],"patrole_tempest_plugin/tests/api/network/test_ports_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e9aeb15ddfef9767b15ac0afd4fb586342878180","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            rules\u003d[\"get_port\","},{"line_number":326,"context_line":"                   \"update_port\","},{"line_number":327,"context_line":"                   \"update_port:fixed_ips:ip_address\"],"},{"line_number":328,"context_line":"            expected_error_codes\u003d[404, 403, 403, 403])"},{"line_number":329,"context_line":"    @decorators.idempotent_id(\u0027c091c825-532b-4c6f-a14f-affd3259c1c3\u0027)"},{"line_number":330,"context_line":"    def test_update_port_fixed_ips_ip_address(self):"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ed364e4f","line":328,"range":{"start_line":328,"start_character":49,"end_line":328,"end_character":52},"updated":"2018-07-21 21:34:14.000000000","message":"Remove","commit_id":"18b31425658db6cde1cc625ab06c42b1f7b52cfd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0eef5bee88fbc6327d618d0d43a0d094415cce6a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        service\u003d\"neutron\","},{"line_number":126,"context_line":"        rules\u003d[\"create_port\","},{"line_number":127,"context_line":"               \"create_port:fixed_ips\","},{"line_number":128,"context_line":"               \"create_port:fixed_ips:ip_address\"],"},{"line_number":129,"context_line":"        expected_error_codes\u003d[403, 403, 403])"},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00272551e10d-006a-413c-925a-8c6f834c09ac\u0027)"},{"line_number":131,"context_line":"    def test_create_port_fixed_ips_ip_address(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_4eca294e","line":128,"range":{"start_line":128,"start_character":15,"end_line":128,"end_character":50},"updated":"2018-08-13 16:06:10.000000000","message":"i did not find this rule building in neutron[1]. amotoki mentioned it can be bug ? but anyways that is out of scope of this patch. \n\n[1] https://github.com/openstack/neutron-lib/blob/8cbab5756c7b6adffc54af39ead3b6c89bbcd3ea/neutron_lib/api/definitions/port.py#L66","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8559421d4ad9d3fc56caee979b92163794930104","unresolved":false,"context_lines":[{"line_number":128,"context_line":"               \"create_port:fixed_ips:ip_address\"],"},{"line_number":129,"context_line":"        expected_error_codes\u003d[403, 403, 403])"},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00272551e10d-006a-413c-925a-8c6f834c09ac\u0027)"},{"line_number":131,"context_line":"    def test_create_port_fixed_ips_ip_address(self):"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        ip_list \u003d self._get_unused_ip_address()"},{"line_number":134,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: ip_list[0]},"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3a784bc2","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":52},"updated":"2018-08-13 13:42:42.000000000","message":"When new policy added in neutron in below patch, this test was not failing ? or that patch just added new policy in policy.json only and it was already enforced on neutron side already ?\n\nI am getting more info from neutron team about how policy are enforced in neutron as it is too magic done in neutron_lib/api/definitions for API mapping and all. But it will be good if you can point me to some code pointer about neutron policy enforcement. \n\n- https://review.openstack.org/#/c/577471/5","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f825f821e26366a3794af7d9623a5b13f9b89ce6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"               \"create_port:fixed_ips:ip_address\"],"},{"line_number":129,"context_line":"        expected_error_codes\u003d[403, 403, 403])"},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00272551e10d-006a-413c-925a-8c6f834c09ac\u0027)"},{"line_number":131,"context_line":"    def test_create_port_fixed_ips_ip_address(self):"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        ip_list \u003d self._get_unused_ip_address()"},{"line_number":134,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: ip_list[0]},"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_ac95fb88","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":52},"in_reply_to":"3f79a3b5_2e7fad15","updated":"2018-08-14 04:28:59.000000000","message":"Neutron policy documentation is here: https://docs.openstack.org/neutron/latest/contributor/internals/policy.html\n\nBut yes, it is very complicated.","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0eef5bee88fbc6327d618d0d43a0d094415cce6a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"               \"create_port:fixed_ips:ip_address\"],"},{"line_number":129,"context_line":"        expected_error_codes\u003d[403, 403, 403])"},{"line_number":130,"context_line":"    @decorators.idempotent_id(\u00272551e10d-006a-413c-925a-8c6f834c09ac\u0027)"},{"line_number":131,"context_line":"    def test_create_port_fixed_ips_ip_address(self):"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        ip_list \u003d self._get_unused_ip_address()"},{"line_number":134,"context_line":"        fixed_ips \u003d [{\u0027ip_address\u0027: ip_list[0]},"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_2e7fad15","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":52},"in_reply_to":"3f79a3b5_3a784bc2","updated":"2018-08-13 16:06:10.000000000","message":"i understand the neutron policy check now. There are multiple ways policy are being enforced.\n1. with direct policy name enforcement like [1]\n2. with \u003coperation\u003e_\u003cresource\u003e [2]\n3. appending attribute in \u003coperation\u003e_\u003cresource\u003e rule [3]\n4. appending sub_attribute in rule prepared in 3rd step [4]\n\nAnd condition to build rules like that is all from api/definitions/ info. example- [5]\n\n[1] https://github.com/openstack/neutron/blob/1dda2bca862b1268c0f5ae39b7508f1b1cab6f15/neutron/extensions/dhcpagentscheduler.py#L36-L38\n\n[2] https://github.com/openstack/neutron/blob/1dda2bca862b1268c0f5ae39b7508f1b1cab6f15/neutron/policy.py#L164\n\n[3] https://github.com/openstack/neutron/blob/1dda2bca862b1268c0f5ae39b7508f1b1cab6f15/neutron/policy.py#L177\n\n[4] https://github.com/openstack/neutron/blob/1dda2bca862b1268c0f5ae39b7508f1b1cab6f15/neutron/policy.py#L134\n\n[5] https://github.com/openstack/neutron-lib/blob/8cbab5756c7b6adffc54af39ead3b6c89bbcd3ea/neutron_lib/api/definitions/port.py#L62","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"}],"releasenotes/notes/new-policy-feature-flags-for-network-tests-b0f6aca0773fd32e.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8559421d4ad9d3fc56caee979b92163794930104","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * create_router_external_gateway_info_policy"},{"line_number":11,"context_line":"    * create_router_external_gateway_info_network_id_policy"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    These Neutron policies are not \"new\" per se, but were only recently"},{"line_number":14,"context_line":"    included in Neutron\u0027s policy file, so now they can be tested by"},{"line_number":15,"context_line":"    Patrole."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_3a0feb37","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":47},"updated":"2018-08-13 13:42:42.000000000","message":"?","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f825f821e26366a3794af7d9623a5b13f9b89ce6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * create_router_external_gateway_info_policy"},{"line_number":11,"context_line":"    * create_router_external_gateway_info_network_id_policy"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    These Neutron policies are not \"new\" per se, but were only recently"},{"line_number":14,"context_line":"    included in Neutron\u0027s policy file, so now they can be tested by"},{"line_number":15,"context_line":"    Patrole."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_acdadb74","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":47},"in_reply_to":"3f79a3b5_3a0feb37","updated":"2018-08-14 04:28:59.000000000","message":"https://dictionary.cambridge.org/us/dictionary/english/per-se\n\nIt just means that they aren\u0027t really new. I can rephrase it to make it clearer.","commit_id":"ce93c52e4ebcd5558a556e850f13dfcf4e910763"}]}
