)]}'
{"patrole_tempest_plugin/tests/api/network/test_rbac_policies_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"33d70562ea61ecc4c857a4ff8e95a88c84c7c9fc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.addCleanup("},{"line_number":63,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":64,"context_line":"            self.ntp_client.delete_rbac_policy, policy[\"rbac_policy\"][\"id\"])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027f5d836d8-3b64-412d-a283-ee29761017f3\u0027)"},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"update_rbac_policy\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e1679beb","line":65,"updated":"2018-07-29 21:37:58.000000000","message":"I think it would be useful to have another test for checking restrict wildcard for target_tenant, i.e. test_create_rbac_policy_restrict_wildcard: https://github.com/openstack/neutron/blob/d00a1558a5a51ad8d189ad3d72aabae6447a88b5/etc/policy.json#L212\n\nThe expectation is that target_tenant\u003d\"*\" should fail for member but pass for admin.","commit_id":"9622fb2f6afbe539430bb38a35fa8e6a01ad29ad"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"59849cb27aa08c19955d4ac2c83c120d5b9d8291","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.addCleanup("},{"line_number":63,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":64,"context_line":"            self.ntp_client.delete_rbac_policy, policy[\"rbac_policy\"][\"id\"])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027f5d836d8-3b64-412d-a283-ee29761017f3\u0027)"},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"update_rbac_policy\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9db2b904","line":65,"in_reply_to":"5f7c97a3_e1679beb","updated":"2018-07-30 18:00:28.000000000","message":"It acts exactly as you described, but validation acted like it shouldn\u0027t:\n\nDetails: Role member was not allowed to perform the following actions: [\u0027restrict_wildcard\u0027, \u0027update_rbac_policy:target_tenant\u0027]. Expected allowed actions: [\u0027restrict_wildcard\u0027, \u0027update_rbac_policy:target_tenant\u0027]. Expected disallowed actions: []. Exception was: Forbidden\n\nWill dig into it, but probably its some known issue.","commit_id":"9622fb2f6afbe539430bb38a35fa8e6a01ad29ad"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"33d70562ea61ecc4c857a4ff8e95a88c84c7c9fc","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027f5d836d8-3b64-412d-a283-ee29761017f3\u0027)"},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"update_rbac_policy\","},{"line_number":69,"context_line":"                                        \"update_rbac_policy:target_tenant\"])"},{"line_number":70,"context_line":"    def test_update_rbac_policy(self):"},{"line_number":71,"context_line":"        \"\"\"Update RBAC policy."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c1629fd9","line":68,"updated":"2018-07-29 21:37:58.000000000","message":"Are you sure this doesn\u0027t also enforce get_rbac_policy first?","commit_id":"9622fb2f6afbe539430bb38a35fa8e6a01ad29ad"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"33d70562ea61ecc4c857a4ff8e95a88c84c7c9fc","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":78,"context_line":"            self.ntp_client.update_rbac_policy("},{"line_number":79,"context_line":"                policy_id, target_tenant\u003dself.tenant_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u00279308ab18-426c-41b7-bce5-11081f7dd259\u0027)"},{"line_number":82,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":83,"context_line":"                                 rules\u003d[\"get_rbac_policy\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a16523e4","line":80,"updated":"2018-07-29 21:37:58.000000000","message":"Ditto for update: https://github.com/openstack/neutron/blob/d00a1558a5a51ad8d189ad3d72aabae6447a88b5/etc/policy.json#L217","commit_id":"9622fb2f6afbe539430bb38a35fa8e6a01ad29ad"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"33d70562ea61ecc4c857a4ff8e95a88c84c7c9fc","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @decorators.idempotent_id(\u002754aa9bce-efea-47fb-b0e4-12012f82f285\u0027)"},{"line_number":95,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":96,"context_line":"                                 rules\u003d[\"delete_rbac_policy\"])"},{"line_number":97,"context_line":"    def test_delete_rbac_policy(self):"},{"line_number":98,"context_line":"        \"\"\"Delete RBAC policy."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_615b8b22","line":96,"updated":"2018-07-29 21:37:58.000000000","message":"Are you sure this doesn\u0027t also enforce get_rbac_policy first?","commit_id":"9622fb2f6afbe539430bb38a35fa8e6a01ad29ad"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"981625d6f2eb525f6d598b9b782091043e24410d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u00277528637f-7f1b-406c-bd80-0f820a56af08\u0027)"},{"line_number":82,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":83,"context_line":"                                 rules\u003d[\"update_rbac_policy:target_tenant\"])"},{"line_number":84,"context_line":"    def test_restrict_wildcard_rbac_policy(self):"},{"line_number":85,"context_line":"        \"\"\"Restrict wildcard in update RBAC policy."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_2c7251e5","line":83,"updated":"2018-07-30 22:33:05.000000000","message":"I forgot that there is a complication with validating this Patrole-side; a better interface needs to be made for validating policies like this. For now we can drop the test. Disregard previous comments about restrict_wildcard.","commit_id":"9d1d50564936475987cdf155602e1d8378e59382"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8ebaa1f194bc1d6852e2c49b5a01b7aab8ec45ab","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u00277528637f-7f1b-406c-bd80-0f820a56af08\u0027)"},{"line_number":82,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":83,"context_line":"                                 rules\u003d[\"update_rbac_policy:target_tenant\"])"},{"line_number":84,"context_line":"    def test_restrict_wildcard_rbac_policy(self):"},{"line_number":85,"context_line":"        \"\"\"Restrict wildcard in update RBAC policy."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a0864fb6","line":83,"in_reply_to":"5f7c97a3_2c7251e5","updated":"2018-07-31 17:26:21.000000000","message":"For full context, even the above comment is incorrect. The issue is that Neutron registers some additional oslo.policy checks within its policy.py file. These checks are only registered through importation of that file, which is not possible from within Patrole I believe. So there\u0027s no way for us to derive the expected result unless such checks are moved to neutron.lib. But this is a very low priority concern, though is something I need to point out somewhere in documentation.","commit_id":"9d1d50564936475987cdf155602e1d8378e59382"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d487a2ecc84b25cbcb80a86139e5e566ad1ba360","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @decorators.idempotent_id(\u002754aa9bce-efea-47fb-b0e4-12012f82f285\u0027)"},{"line_number":95,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":96,"context_line":"                                 rules\u003d[\"delete_rbac_policy\"])"},{"line_number":97,"context_line":"    def test_delete_rbac_policy(self):"},{"line_number":98,"context_line":"        \"\"\"Delete RBAC policy."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        RBAC test for the neutron \"delete_rbac_policy\" policy"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_4d595d58","line":97,"updated":"2018-08-07 01:35:33.000000000","message":"We should be able to update the rules now with 404, 403 and \"get_rbac_policy\"/\"delete_rbac_policy\"","commit_id":"1fe02ad5f45ac65b3307b5d5edefa12ea64ebda2"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"195a24a5caf300c8a26e6e8b8e8d3db859a5ecf6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @decorators.idempotent_id(\u002754aa9bce-efea-47fb-b0e4-12012f82f285\u0027)"},{"line_number":95,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":96,"context_line":"                                 rules\u003d[\"delete_rbac_policy\"])"},{"line_number":97,"context_line":"    def test_delete_rbac_policy(self):"},{"line_number":98,"context_line":"        \"\"\"Delete RBAC policy."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        RBAC test for the neutron \"delete_rbac_policy\" policy"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_0a1336b7","line":97,"in_reply_to":"3f79a3b5_4d595d58","updated":"2018-08-07 18:55:29.000000000","message":"Done","commit_id":"1fe02ad5f45ac65b3307b5d5edefa12ea64ebda2"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f67d3f27d1d0bc4518f249dd2eb54f64a848b72c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                        \"create_rbac_policy:target_tenant\"])"},{"line_number":48,"context_line":"    def test_create_rbac_policy(self):"},{"line_number":49,"context_line":"        \"\"\"Create RBAC policy."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        RBAC test for the neutron \"create_rbac_policy\" policy"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_1c3584f7","line":50,"updated":"2018-08-09 20:37:30.000000000","message":"I think we should add a note here saying that we can\u0027t validate \"create_rbac_policy:target_tenant\" for all cases since if \"restrict_wildcard\" rule is modified then Patrole won\u0027t be able to determine the correct result since that requires relying on Neutron\u0027s custom FieldCheck oslo.policy rule.","commit_id":"7f1e16a434daa68ef723259cd0145a9d9a2c4884"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"bb2451304410b6437e3f08cd165d36c7c830f775","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                        \"create_rbac_policy:target_tenant\"])"},{"line_number":48,"context_line":"    def test_create_rbac_policy(self):"},{"line_number":49,"context_line":"        \"\"\"Create RBAC policy."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        RBAC test for the neutron \"create_rbac_policy\" policy"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_12ed6b24","line":50,"in_reply_to":"3f79a3b5_1c3584f7","updated":"2018-08-09 21:23:57.000000000","message":"Done","commit_id":"7f1e16a434daa68ef723259cd0145a9d9a2c4884"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f67d3f27d1d0bc4518f249dd2eb54f64a848b72c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                 expected_error_codes\u003d[404, 403])"},{"line_number":71,"context_line":"    def test_update_rbac_policy(self):"},{"line_number":72,"context_line":"        \"\"\"Update RBAC policy."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        RBAC test for the neutron \"update_rbac_policy\" policy"},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        policy_id \u003d self.create_rbac_policy(self.tenant_id, self.network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_dc3e2cd9","line":73,"updated":"2018-08-09 20:37:30.000000000","message":"I think we should add a note here saying that we can\u0027t validate \"update_rbac_policy:target_tenant\" for all cases since if \"restrict_wildcard\" rule is modified then Patrole won\u0027t be able to determine the correct result since that requires relying on Neutron\u0027s custom FieldCheck oslo.policy rule.","commit_id":"7f1e16a434daa68ef723259cd0145a9d9a2c4884"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"bb2451304410b6437e3f08cd165d36c7c830f775","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                 expected_error_codes\u003d[404, 403])"},{"line_number":71,"context_line":"    def test_update_rbac_policy(self):"},{"line_number":72,"context_line":"        \"\"\"Update RBAC policy."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        RBAC test for the neutron \"update_rbac_policy\" policy"},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        policy_id \u003d self.create_rbac_policy(self.tenant_id, self.network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_f2e9cf19","line":73,"in_reply_to":"3f79a3b5_dc3e2cd9","updated":"2018-08-09 21:23:57.000000000","message":"Done","commit_id":"7f1e16a434daa68ef723259cd0145a9d9a2c4884"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"b0d3438cb7f74844fe41b692e09ea803d3c27bfb","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00279308ab18-426c-41b7-bce5-11081f7dd259\u0027)"},{"line_number":93,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":94,"context_line":"                                 rules\u003d[\"get_rbac_policy\"])"},{"line_number":95,"context_line":"    def test_show_rbac_policy(self):"},{"line_number":96,"context_line":"        \"\"\"Show RBAC policy."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_9d4ad2a9","line":94,"range":{"start_line":94,"start_character":33,"end_line":94,"end_character":59},"updated":"2018-08-10 20:38:22.000000000","message":"should the expected error code be 404?\n\nI see in \u0027test_delete_rbac_policy\u0027 that the expected error code for \u0027get_rbac_policy\u0027 is 404.","commit_id":"c7c190fd8aa1b56e72a4c53c91fa7bc1cccf4682"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"ab1092914402685e07f09ff058a47f741dca0c95","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00279308ab18-426c-41b7-bce5-11081f7dd259\u0027)"},{"line_number":93,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":94,"context_line":"                                 rules\u003d[\"get_rbac_policy\"])"},{"line_number":95,"context_line":"    def test_show_rbac_policy(self):"},{"line_number":96,"context_line":"        \"\"\"Show RBAC policy."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_935e4110","line":94,"range":{"start_line":94,"start_character":33,"end_line":94,"end_character":59},"in_reply_to":"3f79a3b5_9d4ad2a9","updated":"2018-08-10 21:56:10.000000000","message":"Done","commit_id":"c7c190fd8aa1b56e72a4c53c91fa7bc1cccf4682"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7d5c8150a0bc784d0f77094d00162b9778d1a1f8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @decorators.idempotent_id(\u0027f5d836d8-3b64-412d-a283-ee29761017f3\u0027)"},{"line_number":72,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":73,"context_line":"                                 rules\u003d[\"update_rbac_policy\","},{"line_number":74,"context_line":"                                        \"update_rbac_policy:target_tenant\"],"},{"line_number":75,"context_line":"                                 expected_error_codes\u003d[404, 403])"},{"line_number":76,"context_line":"    def test_update_rbac_policy(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_f1e76dab","line":73,"updated":"2018-08-11 06:00:42.000000000","message":"This one is missing: \"get_rbac_policy\" as the first rule","commit_id":"c7bbd4622a23d9f31df67e9d5f112aa18d1af78e"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"e3cb8a1ad1c77db48f8c79580c3da438ef7c610b","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @decorators.idempotent_id(\u0027f5d836d8-3b64-412d-a283-ee29761017f3\u0027)"},{"line_number":72,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":73,"context_line":"                                 rules\u003d[\"update_rbac_policy\","},{"line_number":74,"context_line":"                                        \"update_rbac_policy:target_tenant\"],"},{"line_number":75,"context_line":"                                 expected_error_codes\u003d[404, 403])"},{"line_number":76,"context_line":"    def test_update_rbac_policy(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_0b68b5b6","line":73,"in_reply_to":"3f79a3b5_f1e76dab","updated":"2018-08-12 05:14:55.000000000","message":"Done","commit_id":"c7bbd4622a23d9f31df67e9d5f112aa18d1af78e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7d5c8150a0bc784d0f77094d00162b9778d1a1f8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":73,"context_line":"                                 rules\u003d[\"update_rbac_policy\","},{"line_number":74,"context_line":"                                        \"update_rbac_policy:target_tenant\"],"},{"line_number":75,"context_line":"                                 expected_error_codes\u003d[404, 403])"},{"line_number":76,"context_line":"    def test_update_rbac_policy(self):"},{"line_number":77,"context_line":"        \"\"\"Update RBAC policy."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_11ed498a","line":75,"updated":"2018-08-11 06:00:42.000000000","message":"This will become 404, 403, 403 after you make the above change.","commit_id":"c7bbd4622a23d9f31df67e9d5f112aa18d1af78e"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"e3cb8a1ad1c77db48f8c79580c3da438ef7c610b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":73,"context_line":"                                 rules\u003d[\"update_rbac_policy\","},{"line_number":74,"context_line":"                                        \"update_rbac_policy:target_tenant\"],"},{"line_number":75,"context_line":"                                 expected_error_codes\u003d[404, 403])"},{"line_number":76,"context_line":"    def test_update_rbac_policy(self):"},{"line_number":77,"context_line":"        \"\"\"Update RBAC policy."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_ab60a1d0","line":75,"in_reply_to":"3f79a3b5_11ed498a","updated":"2018-08-12 05:14:55.000000000","message":"Done","commit_id":"c7bbd4622a23d9f31df67e9d5f112aa18d1af78e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"584a21e1c41d8ccc6787a52547d83dfe095b3414","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":60,"context_line":"            policy \u003d self.ntp_client.create_rbac_policy("},{"line_number":61,"context_line":"                target_tenant\u003dself.tenant_id,"},{"line_number":62,"context_line":"                object_type\u003d\"network\","},{"line_number":63,"context_line":"                object_id\u003dself.network_id,"},{"line_number":64,"context_line":"                action\u003d\"access_as_shared\""},{"line_number":65,"context_line":"            )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.addCleanup("},{"line_number":68,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":69,"context_line":"            self.ntp_client.delete_rbac_policy, policy[\"rbac_policy\"][\"id\"])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @decorators.idempotent_id(\u0027f5d836d8-3b64-412d-a283-ee29761017f3\u0027)"},{"line_number":72,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_176bf21d","line":69,"range":{"start_line":60,"start_character":0,"end_line":69,"end_character":76},"updated":"2018-08-13 01:53:11.000000000","message":"nit: We can call `self.create_rbac_policy(self.tenant_id, self.network_id)` directly here","commit_id":"165db4a610b56e4245473b4a051dbb362ad774a8"}]}
