)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5355b618043de079620f2b946e25cd1a60b5a447","unresolved":false,"context_lines":[{"line_number":14,"context_line":"[1] https://storyboard.openstack.org/#!/story/2002641"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22b0467f698d548abb85f45c993bbe0165eb21b1"},{"line_number":17,"context_line":"Story: 2002641"},{"line_number":18,"context_line":"Task: 22324"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d059128e","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":11},"updated":"2018-08-10 19:07:21.000000000","message":"This task asks us to test:\n\nAdd tests for the following actions:\n\u0027create_flavor_service_profile\u0027\n\u0027delete_flavor_service_profile\u0027\n\u0027get_flavor_service_profile\u0027\n\nBut in API ref [0] I see only Associate/Disassociate (aka create/delete), but not \"get\".\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#associate-flavor-with-a-service-profile","commit_id":"e332ba1b13d3a0a0789cd402d7cbc1c75dd65b37"}],"patrole_tempest_plugin/tests/api/network/test_flavors_rbac.py":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5355b618043de079620f2b946e25cd1a60b5a447","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":141,"context_line":"            cls.ntp_client.delete_service_profile, cls.service_profile_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def create_flavor_service_profile(self, flavor_id, service_profile_id):"},{"line_number":144,"context_line":"        self.ntp_client.create_flavor_service_profile("},{"line_number":145,"context_line":"            flavor_id, service_profile_id)"},{"line_number":146,"context_line":"        self.addCleanup("},{"line_number":147,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":148,"context_line":"            self.ntp_client.delete_flavor_service_profile,"},{"line_number":149,"context_line":"            flavor_id, service_profile_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @decorators.idempotent_id(\u0027aa84b4c5-0dd6-4c34-aa81-3a76507f9b81\u0027)"},{"line_number":152,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_90295ae7","line":149,"range":{"start_line":143,"start_character":0,"end_line":149,"end_character":42},"updated":"2018-08-10 19:07:21.000000000","message":"It\u0027s not a @classmethod because for each individual test there should be no connection between flavor and service_profile, so it may create it.","commit_id":"e332ba1b13d3a0a0789cd402d7cbc1c75dd65b37"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6335a87a1c168280e49890b636531db76f39e868","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def create_service_profile(cls):"},{"line_number":141,"context_line":"        service_profile \u003d cls.ntp_client.create_service_profile("},{"line_number":142,"context_line":"            metainfo\u003d\"{\u0027foo\u0027: \u0027bar23\u0027}\")"},{"line_number":143,"context_line":"        service_profile_id \u003d service_profile[\"service_profile\"][\"id\"]"},{"line_number":144,"context_line":"        cls.addClassResourceCleanup("},{"line_number":145,"context_line":"            test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_519c210e","line":142,"range":{"start_line":142,"start_character":21,"end_line":142,"end_character":39},"updated":"2018-08-11 06:04:44.000000000","message":"nit: Would be a bit cleaner to use json.dumps({\u0027foo\u0027: \u0027bar23\u0027})\n\nAnd can import json via:\n\n    from oslo_serialization import jsonutils as json","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f1f3d514183b9a0ce7f796f1b8737dd377b30071","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def create_service_profile(cls):"},{"line_number":141,"context_line":"        service_profile \u003d cls.ntp_client.create_service_profile("},{"line_number":142,"context_line":"            metainfo\u003d\"{\u0027foo\u0027: \u0027bar23\u0027}\")"},{"line_number":143,"context_line":"        service_profile_id \u003d service_profile[\"service_profile\"][\"id\"]"},{"line_number":144,"context_line":"        cls.addClassResourceCleanup("},{"line_number":145,"context_line":"            test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e7e48fe2","line":142,"range":{"start_line":142,"start_character":21,"end_line":142,"end_character":39},"in_reply_to":"3f79a3b5_519c210e","updated":"2018-08-11 14:13:07.000000000","message":"Done","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6335a87a1c168280e49890b636531db76f39e868","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        RBAC test for the neutron \"create_flavor_service_profile\" policy"},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        flavor_id \u003d self.create_flavor()"},{"line_number":167,"context_line":"        service_profile_id \u003d self.create_service_profile()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":170,"context_line":"            self.create_flavor_service_profile(flavor_id, service_profile_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_71fb5d46","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":58},"updated":"2018-08-11 06:04:44.000000000","message":"Why not create these once in resource_setup? I\u0027m assuming that delete_flavor_service_profile on L186 doesn\u0027t do a cascade delete so it should be safe to create these resources once only?","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f1f3d514183b9a0ce7f796f1b8737dd377b30071","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        RBAC test for the neutron \"create_flavor_service_profile\" policy"},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        flavor_id \u003d self.create_flavor()"},{"line_number":167,"context_line":"        service_profile_id \u003d self.create_service_profile()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":170,"context_line":"            self.create_flavor_service_profile(flavor_id, service_profile_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_07eaebaa","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":58},"in_reply_to":"3f79a3b5_71fb5d46","updated":"2018-08-11 14:13:07.000000000","message":"Done. Tho we need to disconnect those objects after each step. So if we create them on class level, we need to disconnect them after each test. create_flavor_service_profile moved from class method to instance.","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6335a87a1c168280e49890b636531db76f39e868","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        service_profile_id \u003d self.create_service_profile()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":170,"context_line":"            self.create_flavor_service_profile(flavor_id, service_profile_id)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.idempotent_id(\u00273b680d9e-946a-4670-ab7f-0e4576675833\u0027)"},{"line_number":173,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_319725ef","line":170,"range":{"start_line":170,"start_character":12,"end_line":170,"end_character":77},"updated":"2018-08-11 06:04:44.000000000","message":"Does this require an addCleanup to delete this or is this automatically cleaned up via a cascade when the parent resources get deleted?","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f1f3d514183b9a0ce7f796f1b8737dd377b30071","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        service_profile_id \u003d self.create_service_profile()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":170,"context_line":"            self.create_flavor_service_profile(flavor_id, service_profile_id)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @decorators.idempotent_id(\u00273b680d9e-946a-4670-ab7f-0e4576675833\u0027)"},{"line_number":173,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_67aabf71","line":170,"range":{"start_line":170,"start_character":12,"end_line":170,"end_character":77},"in_reply_to":"3f79a3b5_319725ef","updated":"2018-08-11 14:13:07.000000000","message":"It\u0027s not a client, but just method from L150.","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6335a87a1c168280e49890b636531db76f39e868","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        RBAC test for the neutron \"delete_flavor_service_profile\" policy"},{"line_number":179,"context_line":"        \"\"\""},{"line_number":180,"context_line":"        flavor_id \u003d self.create_flavor()"},{"line_number":181,"context_line":"        service_profile_id \u003d self.create_service_profile()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        self.create_flavor_service_profile(flavor_id, service_profile_id)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_91f87949","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":58},"updated":"2018-08-11 06:04:44.000000000","message":"Ditto.","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f1f3d514183b9a0ce7f796f1b8737dd377b30071","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        RBAC test for the neutron \"delete_flavor_service_profile\" policy"},{"line_number":179,"context_line":"        \"\"\""},{"line_number":180,"context_line":"        flavor_id \u003d self.create_flavor()"},{"line_number":181,"context_line":"        service_profile_id \u003d self.create_service_profile()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        self.create_flavor_service_profile(flavor_id, service_profile_id)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_c7cf1354","line":181,"range":{"start_line":180,"start_character":0,"end_line":181,"end_character":58},"in_reply_to":"3f79a3b5_91f87949","updated":"2018-08-11 14:13:07.000000000","message":"Done","commit_id":"bdb8c28e72d87879376159debc9fc65e49c1a948"}]}
