)]}'
{"patrole_tempest_plugin/tests/api/network/test_policy_bandwidth_limit_rule_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1d0f1119445c1628637fc3acd141859a9ed70df4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def skip_checks(cls):"},{"line_number":29,"context_line":"        super(PolicyBandwidthLimitRulePluginRbacTest, cls).skip_checks()"},{"line_number":30,"context_line":"        if not utils.is_extension_enabled(\u0027qos\u0027, \u0027network\u0027):"},{"line_number":31,"context_line":"            msg \u003d \"qos extension not enabled.\""},{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_649aa113","line":31,"range":{"start_line":30,"start_character":8,"end_line":31,"end_character":46},"updated":"2018-09-06 00:12:20.000000000","message":"This is not the correct extension to look for: https://developer.openstack.org/api-ref/network/v2/index.html#bandwidth-limit-direction\n\nShould be: qos-bw-limit-direction","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5262a9eae9f728416435a24c2cab10f8c1c38504","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def skip_checks(cls):"},{"line_number":29,"context_line":"        super(PolicyBandwidthLimitRulePluginRbacTest, cls).skip_checks()"},{"line_number":30,"context_line":"        if not utils.is_extension_enabled(\u0027qos\u0027, \u0027network\u0027):"},{"line_number":31,"context_line":"            msg \u003d \"qos extension not enabled.\""},{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dad58ce7","line":31,"range":{"start_line":30,"start_character":8,"end_line":31,"end_character":46},"in_reply_to":"3f79a3b5_649aa113","updated":"2018-09-06 02:36:00.000000000","message":"Not really. qos-bw-limit-direction will add `direction` field to qos-policy, so you can specify f.e. to limit bandwidth only for ingress. This test does not use this functionality, and the only non-standard module in user is QoS I believe.","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1d0f1119445c1628637fc3acd141859a9ed70df4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def resource_setup(cls):"},{"line_number":36,"context_line":"        super(PolicyBandwidthLimitRulePluginRbacTest, cls).resource_setup()"},{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-qos\u0027)"},{"line_number":38,"context_line":"        cls.policy_id \u003d cls.ntp_client.create_qos_policy("},{"line_number":39,"context_line":"            name\u003dname)[\"policy\"][\"id\"]"},{"line_number":40,"context_line":"        cls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_849fbd00","line":37,"range":{"start_line":37,"start_character":63,"end_line":37,"end_character":66},"updated":"2018-09-06 00:12:20.000000000","message":"nit: Please update with `policy` instead.","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5262a9eae9f728416435a24c2cab10f8c1c38504","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def resource_setup(cls):"},{"line_number":36,"context_line":"        super(PolicyBandwidthLimitRulePluginRbacTest, cls).resource_setup()"},{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-qos\u0027)"},{"line_number":38,"context_line":"        cls.policy_id \u003d cls.ntp_client.create_qos_policy("},{"line_number":39,"context_line":"            name\u003dname)[\"policy\"][\"id\"]"},{"line_number":40,"context_line":"        cls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3a3b6038","line":37,"range":{"start_line":37,"start_character":63,"end_line":37,"end_character":66},"in_reply_to":"3f79a3b5_849fbd00","updated":"2018-09-06 02:36:00.000000000","message":"Okay, so, this is a bit confusing naming. What do you think if I change it to -qos-policy, since just `policy` give not enough context. F.E. we have firewall-policy.","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1d0f1119445c1628637fc3acd141859a9ed70df4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-qos\u0027)"},{"line_number":38,"context_line":"        cls.policy_id \u003d cls.ntp_client.create_qos_policy("},{"line_number":39,"context_line":"            name\u003dname)[\"policy\"][\"id\"]"},{"line_number":40,"context_line":"        cls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":41,"context_line":"                                    cls.ntp_client.delete_qos_policy,"},{"line_number":42,"context_line":"                                    cls.policy_id)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_248829c4","line":40,"range":{"start_line":40,"start_character":36,"end_line":40,"end_character":76},"updated":"2018-09-06 00:12:20.000000000","message":"nit: Can remove this.","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5262a9eae9f728416435a24c2cab10f8c1c38504","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(cls.__class__.__name__ + \u0027-qos\u0027)"},{"line_number":38,"context_line":"        cls.policy_id \u003d cls.ntp_client.create_qos_policy("},{"line_number":39,"context_line":"            name\u003dname)[\"policy\"][\"id\"]"},{"line_number":40,"context_line":"        cls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":41,"context_line":"                                    cls.ntp_client.delete_qos_policy,"},{"line_number":42,"context_line":"                                    cls.policy_id)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fa4088a4","line":40,"range":{"start_line":40,"start_character":36,"end_line":40,"end_character":76},"in_reply_to":"3f79a3b5_248829c4","updated":"2018-09-06 02:36:00.000000000","message":"Done","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"95e846fefb6f00ec66e9b9afac43231ca2437469","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                    cls.ntp_client.delete_qos_policy,"},{"line_number":42,"context_line":"                                    cls.policy_id)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def create_bandwidth_limit_rule(self):"},{"line_number":45,"context_line":"        rule \u003d self.ntp_client.create_bandwidth_limit_rule("},{"line_number":46,"context_line":"            self.policy_id, max_kbps\u003d1000, max_burst_kbps\u003d1000,"},{"line_number":47,"context_line":"            direction\u003d\"egress\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_babd3b69","line":44,"updated":"2018-09-05 23:17:22.000000000","message":"nit: should be _create_bandwidth_limit_rule because we wouldn\u0027t expect this function to be used outside this class","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5262a9eae9f728416435a24c2cab10f8c1c38504","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                    cls.ntp_client.delete_qos_policy,"},{"line_number":42,"context_line":"                                    cls.policy_id)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def create_bandwidth_limit_rule(self):"},{"line_number":45,"context_line":"        rule \u003d self.ntp_client.create_bandwidth_limit_rule("},{"line_number":46,"context_line":"            self.policy_id, max_kbps\u003d1000, max_burst_kbps\u003d1000,"},{"line_number":47,"context_line":"            direction\u003d\"egress\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ba18d0d2","line":44,"in_reply_to":"3f79a3b5_babd3b69","updated":"2018-09-06 02:36:00.000000000","message":"Done","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"95e846fefb6f00ec66e9b9afac43231ca2437469","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        rule_id \u003d self.create_bandwidth_limit_rule()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":78,"context_line":"            self.ntp_client.delete_bandwidth_limit_rule(self.policy_id,"},{"line_number":79,"context_line":"                                                        rule_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u0027CAA27599-082B-44B9-AF09-8C9B8E777ED7\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_01271fc9","line":78,"updated":"2018-09-05 23:17:22.000000000","message":"I think you meant to test show here, not delete!","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"5262a9eae9f728416435a24c2cab10f8c1c38504","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        rule_id \u003d self.create_bandwidth_limit_rule()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":78,"context_line":"            self.ntp_client.delete_bandwidth_limit_rule(self.policy_id,"},{"line_number":79,"context_line":"                                                        rule_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @decorators.idempotent_id(\u0027CAA27599-082B-44B9-AF09-8C9B8E777ED7\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9a1394b8","line":78,"in_reply_to":"3f79a3b5_01271fc9","updated":"2018-09-06 02:36:00.000000000","message":"Done","commit_id":"286d6775e688763ff011c8cd3e75e308c658c28d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"432bc9d9ec9d7e0b14ec88838aff47675773f64a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 AT\u0026T Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e464464b","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2018-09-20 19:12:09.000000000","message":"nit: 2018","commit_id":"d646a4cfa5b019c4e127c8264305ea80bf5e06a7"}]}