)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"c0f81d182eea6faa99c34294b2275ec919a77935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"3f79a3b5_5808928f","updated":"2018-10-02 20:42:12.000000000","message":"I think the commit message should include the rationale behind adding a service client to Patrole directly as this is the first time we are doing this. Maybe even documentation stating under which circumstances it is acceptable to add a service client directly to Patrole.","commit_id":"45e1387359fd96d37e19384b5d6ffc29bc619838"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"cb1dc2c56e6d402209fff6741d0abc9f443bd51c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-09-26 17:06:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for missing FWaaS policy actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027insert_rule\u0027"},{"line_number":10,"context_line":"\u0027remove_rule\u0027"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"3f79a3b5_884b195d","line":8,"updated":"2018-10-04 04:25:25.000000000","message":"This should include some info on how this is adding support for fwaas tests, that the service client implementation is added here because fwaas tempest plugin is in tree which means it\u0027ll move in the future as part of the tempest plugin governance initiative, etc.","commit_id":"45e1387359fd96d37e19384b5d6ffc29bc619838"}],"patrole_tempest_plugin/services/network/fwaas_v2_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"47a0b0f3c971f09211a78141a1e29f8dec1125b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_bd6ef161","line":6,"updated":"2018-09-26 20:21:11.000000000","message":"Ditto, may this go into fwaas subfolder?","commit_id":"52f1760a5454946c96de7dcf1392b20fe3d54ae4"}],"patrole_tempest_plugin/tests/api/network/fwaas/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f347f1e9c334fe273646ec9709a0dd7e385b95a9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        body \u003d self.fwaas_client.create_firewall_policy("},{"line_number":53,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":54,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":55,"context_line":"        self.addCleanup(self.delete_policy, fw_policy[\u0027id\u0027])"},{"line_number":56,"context_line":"        return fw_policy"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete_policy(self, policy_id):"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_cefc2473","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":42},"updated":"2018-10-23 21:51:05.000000000","message":"It might be better to add test_utils.call_and_ignore_notfound_exc here in case this is used in a delete RBAC test that already deletes the resource prior to the clean up.","commit_id":"d7590cb6075b9087a3d24bf2f2aad1e5b106c094"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f347f1e9c334fe273646ec9709a0dd7e385b95a9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.addCleanup(self.delete_policy, fw_policy[\u0027id\u0027])"},{"line_number":56,"context_line":"        return fw_policy"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete_policy(self, policy_id):"},{"line_number":59,"context_line":"        policy \u003d self.fwaas_client.show_firewall_policy(policy_id)["},{"line_number":60,"context_line":"            \u0027firewall_policy\u0027]"},{"line_number":61,"context_line":"        if policy[\u0027firewall_rules\u0027]:"},{"line_number":62,"context_line":"            for rule_id in policy[\u0027firewall_rules\u0027]:"},{"line_number":63,"context_line":"                self.remove_rule_from_policy(policy_id, rule_id)"},{"line_number":64,"context_line":"        self.fwaas_client.delete_firewall_policy(policy_id)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_rule(self):"},{"line_number":67,"context_line":"        body \u003d self.fwaas_client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_0ede9c0f","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":59},"updated":"2018-10-23 21:51:05.000000000","message":"This is OK so long as it\u0027s not called directly as it\u0027s not idempotent enough for RBAC testing. It\u0027s a good clean up function though.","commit_id":"d7590cb6075b9087a3d24bf2f2aad1e5b106c094"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f347f1e9c334fe273646ec9709a0dd7e385b95a9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        body \u003d self.fwaas_client.create_firewall_rule("},{"line_number":68,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"))"},{"line_number":69,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":70,"context_line":"        self.addCleanup(self.delete_rule, fw_rule[\u0027id\u0027])"},{"line_number":71,"context_line":"        return fw_rule"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def delete_rule(self, rule_id):"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_4ecfb453","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":40},"updated":"2018-10-23 21:51:05.000000000","message":"It might be better to add test_utils.call_and_ignore_notfound_exc here in case this is used in a delete RBAC test that already deletes the resource prior to the clean up.","commit_id":"d7590cb6075b9087a3d24bf2f2aad1e5b106c094"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"706ca717514f99168c3d439d4b4c74bfb5c013ef","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        body \u003d self.fwaas_client.create_firewall_rule("},{"line_number":68,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"))"},{"line_number":69,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":70,"context_line":"        self.addCleanup(self.delete_rule, fw_rule[\u0027id\u0027])"},{"line_number":71,"context_line":"        return fw_rule"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def delete_rule(self, rule_id):"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_2e511832","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":40},"in_reply_to":"3f79a3b5_4ecfb453","updated":"2018-10-23 22:03:47.000000000","message":"Good point, thanks","commit_id":"d7590cb6075b9087a3d24bf2f2aad1e5b106c094"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f347f1e9c334fe273646ec9709a0dd7e385b95a9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.addCleanup(self.delete_rule, fw_rule[\u0027id\u0027])"},{"line_number":71,"context_line":"        return fw_rule"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def delete_rule(self, rule_id):"},{"line_number":74,"context_line":"        rule \u003d self.fwaas_client.show_firewall_rule(rule_id)[\u0027firewall_rule\u0027]"},{"line_number":75,"context_line":"        if rule[\u0027firewall_policy_id\u0027]:"},{"line_number":76,"context_line":"            for policy_id in rule[\u0027firewall_policy_id\u0027]:"},{"line_number":77,"context_line":"                self.remove_rule_from_policy(policy_id, rule_id)"},{"line_number":78,"context_line":"        self.fwaas_client.delete_firewall_rule(rule_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def insert_rule_in_policy(self, policy_id, rule_id):"},{"line_number":81,"context_line":"        self.fwaas_client.insert_firewall_rule_in_policy("}],"source_content_type":"text/x-python","patch_set":32,"id":"3f79a3b5_4eba54ba","line":78,"range":{"start_line":73,"start_character":0,"end_line":78,"end_character":55},"updated":"2018-10-23 21:51:05.000000000","message":"This is OK so long as it\u0027s not called directly as it\u0027s not idempotent enough for RBAC testing. It\u0027s a good clean up function though.","commit_id":"d7590cb6075b9087a3d24bf2f2aad1e5b106c094"}],"patrole_tempest_plugin/tests/api/network/rbac_base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3fa046b6dd9b70c842833fc2d8ef958aa25a4dda","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return manager"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class FWaaSV2Client(base.BaseNetworkClient):"},{"line_number":88,"context_line":"    def create_firewall_rule(self, **kwargs):"},{"line_number":89,"context_line":"        uri \u003d \u0027/fwaas/firewall_rules\u0027"},{"line_number":90,"context_line":"        post_data \u003d {\u0027firewall_rule\u0027: kwargs}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_8d6907f9","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":19},"updated":"2018-09-07 04:54:42.000000000","message":"Is there any reason this needs to be included here? Why can\u0027t we leverage the one from FWAAS tempest plugin? Is it because that plugin isn\u0027t \"stable\" in the sense that it hasn\u0027t migrated its code base over to a proper Tempest plugin repo?\n\nThis is a little concerning because it is preferable to use a stable library like tempest.lib or a plugin which maintains this itself, so that we don\u0027t have to worry about maintaining this in Patrole itself.\n\nFurthermore, if we want to add this, this needs to go somewhere else:\n\nhttps://docs.openstack.org/tempest/latest/plugin.html#plugin-structure\n\nNamely, under services/network/fwaas_v2_client.py or something.","commit_id":"da5a20867f0f392e4aa520c78cb5551f0c83494d"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"0a7395eda99f1dc59351ae2142e782832f64db04","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return manager"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class FWaaSV2Client(base.BaseNetworkClient):"},{"line_number":88,"context_line":"    def create_firewall_rule(self, **kwargs):"},{"line_number":89,"context_line":"        uri \u003d \u0027/fwaas/firewall_rules\u0027"},{"line_number":90,"context_line":"        post_data \u003d {\u0027firewall_rule\u0027: kwargs}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_39fa6774","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":19},"in_reply_to":"3f79a3b5_8d6907f9","updated":"2018-09-07 17:44:57.000000000","message":"I created it to avoid importing module from fwaas.tests.tempest_plugin.... because as your wrote earlier it should be move to a separate repo.\nI will move it to service/network/fwaas_v2_client.py","commit_id":"da5a20867f0f392e4aa520c78cb5551f0c83494d"}],"patrole_tempest_plugin/tests/api/network/test_fwaas_v2_rbac.py":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"ec6dfd8cd5d4a6d3559663c944376ca003214f96","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        self.fw_rule[\u0027id\u0027])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def tearDown(self):"},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            self.fwaas_policies_client.remove_firewall_rule_from_policy("},{"line_number":45,"context_line":"                firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"},{"line_number":46,"context_line":"                firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])"},{"line_number":47,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":48,"context_line":"            # Skip exception FirewallRuleNotAssociatedWithPolicy"},{"line_number":49,"context_line":"            if e.resp_body[\u0027type\u0027] !\u003d \u0027FirewallRuleNotAssociatedWithPolicy\u0027:"},{"line_number":50,"context_line":"                raise"},{"line_number":51,"context_line":"        super(FWaaSV2RbacTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u00273a4698d1-01d9-4241-ac58-70763d8ffa53\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_c70f132c","line":50,"range":{"start_line":43,"start_character":0,"end_line":50,"end_character":21},"updated":"2018-09-05 01:06:49.000000000","message":"Can we add self.addCleanup to test_insert_rule and avoid it?","commit_id":"0a060b82796459fd5e62559a2e685e1fd255b129"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dde45340fabfac050ec360236345bc0087471aca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        self.fw_rule[\u0027id\u0027])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def tearDown(self):"},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            self.fwaas_policies_client.remove_firewall_rule_from_policy("},{"line_number":45,"context_line":"                firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"},{"line_number":46,"context_line":"                firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])"},{"line_number":47,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":48,"context_line":"            # Skip exception FirewallRuleNotAssociatedWithPolicy"},{"line_number":49,"context_line":"            if e.resp_body[\u0027type\u0027] !\u003d \u0027FirewallRuleNotAssociatedWithPolicy\u0027:"},{"line_number":50,"context_line":"                raise"},{"line_number":51,"context_line":"        super(FWaaSV2RbacTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u00273a4698d1-01d9-4241-ac58-70763d8ffa53\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_c896434a","line":50,"range":{"start_line":43,"start_character":0,"end_line":50,"end_character":21},"in_reply_to":"3f79a3b5_27060788","updated":"2018-09-05 04:03:54.000000000","message":"This change won\u0027t work because if L76-78 fails with 403/404 (RBAC failure) in negative case, then we will still have the lingering firewall rule. That said, that could be handled via:\n\n\n        self.fwaas_policies_client.insert_firewall_rule_in_policy(\n            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],\n            firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])\n        self.addCleanup(\n            test_utils.call_and_ignore_notfound_exc,\n            self.fwaas_policies_client.remove_firewall_rule_from_policy,\n            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],\n            firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])\n        with self.rbac_utils.override_role(self):\n            self.fwaas_policies_client.remove_firewall_rule_from_policy(\n                firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],\n                firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])\n\nBut this will only work if the firewall rule not existing raises a 404 instead of a 400.","commit_id":"0a060b82796459fd5e62559a2e685e1fd255b129"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"55cba8343668d8126d762f22e2cca2797a2c20bc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        self.fw_rule[\u0027id\u0027])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def tearDown(self):"},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            self.fwaas_policies_client.remove_firewall_rule_from_policy("},{"line_number":45,"context_line":"                firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"},{"line_number":46,"context_line":"                firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])"},{"line_number":47,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":48,"context_line":"            # Skip exception FirewallRuleNotAssociatedWithPolicy"},{"line_number":49,"context_line":"            if e.resp_body[\u0027type\u0027] !\u003d \u0027FirewallRuleNotAssociatedWithPolicy\u0027:"},{"line_number":50,"context_line":"                raise"},{"line_number":51,"context_line":"        super(FWaaSV2RbacTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u00273a4698d1-01d9-4241-ac58-70763d8ffa53\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_27060788","line":50,"range":{"start_line":43,"start_character":0,"end_line":50,"end_character":21},"in_reply_to":"3f79a3b5_c70f132c","updated":"2018-09-05 01:29:30.000000000","message":"Done","commit_id":"0a060b82796459fd5e62559a2e685e1fd255b129"},{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"ec6dfd8cd5d4a6d3559663c944376ca003214f96","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(FWaaSV2RbacTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u00273a4698d1-01d9-4241-ac58-70763d8ffa53\u0027)"},{"line_number":54,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\", rules\u003d[\"insert_rule\"])"},{"line_number":55,"context_line":"    def test_insert_rule(self):"},{"line_number":56,"context_line":"        \"\"\"Insert rule."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_67e2bf32","line":54,"range":{"start_line":54,"start_character":42,"end_line":54,"end_character":49},"updated":"2018-09-05 01:06:49.000000000","message":"My best guess is to set:\n\ncustom_policy_files\u003d/etc/%s/policy.json,/etc/neutron/policy.d/%s.json\n\nand set service to `neutron-fwaas`","commit_id":"0a060b82796459fd5e62559a2e685e1fd255b129"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"55cba8343668d8126d762f22e2cca2797a2c20bc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(FWaaSV2RbacTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u00273a4698d1-01d9-4241-ac58-70763d8ffa53\u0027)"},{"line_number":54,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\", rules\u003d[\"insert_rule\"])"},{"line_number":55,"context_line":"    def test_insert_rule(self):"},{"line_number":56,"context_line":"        \"\"\"Insert rule."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_07018b6a","line":54,"range":{"start_line":54,"start_character":42,"end_line":54,"end_character":49},"in_reply_to":"3f79a3b5_67e2bf32","updated":"2018-09-05 01:29:30.000000000","message":"Let\u0027s wait zuul","commit_id":"0a060b82796459fd5e62559a2e685e1fd255b129"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fda4603967dfa2c8c8e1892fc4fa5af165daa4e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        body \u003d self.fwaas_policies_client.create_firewall_policy("},{"line_number":30,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":31,"context_line":"        self.fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":32,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":33,"context_line":"                        self.fwaas_policies_client.delete_firewall_policy,"},{"line_number":34,"context_line":"                        self.fw_policy[\u0027id\u0027])"},{"line_number":35,"context_line":"        body \u003d self.fwaas_rules_client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4899d36a","line":32,"range":{"start_line":32,"start_character":24,"end_line":32,"end_character":63},"updated":"2018-09-05 04:14:32.000000000","message":"We can remove this.","commit_id":"def70ef3807153db30b80426404dd149e24e0473"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"c51db8607bd8ea8068743f59d7e17681819ad65d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        body \u003d self.fwaas_policies_client.create_firewall_policy("},{"line_number":30,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":31,"context_line":"        self.fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":32,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":33,"context_line":"                        self.fwaas_policies_client.delete_firewall_policy,"},{"line_number":34,"context_line":"                        self.fw_policy[\u0027id\u0027])"},{"line_number":35,"context_line":"        body \u003d self.fwaas_rules_client.create_firewall_rule("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5e83be56","line":32,"range":{"start_line":32,"start_character":24,"end_line":32,"end_character":63},"in_reply_to":"3f79a3b5_4899d36a","updated":"2018-09-05 16:05:28.000000000","message":"Done","commit_id":"def70ef3807153db30b80426404dd149e24e0473"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fda4603967dfa2c8c8e1892fc4fa5af165daa4e2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        body \u003d self.fwaas_rules_client.create_firewall_rule("},{"line_number":36,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"))"},{"line_number":37,"context_line":"        self.fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":38,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":39,"context_line":"                        self.fwaas_rules_client.delete_firewall_rule,"},{"line_number":40,"context_line":"                        self.fw_rule[\u0027id\u0027])"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_089f5b50","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":64},"updated":"2018-09-05 04:14:32.000000000","message":"Ditto.","commit_id":"def70ef3807153db30b80426404dd149e24e0473"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"c51db8607bd8ea8068743f59d7e17681819ad65d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        body \u003d self.fwaas_rules_client.create_firewall_rule("},{"line_number":36,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"))"},{"line_number":37,"context_line":"        self.fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":38,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":39,"context_line":"                        self.fwaas_rules_client.delete_firewall_rule,"},{"line_number":40,"context_line":"                        self.fw_rule[\u0027id\u0027])"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_beb0d241","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":64},"in_reply_to":"3f79a3b5_089f5b50","updated":"2018-09-05 16:05:28.000000000","message":"Done","commit_id":"def70ef3807153db30b80426404dd149e24e0473"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3fa046b6dd9b70c842833fc2d8ef958aa25a4dda","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        RBAC test for the FWaaS \"remove_rule\" policy"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.fwaas_v2_client.insert_firewall_rule_in_policy("},{"line_number":61,"context_line":"            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"},{"line_number":62,"context_line":"            firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])"},{"line_number":63,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":64,"context_line":"            self.fwaas_v2_client.remove_firewall_rule_from_policy("},{"line_number":65,"context_line":"                firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_0d7df7b0","line":62,"range":{"start_line":60,"start_character":8,"end_line":62,"end_character":48},"updated":"2018-09-07 04:54:42.000000000","message":"This needs to handle the case where if the `remove_firewall_rule_from_policy` call below fails with a 403 (which is entirely possible as we do implicit negative testing) then a cleanup call with the `remove_firewall_rule_from_policy` is required. What I mean is this:\n\n     self.fwaas_v2_client.insert_firewall_rule_in_policy(...)\n     self.addCleanup(test_utils.call_and_ignore_notfound_exc,\n                                 self.fwaas_v2_client.remove_fire_rule_from_policy, ...)","commit_id":"da5a20867f0f392e4aa520c78cb5551f0c83494d"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"0a7395eda99f1dc59351ae2142e782832f64db04","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        RBAC test for the FWaaS \"remove_rule\" policy"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.fwaas_v2_client.insert_firewall_rule_in_policy("},{"line_number":61,"context_line":"            firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"},{"line_number":62,"context_line":"            firewall_rule_id\u003dself.fw_rule[\u0027id\u0027])"},{"line_number":63,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":64,"context_line":"            self.fwaas_v2_client.remove_firewall_rule_from_policy("},{"line_number":65,"context_line":"                firewall_policy_id\u003dself.fw_policy[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_b92bd7e8","line":62,"range":{"start_line":60,"start_character":8,"end_line":62,"end_character":48},"in_reply_to":"3f79a3b5_0d7df7b0","updated":"2018-09-07 17:44:57.000000000","message":"How it works now? :) I thought about and already had something, but removed. Will restore that code","commit_id":"da5a20867f0f392e4aa520c78cb5551f0c83494d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c7a8536e86dd0db2bdde31bad93a8233ac7c4c2c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            firewall_policy_id\u003dpolicy_id,"},{"line_number":80,"context_line":"            firewall_rule_id\u003drule_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def remove_rule_and_ignore_notassociated(self, policy_id, rule_id):"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            self.remove_rule(policy_id, rule_id)"},{"line_number":85,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":86,"context_line":"            # Skip only FirewallRuleNotAssociatedWithPolicy exception"},{"line_number":87,"context_line":"            if e.resp_body[\u0027type\u0027] !\u003d \u0027FirewallRuleNotAssociatedWithPolicy\u0027:"},{"line_number":88,"context_line":"                raise"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class FWaaSV2PluginRbacTest(BaseFWaaSV2PluginRbacTest):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_0a32615f","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":21},"updated":"2018-09-12 04:01:03.000000000","message":"There is another way to accomplish this without having to check for an exception class name which is not good for a black box testing framework like Patrole to rely on.\n\nIt would be better to simply do on L96 below:\n\n@classmethod\ndef resource_cleanup(cls):\n    rules \u003d cls.fwaas_v2_client.get_firewall_rules()[\u0027firewall_rules\u0027]\n    for rule in rules:\n        cls. cls.fwaas_v2_client.remove_rule(rule[\u0027id\u0027])\n    super(...)","commit_id":"fdbf24e17511aa874e3b8634f0415c7e2041c8bf"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"8c3c8cd057c9d326ec8519ebc13fb7c74f88048d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            firewall_policy_id\u003dpolicy_id,"},{"line_number":80,"context_line":"            firewall_rule_id\u003drule_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def remove_rule_and_ignore_notassociated(self, policy_id, rule_id):"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            self.remove_rule(policy_id, rule_id)"},{"line_number":85,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":86,"context_line":"            # Skip only FirewallRuleNotAssociatedWithPolicy exception"},{"line_number":87,"context_line":"            if e.resp_body[\u0027type\u0027] !\u003d \u0027FirewallRuleNotAssociatedWithPolicy\u0027:"},{"line_number":88,"context_line":"                raise"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class FWaaSV2PluginRbacTest(BaseFWaaSV2PluginRbacTest):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f79a3b5_c469b826","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":21},"in_reply_to":"3f79a3b5_0a32615f","updated":"2018-09-12 11:34:06.000000000","message":"hmmm, yes","commit_id":"fdbf24e17511aa874e3b8634f0415c7e2041c8bf"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"47a0b0f3c971f09211a78141a1e29f8dec1125b9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class BaseFWaaSV2PluginRbacTest(rbac_base.BaseNetworkRbacTest):"},{"line_number":28,"context_line":"    \"\"\"Base class to be used with tests that require FWaaS v2 extension"},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(BaseFWaaSV2PluginRbacTest, cls).skip_checks()"},{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            import neutron_fwaas  # noqa"},{"line_number":36,"context_line":"        except ImportError:"},{"line_number":37,"context_line":"            msg \u003d \"FWaaS v2 Extension not installed.\""},{"line_number":38,"context_line":"            raise cls.skipException(msg)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def setup_clients(cls):"},{"line_number":42,"context_line":"        super(BaseFWaaSV2PluginRbacTest, cls).setup_clients()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls.fwaas_v2_client \u003d fwaas_v2_client.FWaaSV2Client("},{"line_number":45,"context_line":"            cls.os_primary.auth_provider,"},{"line_number":46,"context_line":"            CONF.network.catalog_type,"},{"line_number":47,"context_line":"            CONF.network.region or CONF.identity.region,"},{"line_number":48,"context_line":"            endpoint_type\u003dCONF.network.endpoint_type,"},{"line_number":49,"context_line":"            build_interval\u003dCONF.network.build_interval,"},{"line_number":50,"context_line":"            build_timeout\u003dCONF.network.build_timeout,"},{"line_number":51,"context_line":"            **cls.os_primary.default_params)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_policy(self):"},{"line_number":54,"context_line":"        body \u003d self.fwaas_v2_client.create_firewall_policy("},{"line_number":55,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":56,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":57,"context_line":"        self.addCleanup(self.delete_policy, fw_policy[\u0027id\u0027])"},{"line_number":58,"context_line":"        return fw_policy"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def delete_policy(self, policy_id):"},{"line_number":61,"context_line":"        policy \u003d self.fwaas_v2_client.show_firewall_policy("},{"line_number":62,"context_line":"            policy_id)[\u0027firewall_policy\u0027]"},{"line_number":63,"context_line":"        if policy[\u0027firewall_rules\u0027]:"},{"line_number":64,"context_line":"            for rule_id in policy[\u0027firewall_rules\u0027]:"},{"line_number":65,"context_line":"                self.remove_rule_from_policy(policy_id, rule_id)"},{"line_number":66,"context_line":"        self.fwaas_v2_client.delete_firewall_policy(policy_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_rule(self):"},{"line_number":69,"context_line":"        body \u003d self.fwaas_v2_client.create_firewall_rule("},{"line_number":70,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"))"},{"line_number":71,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":72,"context_line":"        self.addCleanup(self.delete_rule, fw_rule[\u0027id\u0027])"},{"line_number":73,"context_line":"        return fw_rule"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def delete_rule(self, rule_id):"},{"line_number":76,"context_line":"        rule \u003d self.fwaas_v2_client.show_firewall_rule("},{"line_number":77,"context_line":"            rule_id)[\u0027firewall_rule\u0027]"},{"line_number":78,"context_line":"        if rule[\u0027firewall_policy_id\u0027]:"},{"line_number":79,"context_line":"            for policy_id in rule[\u0027firewall_policy_id\u0027]:"},{"line_number":80,"context_line":"                self.remove_rule_from_policy(policy_id, rule_id)"},{"line_number":81,"context_line":"        self.fwaas_v2_client.delete_firewall_rule(rule_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def insert_rule_in_policy(self, policy_id, rule_id):"},{"line_number":84,"context_line":"        self.fwaas_v2_client.insert_firewall_rule_in_policy("},{"line_number":85,"context_line":"            firewall_policy_id\u003dpolicy_id,"},{"line_number":86,"context_line":"            firewall_rule_id\u003drule_id)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def remove_rule_from_policy(self, policy_id, rule_id):"},{"line_number":89,"context_line":"        self.fwaas_v2_client.remove_firewall_rule_from_policy("},{"line_number":90,"context_line":"            firewall_policy_id\u003dpolicy_id,"},{"line_number":91,"context_line":"            firewall_rule_id\u003drule_id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class FWaaSV2PluginRbacTest(BaseFWaaSV2PluginRbacTest):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_fd746939","line":91,"range":{"start_line":27,"start_character":0,"end_line":91,"end_character":37},"updated":"2018-09-26 20:21:11.000000000","message":"May we move this into a dedicated fwaas folder structure? E.g.:\n\npatrole_tempest_plugin/tests/api/network/fwaas/base.py\n\nThen move the below into:\n\npatrole_tempest_plugin/tests/api/network/fwaas/fwaas_rules.py (or whatever name is most appropriate)","commit_id":"52f1760a5454946c96de7dcf1392b20fe3d54ae4"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"f70b1dd986690bfef42ca8331dd2740d006b3d93","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class BaseFWaaSV2PluginRbacTest(rbac_base.BaseNetworkRbacTest):"},{"line_number":28,"context_line":"    \"\"\"Base class to be used with tests that require FWaaS v2 extension"},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def skip_checks(cls):"},{"line_number":33,"context_line":"        super(BaseFWaaSV2PluginRbacTest, cls).skip_checks()"},{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            import neutron_fwaas  # noqa"},{"line_number":36,"context_line":"        except ImportError:"},{"line_number":37,"context_line":"            msg \u003d \"FWaaS v2 Extension not installed.\""},{"line_number":38,"context_line":"            raise cls.skipException(msg)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def setup_clients(cls):"},{"line_number":42,"context_line":"        super(BaseFWaaSV2PluginRbacTest, cls).setup_clients()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls.fwaas_v2_client \u003d fwaas_v2_client.FWaaSV2Client("},{"line_number":45,"context_line":"            cls.os_primary.auth_provider,"},{"line_number":46,"context_line":"            CONF.network.catalog_type,"},{"line_number":47,"context_line":"            CONF.network.region or CONF.identity.region,"},{"line_number":48,"context_line":"            endpoint_type\u003dCONF.network.endpoint_type,"},{"line_number":49,"context_line":"            build_interval\u003dCONF.network.build_interval,"},{"line_number":50,"context_line":"            build_timeout\u003dCONF.network.build_timeout,"},{"line_number":51,"context_line":"            **cls.os_primary.default_params)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_policy(self):"},{"line_number":54,"context_line":"        body \u003d self.fwaas_v2_client.create_firewall_policy("},{"line_number":55,"context_line":"            name\u003ddata_utils.rand_name(\"fw-policy\"))"},{"line_number":56,"context_line":"        fw_policy \u003d body[\u0027firewall_policy\u0027]"},{"line_number":57,"context_line":"        self.addCleanup(self.delete_policy, fw_policy[\u0027id\u0027])"},{"line_number":58,"context_line":"        return fw_policy"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def delete_policy(self, policy_id):"},{"line_number":61,"context_line":"        policy \u003d self.fwaas_v2_client.show_firewall_policy("},{"line_number":62,"context_line":"            policy_id)[\u0027firewall_policy\u0027]"},{"line_number":63,"context_line":"        if policy[\u0027firewall_rules\u0027]:"},{"line_number":64,"context_line":"            for rule_id in policy[\u0027firewall_rules\u0027]:"},{"line_number":65,"context_line":"                self.remove_rule_from_policy(policy_id, rule_id)"},{"line_number":66,"context_line":"        self.fwaas_v2_client.delete_firewall_policy(policy_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_rule(self):"},{"line_number":69,"context_line":"        body \u003d self.fwaas_v2_client.create_firewall_rule("},{"line_number":70,"context_line":"            name\u003ddata_utils.rand_name(\"fw-rule\"))"},{"line_number":71,"context_line":"        fw_rule \u003d body[\u0027firewall_rule\u0027]"},{"line_number":72,"context_line":"        self.addCleanup(self.delete_rule, fw_rule[\u0027id\u0027])"},{"line_number":73,"context_line":"        return fw_rule"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def delete_rule(self, rule_id):"},{"line_number":76,"context_line":"        rule \u003d self.fwaas_v2_client.show_firewall_rule("},{"line_number":77,"context_line":"            rule_id)[\u0027firewall_rule\u0027]"},{"line_number":78,"context_line":"        if rule[\u0027firewall_policy_id\u0027]:"},{"line_number":79,"context_line":"            for policy_id in rule[\u0027firewall_policy_id\u0027]:"},{"line_number":80,"context_line":"                self.remove_rule_from_policy(policy_id, rule_id)"},{"line_number":81,"context_line":"        self.fwaas_v2_client.delete_firewall_rule(rule_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def insert_rule_in_policy(self, policy_id, rule_id):"},{"line_number":84,"context_line":"        self.fwaas_v2_client.insert_firewall_rule_in_policy("},{"line_number":85,"context_line":"            firewall_policy_id\u003dpolicy_id,"},{"line_number":86,"context_line":"            firewall_rule_id\u003drule_id)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def remove_rule_from_policy(self, policy_id, rule_id):"},{"line_number":89,"context_line":"        self.fwaas_v2_client.remove_firewall_rule_from_policy("},{"line_number":90,"context_line":"            firewall_policy_id\u003dpolicy_id,"},{"line_number":91,"context_line":"            firewall_rule_id\u003drule_id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class FWaaSV2PluginRbacTest(BaseFWaaSV2PluginRbacTest):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3f79a3b5_a8a79150","line":91,"range":{"start_line":27,"start_character":0,"end_line":91,"end_character":37},"in_reply_to":"3f79a3b5_fd746939","updated":"2018-09-26 21:56:23.000000000","message":"Ok. will do it","commit_id":"52f1760a5454946c96de7dcf1392b20fe3d54ae4"}]}
