)]}'
{"patrole_tempest_plugin/tests/api/network/test_subnetpools_rbac.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"6122c780db15fea2defe3c774523a54ec51283a2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return subnetpool"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":56,"context_line":"                                 rules\u003d[\"list_subnetpools\"])"},{"line_number":57,"context_line":"    @decorators.idempotent_id(\u0027f1caf0f6-bde5-11e8-a355-529269fb1459\u0027)"},{"line_number":58,"context_line":"    def test_list_subnetpools(self):"},{"line_number":59,"context_line":"        \"\"\"list subnetpools."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e4c87476","line":56,"updated":"2018-09-25 17:51:43.000000000","message":"There is no `list_subnetpools` policy in default policy.json. You need to use `get_subnetpool` policy.","commit_id":"12ac02d8f3b20f3d4275572e63d9314956061cdd"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"4d4a2b56c0d22459e9642012b795bc90ab965610","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def test_list_subnetpools(self):"},{"line_number":59,"context_line":"        \"\"\"list subnetpools."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        RBAC test for the neutron list_subnetpools policy"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":64,"context_line":"            self.subnetpools_client.list_subnetpools()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_715f410f","line":61,"range":{"start_line":61,"start_character":34,"end_line":61,"end_character":50},"updated":"2018-09-25 20:07:14.000000000","message":"nit: this should be get_subnetpools","commit_id":"47241e8b41c8788140c343512d6f2fb12e40f795"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"4d4a2b56c0d22459e9642012b795bc90ab965610","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        RBAC test for the neutron list_subnetpools policy"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":64,"context_line":"            self.subnetpools_client.list_subnetpools()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":67,"context_line":"                                 rule\u003d\"create_subnetpool\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_74c5ef5b","line":64,"updated":"2018-09-25 20:07:14.000000000","message":"Neutron behaves in a kinda funny way when it comes to listing things. Even if you\u0027re not allowed by the policy, you can still call the api without receiving an error back. Instead neutron limits what is returned by the list function.\n\nThe default policy.json says\n  \"get_subnetpool\": \"rule:admin_or_owner or rule:shared_subnetpools\",\n\nso an admin should be able to see all the subnetpools and a user should be able to see subnet pools that they own.\n\nI think you need to check that this filtering behavior is working as expected.","commit_id":"47241e8b41c8788140c343512d6f2fb12e40f795"}]}