)]}'
{".gitignore":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"5b802aeea82287ab35854951e425d4f62b95724f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Installer logs"},{"line_number":22,"context_line":"pip-log.txt"},{"line_number":23,"context_line":"*.log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Unit test / coverage reports"},{"line_number":26,"context_line":"cover/"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3f79a3b5_43da37e6","line":23,"updated":"2018-10-23 14:41:46.000000000","message":"I guess, you can add it into .gitignore_global  file or make a separate commit. It\u0027s not related to this task","commit_id":"0e204ac7f2cd34e8f0fa5a430310cf5c9f21ac63"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"a609e29d55bc7bf0f5880f8437dd0d26371e4d10","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Installer logs"},{"line_number":22,"context_line":"pip-log.txt"},{"line_number":23,"context_line":"*.log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Unit test / coverage reports"},{"line_number":26,"context_line":"cover/"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3f79a3b5_fe875810","line":23,"in_reply_to":"3f79a3b5_43da37e6","updated":"2018-10-23 14:58:46.000000000","message":"+1","commit_id":"0e204ac7f2cd34e8f0fa5a430310cf5c9f21ac63"}],"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"c00f74c585b7d7e72b268da0eb85cd795196c379","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit is dependent on a commit of neutron-tempest-plugin:"},{"line_number":14,"context_line":"https://review.openstack.org/#/c/605766/3"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I39b10e06d9bcbf6fa939ee4603e830bb935e716b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_8ca246ac","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":41},"updated":"2018-10-04 11:17:05.000000000","message":"I am sorry. I just checked.\nI think it\u0027s better to give reference for patch, not patch set.\nCurrently, it is referring to PS3 but already updated with another patch-set.\nor\nYou can also give the Change-ID of that patch.","commit_id":"e5bde95127f8e4190273a0b2ba2dcca4093e05b7"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"5b802aeea82287ab35854951e425d4f62b95724f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit is dependent on a commit of neutron-tempest-plugin"},{"line_number":14,"context_line":"Dependent-Change-ID: I881e3e038a775bd826b5c5675cb95e949f9c717e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I39b10e06d9bcbf6fa939ee4603e830bb935e716b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_637173df","line":14,"updated":"2018-10-23 14:41:46.000000000","message":"For cross repository dependencies You need to use \"Depends-On\", not \"Dependent-Change-ID\": https://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies","commit_id":"0e204ac7f2cd34e8f0fa5a430310cf5c9f21ac63"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"a609e29d55bc7bf0f5880f8437dd0d26371e4d10","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit is dependent on a commit of neutron-tempest-plugin"},{"line_number":14,"context_line":"Dependent-Change-ID: I881e3e038a775bd826b5c5675cb95e949f9c717e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I39b10e06d9bcbf6fa939ee4603e830bb935e716b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_9e93c44e","line":14,"in_reply_to":"3f79a3b5_637173df","updated":"2018-10-23 14:58:46.000000000","message":"Ok sir :)","commit_id":"0e204ac7f2cd34e8f0fa5a430310cf5c9f21ac63"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4129b6c11ab843a2f8bcd23da3351a38107d7745","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The operation is only"},{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit is dependent on a commit of patrole"},{"line_number":14,"context_line":"Depends-On: I5f39efc8aa0004d4ad435cbd6b8fb037c33832d6"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit is also dependent on a commit of neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f79a3b5_aecd56ba","line":13,"updated":"2018-11-19 16:29:19.000000000","message":"Nit: this line is not needed, only Depends-On. Ditto below.","commit_id":"d3733e59bd64198f26fa139d3e6bf7eebe74e759"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"d66526ab93a33c4d90afbcabc18f469671151664","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The operation is only"},{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit is dependent on a commit of patrole"},{"line_number":14,"context_line":"Depends-On: I5f39efc8aa0004d4ad435cbd6b8fb037c33832d6"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit is also dependent on a commit of neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f79a3b5_09f1e4df","line":13,"in_reply_to":"3f79a3b5_aecd56ba","updated":"2018-11-19 17:28:04.000000000","message":"ok","commit_id":"d3733e59bd64198f26fa139d3e6bf7eebe74e759"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"3a9c2ff2f511d21a0b23bd78e051c13d79381363","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The operation is only"},{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I5f39efc8aa0004d4ad435cbd6b8fb037c33832d6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I7e5e706c44136e0b565f3ee18e15f1166d82040d"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3f79a3b5_041a2918","line":13,"updated":"2018-11-19 18:29:06.000000000","message":"Hmm, sorry, I didn\u0027t check that this refers to the Patrole\u0027s commit. You don\u0027t need to use Depends-On tag for same project. Just rebase you commit over that one and push them together.\n\n    git review -d I5f39efc8aa0004d4ad435cbd6b8fb037c33832d6\n    git checkout \u003cyours\u003e\n    git rebase review/sergey_vilgelm/generic-list","commit_id":"a176e3679c572fbdfe0a1261863cab76673ad867"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"124a5eb9a18a2e19626917b5883e1040e6c26d44","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The operation is only"},{"line_number":11,"context_line":"- List available zones"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I5f39efc8aa0004d4ad435cbd6b8fb037c33832d6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I7e5e706c44136e0b565f3ee18e15f1166d82040d"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3f79a3b5_c718a988","line":13,"in_reply_to":"3f79a3b5_041a2918","updated":"2018-11-21 16:07:42.000000000","message":"Done","commit_id":"a176e3679c572fbdfe0a1261863cab76673ad867"}],"patrole_tempest_plugin/tests/api/network/test_availability_zones_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4129b6c11ab843a2f8bcd23da3351a38107d7745","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           [\"availability_zones\"])"},{"line_number":44,"context_line":"        with self.rbac_utils.override_role_and_validate_list("},{"line_number":45,"context_line":"                self, admin_resources\u003dadmin_resources) as ctx:"},{"line_number":46,"context_line":"            ctx.resources \u003d self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_cede926a","line":46,"range":{"start_line":46,"start_character":67,"end_line":46,"end_character":69},"updated":"2018-11-19 16:29:19.000000000","message":"I believe this should key into [“availability_zones”] because otherwise the comparison logic won’t be accurate between admin resources and non-admin resources.","commit_id":"d3733e59bd64198f26fa139d3e6bf7eebe74e759"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"d66526ab93a33c4d90afbcabc18f469671151664","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           [\"availability_zones\"])"},{"line_number":44,"context_line":"        with self.rbac_utils.override_role_and_validate_list("},{"line_number":45,"context_line":"                self, admin_resources\u003dadmin_resources) as ctx:"},{"line_number":46,"context_line":"            ctx.resources \u003d self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_e96028a1","line":46,"range":{"start_line":46,"start_character":67,"end_line":46,"end_character":69},"in_reply_to":"3f79a3b5_cede926a","updated":"2018-11-19 17:28:04.000000000","message":"Yes you are right my bad i missed it","commit_id":"d3733e59bd64198f26fa139d3e6bf7eebe74e759"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"b7ee58eb5975b991997077279793e28dc9fe2d9e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from patrole_tempest_plugin.tests.api.network import rbac_base as base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AvailabilityZoneRbacTest(base.BaseNetworkExtRbacTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_5e21a5fc","line":23,"updated":"2018-11-21 14:54:31.000000000","message":"It\u0027s not a Plugin or external Extension. So you don\u0027t need to inherit this class from `BaseNetworkExtRbacTest`, `BaseNetworkRbacTest` is enough. Or the name of the class should end with `ExtRbacTest` (`AvailabilityZoneExtRbacTest`)","commit_id":"b21d58bfe2eae8328fa6d6314ea734acf1557469"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"124a5eb9a18a2e19626917b5883e1040e6c26d44","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":34,"context_line":"                                 rules\u003d[\"get_availability_zone\"])"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00273c521be8-c32e-11e8-a611-080027758b73\u0027)"},{"line_number":36,"context_line":"    def test_list_availability_zone_rbac(self):"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3f79a3b5_cb78967e","line":34,"range":{"start_line":34,"start_character":32,"end_line":34,"end_character":65},"updated":"2018-11-21 16:07:42.000000000","message":"as get_availability_zone has no rule defined in here \"https://review.openstack.org/#/c/618549/\" there are no expected_error_code for this test_case..\n\nPlease correct me if m wrong.","commit_id":"328f58c5e181fdd853b153dbfff486c967e529d9"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"00732369cfc1fcdfb57940605616796bad868aa1","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_9de4f9a8","line":43,"range":{"start_line":42,"start_character":8,"end_line":43,"end_character":53},"updated":"2018-11-24 16:02:10.000000000","message":"This pattern isn\u0027t correct. See an example of the right way here: https://review.openstack.org/#/c/600257/23/patrole_tempest_plugin/tests/api/network/test_network_ip_availability_rbac.py@58","commit_id":"e25b277ad05925e2be9bda98ff889578ce114f36"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"8ec89900eb2144d29289beea66fa49e209ebeb52","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_d51eb60d","line":43,"range":{"start_line":42,"start_character":8,"end_line":43,"end_character":53},"in_reply_to":"3f79a3b5_52f4fc55","updated":"2018-11-26 16:04:37.000000000","message":"ok,","commit_id":"e25b277ad05925e2be9bda98ff889578ce114f36"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"372f60460b567695ad84dccc41345cc7bcd69460","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_ebf99c1c","line":43,"range":{"start_line":42,"start_character":8,"end_line":43,"end_character":53},"in_reply_to":"3f79a3b5_9de4f9a8","updated":"2018-11-26 12:57:45.000000000","message":"Yea But based on this https://review.openstack.org/#/c/618549/ this is not an admin related operation so didnt use those lines.\nInfact there are no rules applied for this api-call.","commit_id":"e25b277ad05925e2be9bda98ff889578ce114f36"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b1e4bfa90480c931ebaaa67909c3f86c55cc4913","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_52f4fc55","line":43,"range":{"start_line":42,"start_character":8,"end_line":43,"end_character":53},"in_reply_to":"3f79a3b5_ebf99c1c","updated":"2018-11-26 15:37:35.000000000","message":"The default rule is \"\" which allows anyone to perform the action, but the operative word is \"default\". Patrole is geared at testing custom overrides as well, so to handle that we need to account for the case where the rule could be set to something else (like admin_only).","commit_id":"e25b277ad05925e2be9bda98ff889578ce114f36"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"693893648c4fe01c9ce6367c8968bf64081d01c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        \"\"\"List all available zones."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        admin_resources \u003d (self.ntp_client.list_availability_zones()"},{"line_number":43,"context_line":"                           [\"availability_zones\"])"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f79a3b5_36e4cd41","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":63},"updated":"2018-11-26 20:52:14.000000000","message":"May we word this like this: \n\n\"RBAC test for the neutron ``list_availability_zones``` function and the ``get_availability_zone`` policy\"","commit_id":"7d74bb935bc2ab201ada53196f5295fb070d2266"}],"patrole_tempest_plugin/tests/api/network/test_available_zones_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c832e320e7dd125b157079300e12608f3b7bf5ca","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class AvailabilityZoneRbacTest(base.BaseNetworkPluginRbacTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    def resource_setup(cls):"},{"line_number":26,"context_line":"        super(AvailabilityZoneRbacTest, cls).resource_setup()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":29,"context_line":"                                 rule\u003d\"get_available_zones\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1f2ec4f9","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":61},"updated":"2018-09-28 21:08:24.000000000","message":"This can be removed.\n\nI believe we need to add a skip_checks here that checks for the existence of the \"network_availability_zone\" extension or else skips the tests: https://developer.openstack.org/api-ref/network/v2/#network-availability-zone-extension\n\nExample:\n\n     @classmethod\n     def skip_checks(cls):\n         super(...)\n        if not utils.is_extension_enabled(\u0027network_availability_zone\u0027, \u0027network\u0027):\n            raise cls.skipException(\u0027network_availability_zone is not enabled.\u0027)","commit_id":"af3304e8da14b0e60fbfbab8fbe88b8031978453"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c832e320e7dd125b157079300e12608f3b7bf5ca","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(AvailabilityZoneRbacTest, cls).resource_setup()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":29,"context_line":"                                 rule\u003d\"get_available_zones\")"},{"line_number":30,"context_line":"    @decorators.idempotent_id(\u00273c521be8-c32e-11e8-a611-080027758b73\u0027)"},{"line_number":31,"context_line":"    def test_list_all_availability_zone_rbac(self):"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5f18bccb","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":58},"updated":"2018-09-28 21:08:24.000000000","message":"This is not a correct policy as it\u0027s not found in https://github.com/openstack/neutron/blob/master/etc/policy.json\n\nIf there\u0027s no policy enforcement for this endpoint then it shouldn\u0027t tested; I can\u0027t find anything related to listing availability zones but I haven\u0027t checked everywhere.","commit_id":"af3304e8da14b0e60fbfbab8fbe88b8031978453"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c832e320e7dd125b157079300e12608f3b7bf5ca","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        \"\"\"List all available zones."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        RBAC test for the neutron list all available zone policy"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":38,"context_line":"            self.ntp_client.list_all_availability_zones()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3f42a0ad","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":57},"updated":"2018-09-28 21:08:24.000000000","message":"\"get_available_zones\"","commit_id":"af3304e8da14b0e60fbfbab8fbe88b8031978453"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"8a5b75ddc96521cb5dbd581eea1adb760a229cb8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_all_availability_zones()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0c91569a","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":55},"updated":"2018-10-04 11:06:18.000000000","message":"Where I can check: \"list_all_availability_zones\"\nI have not found in tempest and patrole repo.\nTill the clearance, marking as -1","commit_id":"01fe54a952c9e92ef8fcb5bbf2ded7e4587bd260"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"de818eb352935f02a9fb2b602cf3a0604634518c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_all_availability_zones()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2ced3223","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":55},"in_reply_to":"3f79a3b5_0c91569a","updated":"2018-10-04 11:07:27.000000000","message":"https://review.openstack.org/#/c/605766/","commit_id":"01fe54a952c9e92ef8fcb5bbf2ded7e4587bd260"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"cea80d13976bd98f834248f9bbea0c4590cff6d1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_all_availability_zones()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ccdb5e77","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":55},"in_reply_to":"3f79a3b5_2ced3223","updated":"2018-10-04 11:08:47.000000000","message":"it should be list_availability_zones. \nMy bad.","commit_id":"01fe54a952c9e92ef8fcb5bbf2ded7e4587bd260"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"b4bed29577e2b3a6394e9d9f525e103c57a54619","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_all_availability_zones()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ecf65ad8","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":55},"in_reply_to":"3f79a3b5_ccdb5e77","updated":"2018-10-04 11:12:11.000000000","message":"Yes, Please correct that. Thanks!","commit_id":"01fe54a952c9e92ef8fcb5bbf2ded7e4587bd260"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"5eec9755d894a0811d6f38fb7ddc0cdeaade3e45","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":43,"context_line":"            self.ntp_client.list_all_availability_zones()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2cb0d2fc","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":55},"in_reply_to":"3f79a3b5_ecf65ad8","updated":"2018-10-04 11:16:00.000000000","message":"Done","commit_id":"01fe54a952c9e92ef8fcb5bbf2ded7e4587bd260"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8ad34ed36f56978c9b11e7ca59e5bb57bba91e8b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":34,"context_line":"                                 rule\u003d\"get_available_zones\")"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00273c521be8-c32e-11e8-a611-080027758b73\u0027)"},{"line_number":36,"context_line":"    def test_list_availability_zone_rbac(self):"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_7ab751d9","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":37},"updated":"2018-10-04 16:26:08.000000000","message":"This should be rules. `rule` is deprecated. Please see: https://review.openstack.org/#/c/595450/","commit_id":"971ab64e1c503230f7c76f2bc114643f5f9b38cb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b8888466d3c6153ce9fd589f86b0616c74bf57ec","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":34,"context_line":"                                 rules\u003d[\"get_available_zones\"])"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00273c521be8-c32e-11e8-a611-080027758b73\u0027)"},{"line_number":36,"context_line":"    def test_list_availability_zone_rbac(self):"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_37326bf4","line":34,"range":{"start_line":34,"start_character":41,"end_line":34,"end_character":60},"updated":"2018-11-10 06:08:09.000000000","message":"This policy is not valid. It\u0027s not present here: https://github.com/openstack/neutron/blob/094095b3d7c6afe8b6521473d12f9ee03f54fd59/etc/policy.json#L57\n\nThe only reason why this is passing is because it\u0027s skipping because the class name is incorrect. Retriggering this should fail pep8 hacking check recently implemented.","commit_id":"88ae7d7aeaef056b81514c62f82d7a9017b734c3"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"088db035dc902d1d1f3e9a4a9c3a1c74b57dd19b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":34,"context_line":"                                 rules\u003d[\"get_available_zones\"])"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00273c521be8-c32e-11e8-a611-080027758b73\u0027)"},{"line_number":36,"context_line":"    def test_list_availability_zone_rbac(self):"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_2aa66057","line":34,"range":{"start_line":34,"start_character":41,"end_line":34,"end_character":60},"in_reply_to":"3f79a3b5_3632620f","updated":"2018-11-13 15:35:49.000000000","message":"no, you don\u0027t need to add get_available_zones/list_available_zones policies. Felipe was right, you need to use override_role_and_validate_list function.\nTake a look at the commit: https://review.openstack.org/#/c/600257/17/patrole_tempest_plugin/tests/api/network/test_networks_rbac.py","commit_id":"88ae7d7aeaef056b81514c62f82d7a9017b734c3"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"8f907c1f126c3e367cf3651c8e3edacfc782e69f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":34,"context_line":"                                 rules\u003d[\"get_available_zones\"])"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u00273c521be8-c32e-11e8-a611-080027758b73\u0027)"},{"line_number":36,"context_line":"    def test_list_availability_zone_rbac(self):"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_3632620f","line":34,"range":{"start_line":34,"start_character":41,"end_line":34,"end_character":60},"in_reply_to":"3f79a3b5_37326bf4","updated":"2018-11-12 08:33:50.000000000","message":"Yes i do agree \n\"get_network_ip_availabilities\" is actually covered by https://review.openstack.org/#/c/600257/16 this commit and may be \n\nget_available_zones/list_available_zones must be added to policy.json file in a separate commit.","commit_id":"88ae7d7aeaef056b81514c62f82d7a9017b734c3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9d119b262ea8b79e54134d8cd005b860af75b0c9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        RBAC test for the neutron get all available zone policy"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role_and_validate_list("},{"line_number":43,"context_line":"            self, admin_resources\u003dadmin_resources) as ctx:"},{"line_number":44,"context_line":"            self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_3ff764d4","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":49},"updated":"2018-11-14 23:22:00.000000000","message":"Need to define `admin_resources` above.","commit_id":"fa7a38fddc4e3c90bfac3bfc32c9c702a33784a3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9d119b262ea8b79e54134d8cd005b860af75b0c9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        with self.rbac_utils.override_role_and_validate_list("},{"line_number":43,"context_line":"            self, admin_resources\u003dadmin_resources) as ctx:"},{"line_number":44,"context_line":"            self.ntp_client.list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_7feddcff","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":53},"updated":"2018-11-14 23:22:00.000000000","message":"Either:\n\nctx.resources \u003d self.ntp_client.list_availability_zones(id\u003dadmin_resource_id)\n\nOr:\n\nctx.resources \u003d self.ntp_client.list_availability_zones()\n\nDepending on what validate func you want to use.","commit_id":"fa7a38fddc4e3c90bfac3bfc32c9c702a33784a3"}]}