)]}'
{"patrole_tempest_plugin/rbac_utils.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7d400322f536051efa467bbbb7c83faf337757d7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    rbac_role_id \u003d None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @contextmanager"},{"line_number":65,"context_line":"    def override_role(self, test_obj):"},{"line_number":66,"context_line":"        \"\"\"Override the role used by ``os_primary`` Tempest credentials."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        Temporarily change the role used by ``os_primary`` credentials to:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d742453c","side":"PARENT","line":65,"range":{"start_line":65,"start_character":28,"end_line":65,"end_character":36},"updated":"2018-10-13 03:08:55.000000000","message":"May we just keep this here (making its default value be test_obj\u003dNone) and issue a deprecation warning for 1 cycle before removing? Can just update L75 to say: \"This is deprecated and passing this in is ignored.\"\n\nThen on L98:\n\n    if test_obj:\n        version_utils.report_deprecated_feature(...)\n\nhttps://github.com/openstack/oslo.log/blob/5cd02483c6839e987b723ecba389040a6d6fe79f/oslo_log/versionutils.py#L273","commit_id":"7fa1f735fa66ae49589950201755c1fa5db3ae6d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"008db58cc6e80632d9a8651b2173485a9708d039","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        self.local \u003d threading.local()"},{"line_number":53,"context_line":"        self.test_obj_klass \u003d test_obj"},{"line_number":54,"context_line":"        self.local.test_obj \u003d None if inspect.isclass(test_obj) else test_obj"},{"line_number":55,"context_line":"        # Intialize the admin roles_client to perform role switching."},{"line_number":56,"context_line":"        admin_mgr \u003d clients.Manager("},{"line_number":57,"context_line":"            credentials.get_configured_admin_credentials())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0f5e61e8","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":63},"updated":"2018-10-14 04:42:02.000000000","message":"Probably would be more robust to do: isinstance(test_obj, (tempest.test.BaseTestCase, tempest.lib.base.BaseTestCase)) else raise a RbacSetupFailure exception","commit_id":"c15158b126c66a5ce865f0cb8886fe514443291f"}]}