)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"137fbc0a0153d73cf98d11c17fda13a128851def","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d0f1c33_69f963f4","updated":"2023-03-11 02:11:47.000000000","message":"no activity for long time, and as this repo is almost inactive I will propose it to retire soon but if you would like to maintain it, ping us on #openstack-qa IRC OFTC channel","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"}],"patrole_tempest_plugin/config.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9fc2a48b2316f096965692f3f7e47ef5997de00a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"PatroleLogGroup \u003d ["},{"line_number":108,"context_line":"    cfg.BoolOpt(\u0027enable_reporting\u0027,"},{"line_number":109,"context_line":"                default\u003dFalse,"},{"line_number":110,"context_line":"                help\u003d\"Enables reporting on RBAC expected and actual test \""},{"line_number":111,"context_line":"                     \"results for each Patrole test\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8d716049","line":108,"range":{"start_line":108,"start_character":17,"end_line":108,"end_character":33},"updated":"2018-11-21 03:51:09.000000000","message":"As an aside we should enable this in .zuul.yaml in order to actively validate that this logging works. That will likely require updating the devstack plugin.sh as well.","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"}],"patrole_tempest_plugin/rbac_rule_validation.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"06898486f0f9905d1a2a10a6fd5a43d5200dbe78","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import collections"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import versionutils"},{"line_number":23,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_684e32c4","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":18},"updated":"2018-11-21 06:25:32.000000000","message":"Please arrange them in alphabetical order:\nhttps://docs.openstack.org/hacking/0.10.3/#import-order-template","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9fc2a48b2316f096965692f3f7e47ef5997de00a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import collections"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import versionutils"},{"line_number":23,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ed825402","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":18},"updated":"2018-11-21 03:51:09.000000000","message":"These imports are out of order.","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d45797bdb5499c4434da2dc6281f0eaf0c2a7dc6","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                    LOG.error(msg)"},{"line_number":255,"context_line":"                    raise rbac_exceptions.RbacOverPermissionException(msg)"},{"line_number":256,"context_line":"            finally:"},{"line_number":257,"context_line":"                if CONF.patrole_log.enable_reporting:"},{"line_number":258,"context_line":"                    rbac_test_info \u003d collections.OrderedDict()"},{"line_number":259,"context_line":"                    rbac_test_info[\"Role\"] \u003d role"},{"line_number":260,"context_line":"                    rbac_test_info[\"Service\"] \u003d service"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8dc3a059","line":257,"updated":"2018-11-21 03:48:14.000000000","message":"This block below should be included in a function (L258-276).","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d45797bdb5499c4434da2dc6281f0eaf0c2a7dc6","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            finally:"},{"line_number":257,"context_line":"                if CONF.patrole_log.enable_reporting:"},{"line_number":258,"context_line":"                    rbac_test_info \u003d collections.OrderedDict()"},{"line_number":259,"context_line":"                    rbac_test_info[\"Role\"] \u003d role"},{"line_number":260,"context_line":"                    rbac_test_info[\"Service\"] \u003d service"},{"line_number":261,"context_line":"                    rbac_test_info[\"Test\"] \u003d test_func.__name__"},{"line_number":262,"context_line":"                    rbac_test_info[\"Rules\"] \u003d \u0027, \u0027.join(rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6dc88475","line":259,"range":{"start_line":259,"start_character":34,"end_line":259,"end_character":49},"updated":"2018-11-21 03:48:14.000000000","message":"This should be [\"Role\"] \u003d \", \". join(roles) now due to addition of multi-role support and deprecation of CONF.patrole.rbac_test_role.","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4e9e03cd94b6de9de853a1d62cde70c8cb0b2c42","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            finally:"},{"line_number":257,"context_line":"                if CONF.patrole_log.enable_reporting:"},{"line_number":258,"context_line":"                    rbac_test_info \u003d collections.OrderedDict()"},{"line_number":259,"context_line":"                    rbac_test_info[\"Role\"] \u003d role"},{"line_number":260,"context_line":"                    rbac_test_info[\"Service\"] \u003d service"},{"line_number":261,"context_line":"                    rbac_test_info[\"Test\"] \u003d test_func.__name__"},{"line_number":262,"context_line":"                    rbac_test_info[\"Rules\"] \u003d \u0027, \u0027.join(rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ada3fcaf","line":259,"range":{"start_line":259,"start_character":34,"end_line":259,"end_character":49},"in_reply_to":"3f79a3b5_6dc88475","updated":"2018-11-21 03:49:03.000000000","message":"[\"Roles\"] preferably, for consistency.","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"ff92bb46df6ff0d7e5ecffdc6f5c9305d21bd65f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                    rbac_test_info[\"Expected\"] \u003d \\"},{"line_number":264,"context_line":"                        \"Allowed\" if allowed else \"Denied\""},{"line_number":265,"context_line":"                    rbac_test_info[\"Actual\"] \u003d test_status"},{"line_number":266,"context_line":"                    "},{"line_number":267,"context_line":"                    if CONF.patrole_log.report_log_format.lower() \u003d\u003d \"json\":"},{"line_number":268,"context_line":"                        RBACLOG.info(\"%s\", json.dumps(rbac_test_info))"},{"line_number":269,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bc65701e","line":266,"updated":"2018-11-20 23:42:42.000000000","message":"unnecessary ws","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"ff92bb46df6ff0d7e5ecffdc6f5c9305d21bd65f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                        RBACLOG.info("},{"line_number":271,"context_line":"                            \"[Role]: %s, [Service]: %s, [Test]: %s,\""},{"line_number":272,"context_line":"                            \"[Rules]: %s, Expected]: %s, [Actual]: %s\","},{"line_number":273,"context_line":"                            rbac_test_info[\"Role\"], rbac_test_info[\"Service\"],"},{"line_number":274,"context_line":"                            rbac_test_info[\"Test\"], rbac_test_info[\"Rules\"],"},{"line_number":275,"context_line":"                            rbac_test_info[\"Expected\"],"},{"line_number":276,"context_line":"                            rbac_test_info[\"Actual\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fc5be85d","line":273,"updated":"2018-11-20 23:42:42.000000000","message":"just rbac_test_info and \"[Role]: %(Role)s ....\"","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d45797bdb5499c4434da2dc6281f0eaf0c2a7dc6","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                        RBACLOG.info("},{"line_number":271,"context_line":"                            \"[Role]: %s, [Service]: %s, [Test]: %s,\""},{"line_number":272,"context_line":"                            \"[Rules]: %s, Expected]: %s, [Actual]: %s\","},{"line_number":273,"context_line":"                            rbac_test_info[\"Role\"], rbac_test_info[\"Service\"],"},{"line_number":274,"context_line":"                            rbac_test_info[\"Test\"], rbac_test_info[\"Rules\"],"},{"line_number":275,"context_line":"                            rbac_test_info[\"Expected\"],"},{"line_number":276,"context_line":"                            rbac_test_info[\"Actual\"])"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"                # Sanity-check that ``override_role`` was called to eliminate"},{"line_number":279,"context_line":"                # false-positives and bad test flows resulting from exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_adae9c9e","line":276,"range":{"start_line":273,"start_character":28,"end_line":276,"end_character":51},"updated":"2018-11-21 03:48:14.000000000","message":"*list(rbac_test_info.keys()) may work here assuming the OrderedDict preserves the original ordering of the keys; I don\u0027t exactly recall.","commit_id":"ecf2d464bed3c43bc5f56d96a36e0f1f261b8cb7"}]}
