)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"321ed210bc375355710f7c79a9fe53f2c0fc48eb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @decorators.idempotent_id(\u00274f34c73a-6ddc-4677-976f-71320fa855bd\u0027)"},{"line_number":50,"context_line":"    def test_create_server(self):"},{"line_number":51,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":52,"context_line":"            server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":54,"context_line":"                        self.servers_client, server[\u0027id\u0027])"},{"line_number":55,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5c7513ca","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":65},"updated":"2019-01-30 07:40:47.000000000","message":"This shouldn\u0027t be called in this context since it isn\u0027t granular enough: it calls create server followed by show server (via wait logic) which is why we\u0027re not using this method here. If needed, pass in networking information into the existing API method.","commit_id":"82fff78ca79d83ab6afaaa2c1672fa80de743c51"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"d0dc096db762e6f86468867d6f382d4f741a4746","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @decorators.idempotent_id(\u00274f34c73a-6ddc-4677-976f-71320fa855bd\u0027)"},{"line_number":50,"context_line":"    def test_create_server(self):"},{"line_number":51,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":52,"context_line":"            server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":54,"context_line":"                        self.servers_client, server[\u0027id\u0027])"},{"line_number":55,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_eb740800","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":65},"in_reply_to":"9fdfeff1_5c7513ca","updated":"2019-02-01 19:00:35.000000000","message":"I agree with Felipe, you don\u0027t need to use create_test_server function in this case.\n\n\u003e The Patrole tests belonging to compute component are failing due to \"not passing the network explicitly while creating Instances\".\n\nLet\u0027s try to pass an network in create_server function. I think you can re-use same network as was used in creation of the cls.server resource. Something like this:\n\n    network \u003d self.server[\u0027network\u0027]\n    with self.rbac_utils.override_role(self):\n        server \u003d self.servers_client.create_server(\n            ...,\n            tenant_network \u003d network","commit_id":"82fff78ca79d83ab6afaaa2c1672fa80de743c51"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"44d22991abeda9f7a998b0a22bddbe94192a16cd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                name\u003ddata_utils.rand_name(self.__class__.__name__ + \u0027-Server\u0027),"},{"line_number":55,"context_line":"                flavorRef\u003dCONF.compute.flavor_ref,"},{"line_number":56,"context_line":"                imageRef\u003dCONF.compute.image_ref,"},{"line_number":57,"context_line":"                tenant_network\u003dnetwork)[\u0027server\u0027]"},{"line_number":58,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":59,"context_line":"                        self.servers_client, server[\u0027id\u0027])"},{"line_number":60,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_0746fc50","line":57,"range":{"start_line":57,"start_character":16,"end_line":57,"end_character":30},"updated":"2019-02-05 05:49:34.000000000","message":"This is not defined by the API. Will have to use https://github.com/openstack/tempest/blob/eac094a8cf834d035316a900107f601adcc42ff5/tempest/lib/common/fixed_network.py#L115 instead. \n\nMaybe something like:\n\n    kwargs \u003d fixed_network.get_network_kwarg(self.get_tenant_network()) or {}\n    server \u003d self.servers_client.create_server(\n                name\u003ddata_utils.rand_name(self.__class__.__name__ + \u0027-Server\u0027),\n                flavorRef\u003dCONF.compute.flavor_ref,\n                imageRef\u003dCONF.compute.image_ref,\n                **kwargs)[\u0027server\u0027]\n\nwill work.","commit_id":"33f32e6ed01e1240160573d9daf0c46a6fe3a2c6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b16adbd62a8178f6bfe2dc6de86052a6894ef91a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                name\u003ddata_utils.rand_name(self.__class__.__name__ + \u0027-Server\u0027),"},{"line_number":55,"context_line":"                flavorRef\u003dCONF.compute.flavor_ref,"},{"line_number":56,"context_line":"                imageRef\u003dCONF.compute.image_ref,"},{"line_number":57,"context_line":"                tenant_network\u003dnetwork)[\u0027server\u0027]"},{"line_number":58,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":59,"context_line":"                        self.servers_client, server[\u0027id\u0027])"},{"line_number":60,"context_line":"        self.addCleanup(self.servers_client.delete_server, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_94c1a683","line":57,"range":{"start_line":57,"start_character":16,"end_line":57,"end_character":30},"in_reply_to":"9fdfeff1_0746fc50","updated":"2019-02-05 21:58:14.000000000","message":"In fact we should probably add a helper in Patrole\u0027s base compute class to make this easier because this is getting kind of involved. We can abstract almost all of this there.","commit_id":"33f32e6ed01e1240160573d9daf0c46a6fe3a2c6"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"4fd8f32300fd96513f6c79afe250c769d9aab86e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        network_id \u003d {\u0027uuid\u0027: network[\u0027id\u0027]}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        with self.override_role():"},{"line_number":168,"context_line":"            server \u003d self.servers_client.create_server("},{"line_number":169,"context_line":"                name\u003ddata_utils.rand_name(self.__class__.__name__ + \u0027-Server\u0027),"},{"line_number":170,"context_line":"                flavorRef\u003dCONF.compute.flavor_ref,"},{"line_number":171,"context_line":"                imageRef\u003dCONF.compute.image_ref,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_5c9320fb","line":168,"updated":"2019-03-11 14:09:13.000000000","message":"Use `_get_instance_config` here too","commit_id":"90b9672ad4e0ad3932e7fcf5fb52d1eb5258496b"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"a83eb4aaa40ef388fee36d74df687968303edcbd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        device_mapping \u003d {\u0027block_device_mapping_v2\u0027: bd_map_v2}"},{"line_number":119,"context_line":"        with self.override_role():"},{"line_number":120,"context_line":"            instance_params \u003d self._get_instance_config()"},{"line_number":121,"context_line":"             # Use image_id\u003d\u0027\u0027 to avoid using the default image in tempest.conf."},{"line_number":122,"context_line":"            instance_params[\u0027imageRef\u0027] \u003d \u0027\u0027"},{"line_number":123,"context_line":"            instance_params[\u0027block_device_mapping_v2\u0027] \u003d bd_map_v2"},{"line_number":124,"context_line":"            server \u003d self.servers_client.create_server("}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_1788126f","line":121,"updated":"2019-03-11 14:53:25.000000000","message":"replace `image_id` with `imageRef`","commit_id":"3f90ef669f38d244cbaab625f1af0106b5f50a23"}]}