)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dd8ebbf8736ad6717354a2b8f3e28e103f0ccc9a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":202,"context_line":"            self.admin_servers_client.delete_server, self.server_id)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        with self.rbac_utils.override_role(self):"},{"line_number":205,"context_line":"            self._confirm_resize_server()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @rbac_rule_validation.action("},{"line_number":208,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_1c29cb99","line":205,"range":{"start_line":204,"start_character":8,"end_line":205,"end_character":41},"updated":"2019-01-30 07:45:08.000000000","message":"This is already called above. We should only call `override_role` once per test.","commit_id":"27a3f453f76d084515ab13530f50c74f98e7b433"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"9151abd8195a8b16938e83db3e7a6dc2f2d7f268","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.addCleanup("},{"line_number":201,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":202,"context_line":"            self.admin_servers_client.delete_server, self.server_id)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @rbac_rule_validation.action("},{"line_number":205,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_0b44ec45","line":202,"updated":"2019-02-01 18:38:27.000000000","message":"Hmmm, Abhishek, here some comments:\n1. I would prefer to see a Cleanup before override_role, in case of any unexpected errors in the _confirm_resize_server the cleanup function will not be executed. So, please move it for 3 lines above.\n\n2. Why have you decided to delete the server? The server has been created in the setup_resouces function, it\u0027s created only once for the all tests in this class. So if we can guaranty that this test will be executed last, then we can delete it here. But Now, since you delete it, other tests may fail because the server is not available.\n\n3. In my point of view the current implementation of this test is correct, the traceback from the story shows us a timeout exception. Maybe we need to add a retry in the wait_for_server_status?","commit_id":"3742d54673831eeca89d5216be68ec01fc283055"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20dc17dba101e46ce358a7c3622865547ee98112","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.addCleanup("},{"line_number":201,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":202,"context_line":"            self.admin_servers_client.delete_server, self.server_id)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @rbac_rule_validation.action("},{"line_number":205,"context_line":"        service\u003d\"nova\","}],"source_content_type":"text/x-python","patch_set":2,"id":"0546ad36_c9b4a75f","line":202,"in_reply_to":"9fdfeff1_0b44ec45","updated":"2021-02-16 15:52:10.000000000","message":"I agree on these point. Is this test failing consistently? I think current cleanup of reverting the resize is correct cleanup.","commit_id":"3742d54673831eeca89d5216be68ec01fc283055"}]}