)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"129831c6c4ff048f83d5269f33001fdbb2af6b38","unresolved":false,"context_lines":[{"line_number":11,"context_line":"storage backends. When using Ceph, the volume backup is not"},{"line_number":12,"context_line":"able to be deleted because of permission issues with Swift"},{"line_number":13,"context_line":"and therefore causes a resource leak. Instead use the volume/rbac_base.py"},{"line_number":14,"context_line":"\u0027_create_backup\u0027 which does not have this issue."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8796c6d9391b1965b3b8fd1fa1f8e347f26b64e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_605c0b19","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":16},"updated":"2019-08-15 00:16:49.000000000","message":"I am just curious how _create_backup will solve the permission issue?","commit_id":"8643132f3edbacad2d0c89e402bd4f9fb0f50aaf"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"76e4ee8ba4f474ffd6899de73fe3927c6a6c8c02","unresolved":false,"context_lines":[{"line_number":11,"context_line":"storage backends. When using Ceph, the volume backup is not"},{"line_number":12,"context_line":"able to be deleted because of permission issues with Swift"},{"line_number":13,"context_line":"and therefore causes a resource leak. Instead use the volume/rbac_base.py"},{"line_number":14,"context_line":"\u0027_create_backup\u0027 which does not have this issue."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8796c6d9391b1965b3b8fd1fa1f8e347f26b64e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_702a79e7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":16},"in_reply_to":"7faddb67_605c0b19","updated":"2019-08-16 19:45:53.000000000","message":"So the difference is the way the cleanup is being done. At the instance-level the cleanup is done as such:\n\n        self.addCleanup(backup_client.delete_backup, backup[\u0027id\u0027])\n\nAnd in the rbac_base.py, the cleanup for _create_backup is done as such:\n\n        self.addClassResourceCleanup(\n            test_utils.call_and_ignore_notfound_exc,\n            backup_client.delete_backup, backup[\u0027id\u0027])\n\nWhen using the \u0027addClassResourceCleanup\u0027 the volume backup is deleted with no leak. When using \u0027addCleanup\u0027 the volume backup does not delete and the following error message is seen when executing \u0027openstack volume backup show \u003cvolume_backup\u003e\u0027:\n\nfail_reason:\nObject DELETE failed: http://ceph-rgw.xxxxx.xxxxx.xxxxxxx.local:xxxx/swift/v1/KEY_xxxxxxxxxxxxxxx/volumebackups/volume_ad1efb0c-56ad-4401-bd13-6492c0b218b9/20190816193031/az_nova_backup_c89a5dc3-6a6e-47f5-8c86-5771cc1cc56f-00010 401 Una\n\nI do not know enough about \u0027addClassResourceCleanup\u0027 to explain why/how it is able to delete the volume backup, but just know that when using that there is no volume backup leak.","commit_id":"8643132f3edbacad2d0c89e402bd4f9fb0f50aaf"}]}