)]}'
{"patrole_tempest_plugin/tests/api/compute/test_server_actions_rbac.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5d5d32048c014f13ee8dd2fad876895c6a1c3829","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":365,"context_line":"            images \u003d self.glance_client.list_images("},{"line_number":366,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":367,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":368,"context_line":"                        self.glance_client.delete_image, images[0][\u0027id\u0027])"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a0801ff9","line":367,"range":{"start_line":367,"start_character":24,"end_line":367,"end_character":63},"updated":"2019-08-25 15:07:25.000000000","message":"Why not wait_for_resource_deletion? That should handle the not found error explicitly and also ensures that the image is deleted successfully.","commit_id":"7cd7b7d388e1332817d24dac0e9df1df6efc87b4"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7b60e826927842ca5d71542141c374f2eb3a9295","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":365,"context_line":"            images \u003d self.glance_client.list_images("},{"line_number":366,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":367,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":368,"context_line":"                        self.glance_client.delete_image, images[0][\u0027id\u0027])"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_eb8fb373","line":367,"range":{"start_line":367,"start_character":24,"end_line":367,"end_character":63},"in_reply_to":"7faddb67_a0801ff9","updated":"2019-08-27 19:26:04.000000000","message":"Are you saying to do something like:\n\nself.glance_client.wait_for_resource_deletion(images[0][\u0027id\u0027]) ?\n\nIf so, what I am seeing is that the test times out and the image is not deleted:\n\nDetails: (ServerActionsRbacTest:test_unshelve_server) Failed to delete image d77fb01b-ad51-4a02-8a66-2bd924ff51a5 within the required time (300 s).\n\nPerhaps I am missing something here?","commit_id":"7cd7b7d388e1332817d24dac0e9df1df6efc87b4"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"7af83452b4b83d90cea6ddecafc3a948a0e9b27a","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":365,"context_line":"            images \u003d self.glance_client.list_images("},{"line_number":366,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":367,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":368,"context_line":"                        self.glance_client.delete_image, images[0][\u0027id\u0027])"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5098f6ca","line":367,"range":{"start_line":367,"start_character":24,"end_line":367,"end_character":63},"in_reply_to":"7faddb67_a0801ff9","updated":"2019-08-27 18:25:44.000000000","message":"Thanks for the review.\n\nI was just following the same pattern used by the other tests... but I can make the update","commit_id":"7cd7b7d388e1332817d24dac0e9df1df6efc87b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"10e8a1a754522f375eed3f4cc22456c6b306c963","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":365,"context_line":"            images \u003d self.glance_client.list_images("},{"line_number":366,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":367,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":368,"context_line":"                        self.glance_client.delete_image, images[0][\u0027id\u0027])"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a1a2f795","line":367,"range":{"start_line":367,"start_character":24,"end_line":367,"end_character":63},"in_reply_to":"7faddb67_eb8fb373","updated":"2020-01-03 02:27:36.000000000","message":"Timeout should happen with test_utils.call_and_ignore_notfound_exc also if you call it as part of test. \n\nlet\u0027s go with wait for image deletion here which will same as in Tempest tests[1]. If timeout occurs consistently then we can ask glance team to look into the bug.  \n\n[1] https://github.com/openstack/tempest/blob/9d1c62574648dcae2d443d0bf1092739926801d5/tempest/api/compute/servers/test_server_actions.py#L660","commit_id":"7cd7b7d388e1332817d24dac0e9df1df6efc87b4"}]}