)]}'
{"patrole_tempest_plugin/tests/api/network/test_auto_allocated_topology_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"51e89adadd1ae83d8048f765234a26c3c1d7ff8e","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f08ae267","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"updated":"2019-09-25 22:41:33.000000000","message":"this will fail on stestr \u003e2.5.0\n\nlet\u0027s test and add the same workaround also ?","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f48ad1ea7811334842f3023fa91e1bad979c8903","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f07f42dd","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_30baba09","updated":"2019-09-26 23:05:38.000000000","message":"actually this is raised from test case. workaround in Tempest handled only cases where cls.skipException is raised from setUpClass().\n\nTempest does not have any test raising cls.skipException from test case. do we have in patrole other than this? if so testing patch should catch that.","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d8ac89797ea90fc8fbf4018fdda5d6e255d07a5f","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e46acf19","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_4438833c","updated":"2019-10-01 19:58:55.000000000","message":"probably we are not hitting that condition in tempest test. Let me dig into that and the results. I will be up for this tomorrow after finishing the release thigs today.","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"823594ddc1e2443ab476fb39c636f4d7bb435afa","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4438833c","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_a4f13798","updated":"2019-10-01 19:55:48.000000000","message":"Also here is an example where Tempest raises the same exception from inside a test: https://opendev.org/openstack/tempest/src/branch/master/tempest/api/compute/admin/test_aggregates.py#L221","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"487db938ed454fd8727fa977a1049c3d3db52b66","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_622e3344","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_a4f13798","updated":"2019-10-11 08:47:52.000000000","message":"these decorators are ok as they explicitly set the skip attributes and then test runner check those attributes and add the tests in skip list.","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ce25f3985b694e42ce30c3565facd76dae9063a8","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_cc4ba3ae","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_e46acf19","updated":"2019-10-11 00:11:57.000000000","message":"After more debuging I got the answer why tests code\u0027s skip  exception not failing.\n We are good on skipException from test code. That is handled by\nteststools.TestCase\u0027s self.exception_handlers\n- https://github.com/testing-cabal/testtools/blob/f51ce5f934153e80d3e8a95b52e1464daeb30c14/testtools/testcase.py#L275\nMapped handler _report_skip() will add the respective tests to skip list","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1e64a115278ad4963966f304fbeb751ed1c436bf","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a4f13798","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_f07f42dd","updated":"2019-10-01 19:54:37.000000000","message":"What about @testtools.skipIf and @testtools.skipUnless -- Tempest uses that a lot: http://codesearch.openstack.org/?q\u003d%40testtools.skipIf\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dopenstack/tempest","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e0aaac3e85b6d0dca1caf66a455192c079c5881a","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if len(ports) !\u003d expected_ports_count:"},{"line_number":56,"context_line":"            msg \u003d \"Auto Allocated Topology in use.\""},{"line_number":57,"context_line":"            raise cls.skipException(msg)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027A0606AFE-065E-4C09-8E51-58EE7FBA30A2\u0027)"},{"line_number":60,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_30baba09","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"3fa7e38b_f08ae267","updated":"2019-09-25 22:46:13.000000000","message":"I think this is addressing a separate issue though. We have other instances of raising cls.skipException in Patrole and the workaround should fix all such existing cases too.","commit_id":"8ca82d85061d94e0bf8cc245f2747a705d0bace4"}]}