)]}'
{"patrole_tempest_plugin/tests/api/compute/test_services_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"248eb6778048c3f5cd242392263dd4a6b0ec67aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            raise cls.skipException("},{"line_number":32,"context_line":"                \u0027%s skipped as os-services not enabled\u0027 % cls.__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @testtools.skipIf(CONF.policy_feature_enabled.removed_nova_policies_ussuri,"},{"line_number":35,"context_line":"                      \"This policy was removed in Ussuri\")"},{"line_number":36,"context_line":"    @rbac_rule_validation.action("},{"line_number":37,"context_line":"        service\u003d\"nova\","},{"line_number":38,"context_line":"        rules\u003d[\"os_compute_api:os-services\"])"},{"line_number":39,"context_line":"    @decorators.idempotent_id(\u00277472261b-9c6d-453a-bcb3-aecaa29ad281\u0027)"},{"line_number":40,"context_line":"    def test_list_services(self):"},{"line_number":41,"context_line":"        with self.override_role():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_815ed476","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":45},"updated":"2020-01-03 19:24:57.000000000","message":"these policies a","commit_id":"1e6b73219392f4d9007b7642e7f9b0a8b683fc32"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"248eb6778048c3f5cd242392263dd4a6b0ec67aa","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        if not utils.is_extension_enabled(\u0027os-services\u0027, \u0027compute\u0027):"},{"line_number":33,"context_line":"            raise cls.skipException("},{"line_number":34,"context_line":"                \u0027%s skipped as os-services not enabled\u0027 % cls.__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @testtools.skipIf(CONF.policy_feature_enabled.removed_nova_policies_ussuri,"},{"line_number":37,"context_line":"                      \"This policy was removed in Ussuri\")"},{"line_number":38,"context_line":"    @rbac_rule_validation.action("},{"line_number":39,"context_line":"        service\u003d\"nova\","},{"line_number":40,"context_line":"        rules\u003d[\"os_compute_api:os-services\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_41c9bc21","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":58},"updated":"2020-01-03 19:24:57.000000000","message":"Actually, these policies are being renamed not removed completely (due to adding the granularity to adopt the new defaults and scope_type[1] and few more policies will be changed that way). So they should not be in the category of the removed flag. \n\nI really want to tests the new policy also. For that, we need to switch the policy name based on the branches. \n\nOne way to detect the branch is by the max microversion but that can fail the tests if anyone running patrole against master cloud. \n\nThe second and safe way is using the flag itself like we do for removed policy. There we need to switch the policy name based on flag. something like \u0027changed_nova_policies_ussuri\u0027\n\nand here we can handle like:\n\nif changed_nova_policies_ussuri:\n    rule: \"os_compute_api:os-services:list\"\nelse:\n    rule: \"os_compute_api:os-services\"\n\n\n[1] https://review.opendev.org/#/q/topic:bp/policy-defaults-refresh+(status:open+OR+status:merged)","commit_id":"d58e186163ab5a7d7b9b279115252412e9730eee"}]}