)]}'
{".zuul.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2916c7f8a3237e65d2529f65310416da8879bc1e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      # run the tempest all tox environment target with patrole regex"},{"line_number":34,"context_line":"      tox_envlist: all"},{"line_number":35,"context_line":"      tempest_test_regex: (?!.*\\[.*\\bslow\\b.*\\])(^patrole_tempest_plugin\\.tests\\.api)"},{"line_number":36,"context_line":"      # allows job to use the tempest version installed with devstack instead of pypi"},{"line_number":37,"context_line":"      # according to the requirements.txt"},{"line_number":38,"context_line":"      tox_extra_args: --sitepackages"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- job:"},{"line_number":41,"context_line":"    name: patrole-base-multinode"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_0e9716ee","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":36},"updated":"2020-08-25 13:08:20.000000000","message":"it should work fine with venv also. let me check the error.","commit_id":"58affe83aabcd9c80a09154150163cd45d9a89f2"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"59aeca264348609b419faf2c6645085a82aa9835","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      tempest_test_regex: (?!.*\\[.*\\bslow\\b.*\\])(^patrole_tempest_plugin\\.tests\\.api)"},{"line_number":33,"context_line":"       # run the tempest all tox environment target with patrole regex"},{"line_number":34,"context_line":"      tox_envlist: all"},{"line_number":35,"context_line":"      # allows job to use the tempest version installed with devstack instead of pypi"},{"line_number":36,"context_line":"      # according to the requirements.txt"},{"line_number":37,"context_line":"      tox_extra_args: --sitepackages"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_35f7678f","line":36,"range":{"start_line":35,"start_character":6,"end_line":36,"end_character":41},"updated":"2020-08-31 16:02:40.000000000","message":"I thought this flag was only here to allow for oslo.policy registered rules in other projects to be detected.","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"b30a2db3a5a29542310bc645e7d2e0157e74fe80","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      tempest_test_regex: (?!.*\\[.*\\bslow\\b.*\\])(^patrole_tempest_plugin\\.tests\\.api)"},{"line_number":33,"context_line":"       # run the tempest all tox environment target with patrole regex"},{"line_number":34,"context_line":"      tox_envlist: all"},{"line_number":35,"context_line":"      # allows job to use the tempest version installed with devstack instead of pypi"},{"line_number":36,"context_line":"      # according to the requirements.txt"},{"line_number":37,"context_line":"      tox_extra_args: --sitepackages"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_4b951c88","line":36,"range":{"start_line":35,"start_character":6,"end_line":36,"end_character":41},"in_reply_to":"9f560f44_35f7678f","updated":"2020-08-31 23:40:44.000000000","message":"When I removed this I found that it installed the tempest 24.0.0 from pypi and not the master branch.  So I was trying explain that in this comment.\n\nPlease let me know if you have changes or additions to my comment.","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"}],"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e6a52674f7c16050f0eea322adc1102022660ebd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up tox.ini and document zuul.yaml settings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tried to remove --sitepacakges and the gate failed"},{"line_number":10,"context_line":"so I added comment ans i am just"},{"line_number":11,"context_line":"doing some tox cleanup only."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"While dcoumenting the zuul.yaml I noticed that I made"},{"line_number":14,"context_line":"patrole-reader a job and I feel that we should also"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_d9daaf1b","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":28},"updated":"2020-08-31 08:43:32.000000000","message":"I think that the problem was that you also removed \"tox_envlist: all\" -\u003e tox_envlist is set to smoke by default [1] which means when the role executes tempest here [2] it uses this command [3], when tox_envlist is \u0027all\u0027 it uses this command [4]. The difference between [3] and [4] caused that tempest was executed as:\n\"tempest run --regex \u0027\\[.*\\bsmoke\\b.*\\]\u0027 \u0027(?!.*\\[.*\\bslow\\b.*\\])(^patrole_tempest_plugin\\.tests\\.api)\u0027 --concurrency\u003d2 --black-regex\u003d\"\n\ninstead of:\n\"tempest run --regex \u0027(?!.*\\[.*\\bslow\\b.*\\])(^patrole_tempest_plugin\\.tests\\.api)\u0027 --concurrency\u003d4 --black-regex\u003d\"\n\nand that caused the gate to fail. \n\n[1] https://opendev.org/openstack/tempest/src/commit/c9643dc3f580174980887416ebedf3369d9a21b9/roles/run-tempest/defaults/main.yaml#L3\n[2] https://opendev.org/openstack/tempest/src/commit/c9643dc3f580174980887416ebedf3369d9a21b9/roles/run-tempest/tasks/main.yaml#L54\n[3] https://opendev.org/openstack/tempest/src/branch/master/tox.ini#L225\n[4] https://opendev.org/openstack/tempest/src/branch/master/tox.ini#L68","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"b30a2db3a5a29542310bc645e7d2e0157e74fe80","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up tox.ini and document zuul.yaml settings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tried to remove --sitepacakges and the gate failed"},{"line_number":10,"context_line":"so I added comment ans i am just"},{"line_number":11,"context_line":"doing some tox cleanup only."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"While dcoumenting the zuul.yaml I noticed that I made"},{"line_number":14,"context_line":"patrole-reader a job and I feel that we should also"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_8b8f3474","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":28},"in_reply_to":"9f560f44_d9daaf1b","updated":"2020-08-31 23:40:44.000000000","message":"I will try to reword this","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"f21cd3f19148f8ad92b2e48a774af8998cd98e21","unresolved":false,"context_lines":[{"line_number":19,"context_line":"have it as a gate."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"I also saw that extension and multi-node non-voting jobs"},{"line_number":22,"context_line":"where mssing reader versions so I added them."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I7b8e4c06ece6b32cab4d7238d0bc250334a3adb3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9f560f44_03b43a35","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":12},"updated":"2020-09-08 13:34:33.000000000","message":"nit: missing","commit_id":"5a846ba01dc88ee3147a862fdf97bb7bc7a9fdeb"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"e3d91918d12958743a9e6ad6cb698a7f92633fb7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"have it as a gate."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"I also saw that extension and multi-node non-voting jobs"},{"line_number":22,"context_line":"where mssing reader versions so I added them."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I7b8e4c06ece6b32cab4d7238d0bc250334a3adb3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9f560f44_5e8ef3d0","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":12},"in_reply_to":"9f560f44_03b43a35","updated":"2020-09-09 11:14:31.000000000","message":"Done","commit_id":"5a846ba01dc88ee3147a862fdf97bb7bc7a9fdeb"}],"tox.ini":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2916c7f8a3237e65d2529f65310416da8879bc1e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   LANGUAGE\u003den_US"},{"line_number":14,"context_line":"   LC_ALL\u003den_US.utf-8"},{"line_number":15,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":16,"context_line":"passenv \u003d OS_STDOUT_CAPTURE OS_STDERR_CAPTURE OS_TEST_TIMEOUT OS_TEST_LOCK_PATH http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY"},{"line_number":17,"context_line":"whitelist_externals \u003d find"},{"line_number":18,"context_line":"deps \u003d"},{"line_number":19,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"9f560f44_4e5aae82","side":"PARENT","line":16,"range":{"start_line":16,"start_character":79,"end_line":16,"end_character":143},"updated":"2020-08-25 13:08:20.000000000","message":"not sure why you are removing these env var passing?","commit_id":"91fd70b98aea02d59887c491b5c0940f63c15363"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"9c16a465cf1a06ce35b4d76a051ce6ff22c83574","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   LANGUAGE\u003den_US"},{"line_number":14,"context_line":"   LC_ALL\u003den_US.utf-8"},{"line_number":15,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":16,"context_line":"passenv \u003d OS_STDOUT_CAPTURE OS_STDERR_CAPTURE OS_TEST_TIMEOUT OS_TEST_LOCK_PATH http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY"},{"line_number":17,"context_line":"whitelist_externals \u003d find"},{"line_number":18,"context_line":"deps \u003d"},{"line_number":19,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"9f560f44_8e616608","side":"PARENT","line":16,"range":{"start_line":16,"start_character":79,"end_line":16,"end_character":143},"in_reply_to":"9f560f44_4e5aae82","updated":"2020-08-25 13:13:54.000000000","message":"they are [assed through by default and are not needed\nsee docs https://tox.readthedocs.io/en/latest/config.html\n\nSome variables are always passed through to ensure the basic functionality of standard library functions or tooling like pip:\n\npassed through on all platforms: CURL_CA_BUNDLE, PATH, LANG, LANGUAGE, LD_LIBRARY_PATH, PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, REQUESTS_CA_BUNDLE, SSL_CERT_FILE, HTTP_PROXY, HTTPS_PROXY, NO_PROXY\n\nIf I read this wrong i will remove.  let me test this on my corporate laptop and get back to you","commit_id":"91fd70b98aea02d59887c491b5c0940f63c15363"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"59aeca264348609b419faf2c6645085a82aa9835","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[testenv:venv]"},{"line_number":41,"context_line":"commands \u003d {posargs}"},{"line_number":42,"context_line":"description\u003dCreates a virtual environment call venv with patrole installed"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:cover]"},{"line_number":45,"context_line":"commands \u003d rm -rf *.pyc"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9f560f44_15f4e386","line":42,"range":{"start_line":42,"start_character":42,"end_line":42,"end_character":46},"updated":"2020-08-31 16:02:40.000000000","message":"called","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"b30a2db3a5a29542310bc645e7d2e0157e74fe80","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[testenv:venv]"},{"line_number":41,"context_line":"commands \u003d {posargs}"},{"line_number":42,"context_line":"description\u003dCreates a virtual environment call venv with patrole installed"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:cover]"},{"line_number":45,"context_line":"commands \u003d rm -rf *.pyc"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9f560f44_abeb1810","line":42,"range":{"start_line":42,"start_character":42,"end_line":42,"end_character":46},"in_reply_to":"9f560f44_15f4e386","updated":"2020-08-31 23:40:44.000000000","message":"Done","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"59aeca264348609b419faf2c6645085a82aa9835","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"[testenv:debug]"},{"line_number":89,"context_line":"commands \u003d oslo_debug_helper -t patrole_tempest_plugin/tests {posargs}"},{"line_number":90,"context_line":"description\u003dSupport running test with pdb statements."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[testenv:genconfig]"},{"line_number":93,"context_line":"commands \u003d oslo-config-generator --config-file etc/config-generator.patrole.conf"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9f560f44_f5320f5e","line":90,"range":{"start_line":90,"start_character":28,"end_line":90,"end_character":32},"updated":"2020-08-31 16:02:40.000000000","message":"tests","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"b30a2db3a5a29542310bc645e7d2e0157e74fe80","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"[testenv:debug]"},{"line_number":89,"context_line":"commands \u003d oslo_debug_helper -t patrole_tempest_plugin/tests {posargs}"},{"line_number":90,"context_line":"description\u003dSupport running test with pdb statements."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[testenv:genconfig]"},{"line_number":93,"context_line":"commands \u003d oslo-config-generator --config-file etc/config-generator.patrole.conf"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9f560f44_ebf510ef","line":90,"range":{"start_line":90,"start_character":28,"end_line":90,"end_character":32},"in_reply_to":"9f560f44_f5320f5e","updated":"2020-08-31 23:40:44.000000000","message":"Done","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"59aeca264348609b419faf2c6645085a82aa9835","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[testenv:genconfig]"},{"line_number":93,"context_line":"commands \u003d oslo-config-generator --config-file etc/config-generator.patrole.conf"},{"line_number":94,"context_line":"description\u003dGenerate the conf values needed"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[flake8]"},{"line_number":97,"context_line":"# [H106] Don\u0027t put vim configuration in source files."}],"source_content_type":"text/x-properties","patch_set":10,"id":"9f560f44_952d93ff","line":94,"range":{"start_line":94,"start_character":12,"end_line":94,"end_character":43},"updated":"2020-08-31 16:02:40.000000000","message":"Generate a sample configuration file","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"b30a2db3a5a29542310bc645e7d2e0157e74fe80","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[testenv:genconfig]"},{"line_number":93,"context_line":"commands \u003d oslo-config-generator --config-file etc/config-generator.patrole.conf"},{"line_number":94,"context_line":"description\u003dGenerate the conf values needed"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[flake8]"},{"line_number":97,"context_line":"# [H106] Don\u0027t put vim configuration in source files."}],"source_content_type":"text/x-properties","patch_set":10,"id":"9f560f44_4bda3c79","line":94,"range":{"start_line":94,"start_character":12,"end_line":94,"end_character":43},"in_reply_to":"9f560f44_952d93ff","updated":"2020-08-31 23:40:44.000000000","message":"Done","commit_id":"886fc83c76eca04a5cc3b1dd62ae58ee7bf16d64"}]}
