)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"1f97cbf337a93e5235d3f4b685e221678a209907","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sampat Ponnaganti \u003csp810x@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-14 20:26:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[2008683] Added clean up and wait"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added logic to clean up the backup created"},{"line_number":10,"context_line":"Added logic to wait for the back to be deleted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ab76c5ec_ed637f86","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2021-03-15 15:35:40.000000000","message":"I don\u0027t think this is recognized, seems like linking to the story like this works:\n\nStory: 2008683","commit_id":"7e0e98b19d54b455249f5e0d70a7a813f4a5005c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"e93ecae5c9e6285705c762e1188b9701da36fafc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sampat Ponnaganti \u003csp810x@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-15 15:42:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Story:2008683 Added clean up and wait"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added logic to clean up the backup created"},{"line_number":10,"context_line":"Added logic to wait for the back to be deleted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"120e932f_5227b7df","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"updated":"2021-03-15 15:46:44.000000000","message":"Add this to the bottom of the commit message\n\nSee https://review.opendev.org/c/openstack/patrole/+/746480","commit_id":"2383797c33bc2a9bc90f09a0a187ed4fb72856ed"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12331a5795a4624eccd36ad2e33e21933a6fd1f8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated class level create_backup function to wait for resource delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"depends-on https://review.opendev.org/c/openstack/tempest/+/781142"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2008683"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"b590a06c_c97ddaf0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"updated":"2021-03-17 22:46:26.000000000","message":"Depends-On","commit_id":"08a590680db0f97d6aba1fea8b2421ca99f7f65f"}],"patrole_tempest_plugin/tests/api/volume/rbac_base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b6d4c6eefd2d2da7ab2de316f3f67f9fd9d37317","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            cls.volume_types_client.delete_volume_type, volume_type[\u0027id\u0027])"},{"line_number":51,"context_line":"        return volume_type"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def _create_backup(cls, volume_id, backup_client\u003dNone, **kwargs):"},{"line_number":55,"context_line":"        \"\"\"Wrapper utility that returns a test backup."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        Tempest has an instance-level version. This is a class-level version."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        if backup_client is None:"},{"line_number":60,"context_line":"            backup_client \u003d cls.backups_client"},{"line_number":61,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":62,"context_line":"            name \u003d data_utils.rand_name(cls.__name__ + \u0027-Backup\u0027)"},{"line_number":63,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":66,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"},{"line_number":67,"context_line":"        cls.addClassResourceCleanup("},{"line_number":68,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":69,"context_line":"            backup_client.delete_backup, backup[\u0027id\u0027])"},{"line_number":70,"context_line":"        cls.addClassResourceCleanup("},{"line_number":71,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":72,"context_line":"            backup_client.wait_for_resource_deletion, backup[\u0027id\u0027])"},{"line_number":73,"context_line":"        waiters.wait_for_volume_resource_status(backup_client, backup[\u0027id\u0027],"},{"line_number":74,"context_line":"                                                \u0027available\u0027)"},{"line_number":75,"context_line":"        waiters.wait_for_volume_resource_status(cls.volumes_client, volume_id,"},{"line_number":76,"context_line":"                                                \u0027available\u0027)"},{"line_number":77,"context_line":"        return backup"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def create_group_type(self, name\u003dNone, ignore_notfound\u003dFalse, **kwargs):"},{"line_number":80,"context_line":"        \"\"\"Create a test group-type\"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"7ad5f6bd_6133106f","line":77,"range":{"start_line":53,"start_character":0,"end_line":77,"end_character":21},"updated":"2021-03-17 16:44:51.000000000","message":"test_reset_backup_status which is what you are trying to fix here does not use this method to create the backup, instead it use tempest one as I mentioned in previous comment - https://review.opendev.org/c/openstack/patrole/+/778573/8/patrole_tempest_plugin/tests/api/volume/test_volumes_backup_rbac.py#116\n\nBut we can fix both place, here as well as in tempest.","commit_id":"bd286de6f1df3e7740c5a99f5c2cc3001cc40dd4"}],"patrole_tempest_plugin/tests/api/volume/test_volumes_backup_rbac.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"f594c672ebeb4e3eed5544df61ab8b5590425aad","unresolved":true,"context_lines":[{"line_number":111,"context_line":"                                                backup[\u0027id\u0027], \u0027error\u0027)"},{"line_number":112,"context_line":"        # Increase the wait timeout for this test"},{"line_number":113,"context_line":"        original_build_timeout \u003d self.backups_client.build_timeout"},{"line_number":114,"context_line":"        self.backups_client.build_timeout \u003d 600"},{"line_number":115,"context_line":"        self.backups_client.wait_for_resource_deletion(backup[\u0027id\u0027])"},{"line_number":116,"context_line":"        self.backups_client.build_timeout \u003d original_build_timeout"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"6f349be2_19184605","line":114,"range":{"start_line":114,"start_character":44,"end_line":114,"end_character":47},"updated":"2021-03-08 17:51:11.000000000","message":"you should not hardcode value","commit_id":"ee524088cd594563bc4d2b0ea97f1e74bc2cdaa4"},{"author":{"_account_id":30515,"name":"Sampat Ponnaganti","email":"sp810x@att.com","username":"sp810x@att.com"},"change_message_id":"a6410c7dc3dcde40c1d247dd6ba4b7a69c0d3c58","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                                backup[\u0027id\u0027], \u0027error\u0027)"},{"line_number":112,"context_line":"        # Increase the wait timeout for this test"},{"line_number":113,"context_line":"        original_build_timeout \u003d self.backups_client.build_timeout"},{"line_number":114,"context_line":"        self.backups_client.build_timeout \u003d 600"},{"line_number":115,"context_line":"        self.backups_client.wait_for_resource_deletion(backup[\u0027id\u0027])"},{"line_number":116,"context_line":"        self.backups_client.build_timeout \u003d original_build_timeout"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"161d5fcf_22e686ae","line":114,"range":{"start_line":114,"start_character":44,"end_line":114,"end_character":47},"in_reply_to":"6f349be2_19184605","updated":"2021-03-11 14:43:34.000000000","message":"I removed the hardcoded value.","commit_id":"ee524088cd594563bc4d2b0ea97f1e74bc2cdaa4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"87056ae9bd868444bb04cdd518983a56aaea1199","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                                                    status\u003d\u0027error\u0027)"},{"line_number":110,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":111,"context_line":"                                                backup[\u0027id\u0027], \u0027error\u0027)"},{"line_number":112,"context_line":"        # Increase the wait timeout for this test"},{"line_number":113,"context_line":"        original_build_timeout \u003d self.backups_client.build_timeout"},{"line_number":114,"context_line":"        self.backups_client.build_timeout \u003d 600"},{"line_number":115,"context_line":"        self.backups_client.wait_for_resource_deletion(backup[\u0027id\u0027])"},{"line_number":116,"context_line":"        self.backups_client.build_timeout \u003d original_build_timeout"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":119,"context_line":"    @rbac_rule_validation.action(service\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":8,"id":"a18da1b6_f08cb7df","line":116,"range":{"start_line":112,"start_character":0,"end_line":116,"end_character":66},"updated":"2021-03-08 22:47:40.000000000","message":"Instead of waiting here, you need to add the wait_for_resource_deletion in https://github.com/openstack/tempest/blob/7ee3ccf9f1bcb94c861d61a991230683c06f1bdb/tempest/api/volume/base.py#L159","commit_id":"ee524088cd594563bc4d2b0ea97f1e74bc2cdaa4"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"368bd716150a4b59a2a22051b5b9a6ec2c46a1bd","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                                                    status\u003d\u0027error\u0027)"},{"line_number":109,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":110,"context_line":"                                                backup[\u0027id\u0027], \u0027error\u0027)"},{"line_number":111,"context_line":"        self.addCleanup(self.backups_client.delete_backup, backup[\u0027id\u0027])"},{"line_number":112,"context_line":"        self.addCleanup(self.backups_client.wait_for_resource_deletion,"},{"line_number":113,"context_line":"                        backup[\u0027id\u0027])"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"f60833ec_dcc4d039","line":111,"updated":"2021-03-11 15:05:10.000000000","message":"This should move to line 106 because if waiters on line 109 fails, this line will not be executed and it is possible backup we just created might not get cleaned up.","commit_id":"8cc27cddad27efd8b698e47869737112cca0d626"},{"author":{"_account_id":30515,"name":"Sampat Ponnaganti","email":"sp810x@att.com","username":"sp810x@att.com"},"change_message_id":"ef4d406555c8bae886fa768a1c02e5140c05c2ed","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                                    status\u003d\u0027error\u0027)"},{"line_number":109,"context_line":"        waiters.wait_for_volume_resource_status(self.backups_client,"},{"line_number":110,"context_line":"                                                backup[\u0027id\u0027], \u0027error\u0027)"},{"line_number":111,"context_line":"        self.addCleanup(self.backups_client.delete_backup, backup[\u0027id\u0027])"},{"line_number":112,"context_line":"        self.addCleanup(self.backups_client.wait_for_resource_deletion,"},{"line_number":113,"context_line":"                        backup[\u0027id\u0027])"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"444d14bb_91eb10a8","line":111,"in_reply_to":"f60833ec_dcc4d039","updated":"2021-03-14 20:21:50.000000000","message":"Moved the clean up step to just after the backup is created.","commit_id":"8cc27cddad27efd8b698e47869737112cca0d626"}],"releasenotes/notes/volumes-backup-test-cleanup-7ffa74ae3599e6df.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"1f97cbf337a93e5235d3f4b685e221678a209907","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b2135d26_266bbdf1","updated":"2021-03-15 15:35:40.000000000","message":"Does this really need a releasenote?","commit_id":"7e0e98b19d54b455249f5e0d70a7a813f4a5005c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"60a69a959353f42baf23f25d03cc065fa5dd8f9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8d28da5e_06ba8f37","in_reply_to":"82ab2e31_27e67844","updated":"2021-03-15 15:45:52.000000000","message":"Which revision failed? It looks like the releasenote job passed for every patchset revision from what I can tell.","commit_id":"7e0e98b19d54b455249f5e0d70a7a813f4a5005c"},{"author":{"_account_id":30515,"name":"Sampat Ponnaganti","email":"sp810x@att.com","username":"sp810x@att.com"},"change_message_id":"0ee01e2046dd62faf4080ce38994aa64771db984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"82ab2e31_27e67844","in_reply_to":"b2135d26_266bbdf1","updated":"2021-03-15 15:40:13.000000000","message":"Build failed if I did not put this release note. Past build failure if have the details","commit_id":"7e0e98b19d54b455249f5e0d70a7a813f4a5005c"}]}