)]}'
{"patrole_tempest_plugin/tests/api/network/test_log_resource_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d4783847d875953fa0f6772cd19ab21feae9ec11","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def skip_checks(cls):"},{"line_number":28,"context_line":"        super(LogResourceRbacTest, cls).skip_checks()"},{"line_number":29,"context_line":"        if not utils.is_extension_enabled(\u0027log-resource\u0027, \u0027network\u0027):"},{"line_number":30,"context_line":"            msg \u003d \"log resource extension not enabled.\""},{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"29d01713_d12a6a89","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":55},"updated":"2021-09-29 02:48:43.000000000","message":"extension name is \u0027logging-resource\u0027 not \u0027log-resource\u0027\n\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/logging_resource.py#L21","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"ae57dcd33a780515f07cf9d07785cc247de45fc9","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def skip_checks(cls):"},{"line_number":28,"context_line":"        super(LogResourceRbacTest, cls).skip_checks()"},{"line_number":29,"context_line":"        if not utils.is_extension_enabled(\u0027log-resource\u0027, \u0027network\u0027):"},{"line_number":30,"context_line":"            msg \u003d \"log resource extension not enabled.\""},{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e3555899_c5ad81e7","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":55},"in_reply_to":"29d01713_d12a6a89","updated":"2021-10-11 07:16:40.000000000","message":"I guess extension name is logging for this particular test. According to the api-ref doc, https://docs.openstack.org/api-ref/network/v2/index.html?#list-logs, extension specified here is logging.","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa222d302ca1fe0b484deb8d8b36f45f1fe1245a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def skip_checks(cls):"},{"line_number":28,"context_line":"        super(LogResourceRbacTest, cls).skip_checks()"},{"line_number":29,"context_line":"        if not utils.is_extension_enabled(\u0027log-resource\u0027, \u0027network\u0027):"},{"line_number":30,"context_line":"            msg \u003d \"log resource extension not enabled.\""},{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f16bcf4_d5293bae","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":55},"in_reply_to":"e3555899_c5ad81e7","updated":"2021-11-11 19:55:37.000000000","message":"that might be just name reference in doc but you can see the code here https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/logging_resource.py#L21","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d4783847d875953fa0f6772cd19ab21feae9ec11","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    def skip_checks(cls):"},{"line_number":28,"context_line":"        super(LogResourceRbacTest, cls).skip_checks()"},{"line_number":29,"context_line":"        if not utils.is_extension_enabled(\u0027log-resource\u0027, \u0027network\u0027):"},{"line_number":30,"context_line":"            msg \u003d \"log resource extension not enabled.\""},{"line_number":31,"context_line":"            raise cls.skipException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_log(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f86a4127_8225cd87","line":30,"range":{"start_line":30,"start_character":19,"end_line":30,"end_character":23},"updated":"2021-09-29 02:48:43.000000000","message":"logging","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d4783847d875953fa0f6772cd19ab21feae9ec11","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                log[\u0027id\u0027], tenant_id\u003dNone)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"show_log\"],"},{"line_number":69,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027fbdb1a17-6666-4994-b88a-f0b339e48e5f\u0027)"},{"line_number":71,"context_line":"    def test_show_log(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b4f50e25_c44a5dc9","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":52},"updated":"2021-09-29 02:48:43.000000000","message":"I do not think we have show_log policy for this. wondering why this is not failing can you check?","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"ae57dcd33a780515f07cf9d07785cc247de45fc9","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                log[\u0027id\u0027], tenant_id\u003dNone)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"show_log\"],"},{"line_number":69,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027fbdb1a17-6666-4994-b88a-f0b339e48e5f\u0027)"},{"line_number":71,"context_line":"    def test_show_log(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d641ff78_be19fe01","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":52},"in_reply_to":"1ab808a4_1d152176","updated":"2021-10-11 07:16:40.000000000","message":"I am keeping this policy as it is until we get any response from neutron side whether they require this policy or not.","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"c2a7e799f2f45b0cab8a763f2504078067d71c15","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                log[\u0027id\u0027], tenant_id\u003dNone)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"show_log\"],"},{"line_number":69,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027fbdb1a17-6666-4994-b88a-f0b339e48e5f\u0027)"},{"line_number":71,"context_line":"    def test_show_log(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ab808a4_1d152176","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":52},"in_reply_to":"b4f50e25_c44a5dc9","updated":"2021-10-04 14:04:24.000000000","message":"Yes, you are right, we don\u0027t have show_log policy. But we have api mentioned here - https://docs.openstack.org/api-ref/network/v2/index.html?show-log\u0026expanded\u003dshow-log-detail.\n\nI think we need to add show_log policy in neutron","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa222d302ca1fe0b484deb8d8b36f45f1fe1245a","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                log[\u0027id\u0027], tenant_id\u003dNone)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"show_log\"],"},{"line_number":69,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027fbdb1a17-6666-4994-b88a-f0b339e48e5f\u0027)"},{"line_number":71,"context_line":"    def test_show_log(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d9f0a6a_dc22f287","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":52},"in_reply_to":"b608a251_d73a9173","updated":"2021-11-11 19:55:37.000000000","message":"yeah, it is get_log https://github.com/openstack/neutron/blob/master/neutron/conf/policies/logging.py#L63","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"373e3e08a3272eb32325384d87d340e1cc73a464","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                log[\u0027id\u0027], tenant_id\u003dNone)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":68,"context_line":"                                 rules\u003d[\"show_log\"],"},{"line_number":69,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027fbdb1a17-6666-4994-b88a-f0b339e48e5f\u0027)"},{"line_number":71,"context_line":"    def test_show_log(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b608a251_d73a9173","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":52},"in_reply_to":"d641ff78_be19fe01","updated":"2021-10-11 09:41:55.000000000","message":"While going through the other neutron policies and patrole tests, I found that there is no implementation of show rule, in fact in neutron AFAIK, create, delete, update and get operations have been implemented for all the policies. Hence, the show operation for the respective extension have been implemented using get rule in Patrole.\n\nHence, I am correcting the show_log policy here with the get_log rule.","commit_id":"b6487ed24d0140ee5658107df57ebd0739232c64"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa222d302ca1fe0b484deb8d8b36f45f1fe1245a","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        with self.override_role():"},{"line_number":92,"context_line":"            # Delete the Log"},{"line_number":93,"context_line":"            self.log_resource_client.delete_log(log[\u0027id\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\", rules\u003d[\"get_log\"])"},{"line_number":96,"context_line":"    @decorators.idempotent_id(\u002778f78ffc-b24a-4857-aed9-26cf324dc56d\u0027)"},{"line_number":97,"context_line":"    def test_list_logs(self):"},{"line_number":98,"context_line":"        \"\"\"List Logs."}],"source_content_type":"text/x-python","patch_set":9,"id":"a009b3fb_687e8094","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":70},"updated":"2021-11-11 19:55:37.000000000","message":"+1, this is right one now - https://github.com/openstack/neutron/blob/master/neutron/conf/policies/logging.py#L63","commit_id":"9f6e129aa139cdbcaaae4bd2ad3f66f4b6347e34"}]}