)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"12d25360166b2588a39383f1e585c6dc16c1778f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3408527c_64cb64ac","updated":"2021-10-11 07:52:35.000000000","message":"recheck","commit_id":"aeed7fb98eb3e52fb02d0934efb023e0f5be4905"}],"patrole_tempest_plugin/tests/api/network/test_loggable_resource_rbac.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aedc9ae86564e407cb14852ca65d30160bc4d2a7","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(LoggableResourceRbacTest, cls).skip_checks()"},{"line_number":28,"context_line":"        if not utils.is_extension_enabled(\u0027loggable-resource\u0027, \u0027network\u0027):"},{"line_number":29,"context_line":"            msg \u003d \"loggable resource extension not enabled.\""},{"line_number":30,"context_line":"            raise cls.skipException(msg)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b390a3e0_5044fe99","line":28,"range":{"start_line":28,"start_character":43,"end_line":28,"end_character":60},"updated":"2021-09-29 02:50:54.000000000","message":"I cannot find this extensions, can you please point me to the neutron code having this extension?","commit_id":"521274d55aecbe9befc168ea9e9748ee27568af7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12217aa332a94e04742031b9a575d945d79ed286","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(LoggableResourceRbacTest, cls).skip_checks()"},{"line_number":28,"context_line":"        if not utils.is_extension_enabled(\u0027loggable-resource\u0027, \u0027network\u0027):"},{"line_number":29,"context_line":"            msg \u003d \"loggable resource extension not enabled.\""},{"line_number":30,"context_line":"            raise cls.skipException(msg)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9c017959_ed2a921a","line":28,"range":{"start_line":28,"start_character":43,"end_line":28,"end_character":60},"in_reply_to":"12d937b0_12690d38","updated":"2021-10-05 14:15:05.000000000","message":"I think this is the extension https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/logging_resource.py","commit_id":"521274d55aecbe9befc168ea9e9748ee27568af7"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"c701f7e4e274438bfd174eb6000b8681ab4f704d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(LoggableResourceRbacTest, cls).skip_checks()"},{"line_number":28,"context_line":"        if not utils.is_extension_enabled(\u0027loggable-resource\u0027, \u0027network\u0027):"},{"line_number":29,"context_line":"            msg \u003d \"loggable resource extension not enabled.\""},{"line_number":30,"context_line":"            raise cls.skipException(msg)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"61b42c9d_3d99e1b4","line":28,"range":{"start_line":28,"start_character":43,"end_line":28,"end_character":60},"in_reply_to":"9c017959_ed2a921a","updated":"2021-10-11 07:17:24.000000000","message":"Ack","commit_id":"521274d55aecbe9befc168ea9e9748ee27568af7"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"69c344ffbc44ece96e788ff122fe0acb2ed2690a","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(LoggableResourceRbacTest, cls).skip_checks()"},{"line_number":28,"context_line":"        if not utils.is_extension_enabled(\u0027loggable-resource\u0027, \u0027network\u0027):"},{"line_number":29,"context_line":"            msg \u003d \"loggable resource extension not enabled.\""},{"line_number":30,"context_line":"            raise cls.skipException(msg)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"12d937b0_12690d38","line":28,"range":{"start_line":28,"start_character":43,"end_line":28,"end_character":60},"in_reply_to":"b390a3e0_5044fe99","updated":"2021-10-04 14:03:52.000000000","message":"We don\u0027t have this extension in neutron but we have the respective apis listed here :- https://docs.openstack.org/api-ref/network/v2/index.html?#list-loggable-resources.\n\nIn the storyboard, this apis are listed to add the respective RBAC tests[2], but before writing these tests, I forgot to check the neutron extensions for the same.\n\nSo, Do I need to add the extension in neutron for the loggable resource?\n\n[2] https://storyboard.openstack.org/#!/story/2002641","commit_id":"521274d55aecbe9befc168ea9e9748ee27568af7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aedc9ae86564e407cb14852ca65d30160bc4d2a7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            raise cls.skipException(msg)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":33,"context_line":"                                 rules\u003d[\"list_loggable_resources\"],"},{"line_number":34,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u0027b21b29ed-a97d-47d3-962b-499e68d98b35\u0027)"},{"line_number":36,"context_line":"    def test_list_loggable_resources(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"57091d44_6fd23d86","line":33,"range":{"start_line":33,"start_character":41,"end_line":33,"end_character":64},"updated":"2021-09-29 02:50:54.000000000","message":"ditto","commit_id":"521274d55aecbe9befc168ea9e9748ee27568af7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3b10325a828755183aea9c26146bfebae6072cf1","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(LoggableResourceRbacTest, cls).skip_checks()"},{"line_number":28,"context_line":"        if not utils.is_extension_enabled(\u0027logging\u0027, \u0027network\u0027):"},{"line_number":29,"context_line":"            msg \u003d \"logging extension not enabled.\""},{"line_number":30,"context_line":"            raise cls.skipException(msg)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ca9772c9_41da2a3e","line":28,"range":{"start_line":28,"start_character":43,"end_line":28,"end_character":50},"updated":"2021-11-11 19:58:22.000000000","message":"it is logging-resources https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/logging_resource.py#L21","commit_id":"38639c3d1ceaa8737c21d6e1c1d856da84ed0753"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3b10325a828755183aea9c26146bfebae6072cf1","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    @rbac_rule_validation.action(service\u003d\"neutron\","},{"line_number":33,"context_line":"                                 rules\u003d[\"get_loggable_resource\"],"},{"line_number":34,"context_line":"                                 expected_error_codes\u003d[404])"},{"line_number":35,"context_line":"    @decorators.idempotent_id(\u0027b21b29ed-a97d-47d3-962b-499e68d98b35\u0027)"},{"line_number":36,"context_line":"    def test_list_loggable_resources(self):"},{"line_number":37,"context_line":"        \"\"\"List Loggable resources."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        RBAC test for the neutron list loggable resources policy"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        with self.override_role():"},{"line_number":42,"context_line":"            self.loggable_resource_client.list_loggable_resources()"}],"source_content_type":"text/x-python","patch_set":4,"id":"8ed8a235_ca9f79ec","line":42,"range":{"start_line":35,"start_character":0,"end_line":42,"end_character":67},"updated":"2021-11-11 19:58:22.000000000","message":"I think we need to add this tests in same file other log resources are there https://review.opendev.org/c/openstack/patrole/+/795548/9/patrole_tempest_plugin/tests/api/network/test_log_resource_rbac.py","commit_id":"38639c3d1ceaa8737c21d6e1c1d856da84ed0753"}]}