)]}'
{"paunch/builder/base.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"432ab728478bfa172871882099952dacc88443ad","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                            self.runner.remove_container(container)"},{"line_number":83,"context_line":"                        else:"},{"line_number":84,"context_line":"                            continue_state \u003d True"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        continue_state \u003d True"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"                    if continue_state:"},{"line_number":89,"context_line":"                        self.log.debug(\u0027Skipping existing container: %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fa02e76e","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":45},"updated":"2019-03-12 23:46:31.000000000","message":"If inspect_container is None then the container is missing and we need to create it. Removing these two lines would simplify this logic enough to get rid of continue_state entirely","commit_id":"fc67de1bf614c88a94a0993ffc70b3344a592a51"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"4f7e4fe885e3a171068cb7c3efe0f75a96b663e6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                            self.runner.remove_container(container)"},{"line_number":83,"context_line":"                        else:"},{"line_number":84,"context_line":"                            continue_state \u003d True"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        continue_state \u003d True"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"                    if continue_state:"},{"line_number":89,"context_line":"                        self.log.debug(\u0027Skipping existing container: %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6f8a766a","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":45},"in_reply_to":"5fc1f717_fa02e76e","updated":"2019-07-17 16:02:09.000000000","message":"Done","commit_id":"fc67de1bf614c88a94a0993ffc70b3344a592a51"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6ecd7ff561dee59be63181f59546846f7ab09493","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    self.log.debug(\"Discovering container.\")"},{"line_number":80,"context_line":"                    discover_container \u003d self.runner.discover_container_name("},{"line_number":81,"context_line":"                        container, self.config_id)"},{"line_number":82,"context_line":"                    self.log.debug(\"Inspecting container.\")"},{"line_number":83,"context_line":"                    inspect_container \u003d self.runner.inspect(discover_container)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"                    if inspect_container is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_7a668154","line":82,"updated":"2019-07-03 21:01:15.000000000","message":"I think the above 3 debug lines can be deleted now","commit_id":"778d9b69f3d90862c5e0925e6b0a8646ff30d7c7"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"06179ea46848ab5ac5fb68322bce3342f61b7cbf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    self.log.debug(\"Discovering container.\")"},{"line_number":80,"context_line":"                    discover_container \u003d self.runner.discover_container_name("},{"line_number":81,"context_line":"                        container, self.config_id)"},{"line_number":82,"context_line":"                    self.log.debug(\"Inspecting container.\")"},{"line_number":83,"context_line":"                    inspect_container \u003d self.runner.inspect(discover_container)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"                    if inspect_container is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_d304227e","line":82,"in_reply_to":"7faddb67_7a668154","updated":"2019-07-05 15:33:29.000000000","message":"I\u0027ll clean these up.","commit_id":"778d9b69f3d90862c5e0925e6b0a8646ff30d7c7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6ecd7ff561dee59be63181f59546846f7ab09493","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        continue_state \u003d True"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                    if continue_state:"},{"line_number":99,"context_line":"                        self.log.debug(\"Skipping existing container.\")"},{"line_number":100,"context_line":"                        continue"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"                self.log.debug(\"Start the container.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_da02153f","line":99,"updated":"2019-07-03 21:01:15.000000000","message":"The above remaining debug statements should include %s discover_container so there is useful messages about which container is being acted on.","commit_id":"778d9b69f3d90862c5e0925e6b0a8646ff30d7c7"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"06179ea46848ab5ac5fb68322bce3342f61b7cbf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        continue_state \u003d True"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                    if continue_state:"},{"line_number":99,"context_line":"                        self.log.debug(\"Skipping existing container.\")"},{"line_number":100,"context_line":"                        continue"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"                self.log.debug(\"Start the container.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_130b9a8e","line":99,"in_reply_to":"7faddb67_da02153f","updated":"2019-07-05 15:33:29.000000000","message":"I originally had this in an older patch set but I removed it since I had a debug earlier that states the container name. I can see the value in being able to grep for the actual container name in the log file and get all of the related results, though. I\u0027ll send an updated patch set.","commit_id":"778d9b69f3d90862c5e0925e6b0a8646ff30d7c7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"0b2c4d4fe17175f317687129ea2a6abd236326b0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                                           \"running.\".format(container))"},{"line_number":95,"context_line":"                            continue_state \u003d True"},{"line_number":96,"context_line":"                    else:"},{"line_number":97,"context_line":"                        continue_state \u003d True"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                    if continue_state:"},{"line_number":100,"context_line":"                        self.log.debug(\"Skipping existing container \" +"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_4c058813","line":97,"updated":"2019-07-12 15:09:03.000000000","message":"i\u0027m not sure about these 2 lines.\n\nIf inspect_container is None, it means that the inspect command failed for some reason. In which case we assume we can skip the container. I\u0027m not sure that\u0027s a safe assumption.\n\nwhat might cause the inspect command to have failed in the first place in this case?","commit_id":"2165130bba0b30ee1dd75b731a6f9dfa773f58be"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"4f7e4fe885e3a171068cb7c3efe0f75a96b663e6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                                           \"running.\".format(container))"},{"line_number":95,"context_line":"                            continue_state \u003d True"},{"line_number":96,"context_line":"                    else:"},{"line_number":97,"context_line":"                        continue_state \u003d True"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                    if continue_state:"},{"line_number":100,"context_line":"                        self.log.debug(\"Skipping existing container \" +"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_0ff2e206","line":97,"in_reply_to":"7faddb67_4c058813","updated":"2019-07-17 16:02:09.000000000","message":"Done","commit_id":"2165130bba0b30ee1dd75b731a6f9dfa773f58be"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f002e207f8d6f255cef988077399fa1218315333","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                        self.log.warn(\"Unable to find the container state\" +"},{"line_number":89,"context_line":"                                      \" for %s.\" % container)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    if inspect_container[\"State\"][\"Running\"]:"},{"line_number":92,"context_line":"                        self.log.debug(\"Container %s is already running.\" %"},{"line_number":93,"context_line":"                                       container)"},{"line_number":94,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_df2b9ce7","line":91,"updated":"2019-08-27 14:28:32.000000000","message":"here we need to add a \"if restart\" or something. This code breaks the pacemaker-managed containers.","commit_id":"85fb2ed4d3f7e42840842f2bdec617e33d6ba4ef"}],"paunch/runner.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6ecd7ff561dee59be63181f59546846f7ab09493","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.log.debug(\"Inspect command: {}\".format(cmd))"},{"line_number":118,"context_line":"        self.log.debug(\"Inspect quiet: {}\".format(quiet))"},{"line_number":119,"context_line":"        result \u003d self.execute(cmd, self.log, quiet)"},{"line_number":120,"context_line":"        self.log.debug(\"result {}\".format(result))"},{"line_number":121,"context_line":"        (cmd_stdout, cmd_stderr, returncode) \u003d result"},{"line_number":122,"context_line":"        if returncode !\u003d 0:"},{"line_number":123,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_7a99a11d","line":120,"updated":"2019-07-03 21:01:15.000000000","message":"Probably don\u0027t need these debugs now","commit_id":"778d9b69f3d90862c5e0925e6b0a8646ff30d7c7"}]}