)]}'
{"paunch/builder/base.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d252ce200cac7b981e8500247597859e17530a00","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # make sure the correct one is used"},{"line_number":246,"context_line":"        if command:"},{"line_number":247,"context_line":"            command[0] \u003d self.runner.discover_container_name("},{"line_number":248,"context_line":"                command[0], self.config_id)"},{"line_number":249,"context_line":"        cmd.extend(command)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f74a9524","line":248,"updated":"2019-08-21 22:54:58.000000000","message":"you didn\u0027t add delegate here so we always use the fixed container name for exec","commit_id":"5d174c1bea474a34da6f4f68173323a8243c4fc5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f11d6297a31fab0b151cb835f93137d0ebd76136","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # make sure the correct one is used"},{"line_number":246,"context_line":"        if command:"},{"line_number":247,"context_line":"            command[0] \u003d self.runner.discover_container_name("},{"line_number":248,"context_line":"                command[0], self.config_id)"},{"line_number":249,"context_line":"        cmd.extend(command)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ed3da78e","line":248,"in_reply_to":"7faddb67_27fc3e0b","updated":"2019-08-26 13:03:47.000000000","message":"discover_container_name operates by the label filters, where it always expects to see the predictable (fixed) service name.\nIt needs no information about the running container name (the delegate)... But, it seems that cont_exec_args call does need it! I\u0027ll post a follow-up","commit_id":"5d174c1bea474a34da6f4f68173323a8243c4fc5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1834cd59ba15b881e2b74536ddce97060b71aa36","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # make sure the correct one is used"},{"line_number":246,"context_line":"        if command:"},{"line_number":247,"context_line":"            command[0] \u003d self.runner.discover_container_name("},{"line_number":248,"context_line":"                command[0], self.config_id)"},{"line_number":249,"context_line":"        cmd.extend(command)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ad700f75","line":248,"in_reply_to":"7faddb67_f74a9524","updated":"2019-08-26 13:05:51.000000000","message":"hm, no, no changes seems needed there.\n\nAnd discover_container_name basically discovers the real container name, not the fixed service name, AFAIK?..","commit_id":"5d174c1bea474a34da6f4f68173323a8243c4fc5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f59f715bca71b72257c06509e883638ee9165a0e","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # make sure the correct one is used"},{"line_number":246,"context_line":"        if command:"},{"line_number":247,"context_line":"            command[0] \u003d self.runner.discover_container_name("},{"line_number":248,"context_line":"                command[0], self.config_id)"},{"line_number":249,"context_line":"        cmd.extend(command)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_27fc3e0b","line":248,"in_reply_to":"7faddb67_f74a9524","updated":"2019-08-26 10:29:35.000000000","message":"we need to test this very carefully...","commit_id":"5d174c1bea474a34da6f4f68173323a8243c4fc5"}]}