)]}'
{"paunch/builder/base.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6d1c10126923dadbd56801ce6b4bf2613d96678f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            self.log.debug(\"Deleting stopped container %s.\" %"},{"line_number":129,"context_line":"                                           container)"},{"line_number":130,"context_line":"                            self.runner.remove_container(container)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"                cmd \u003d ["},{"line_number":134,"context_line":"                    self.runner.cont_cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5818381d","line":131,"updated":"2019-08-26 16:06:17.000000000","message":"don\u0027t we miss an else here?","commit_id":"8ce2c03788f1d9f07f6835d6ed6f93f4ec72daa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4b7eb5a3fadf63bbcd7c06857643c53b84f7e18a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            self.log.debug(\"Deleting stopped container %s.\" %"},{"line_number":129,"context_line":"                                           container)"},{"line_number":130,"context_line":"                            self.runner.remove_container(container)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"                cmd \u003d ["},{"line_number":134,"context_line":"                    self.runner.cont_cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f8dec43c","line":131,"in_reply_to":"7faddb67_5818381d","updated":"2019-08-26 16:07:00.000000000","message":"wrong PS, nevermind this comment.","commit_id":"8ce2c03788f1d9f07f6835d6ed6f93f4ec72daa7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c22e02edd4e2a199ea207758264d18ed4173037f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.delete_missing_and_updated()"},{"line_number":48,"context_line":"        deploy_status_code \u003d 0"},{"line_number":49,"context_line":"        key_fltr \u003d lambda k: self.config[k].get(\u0027start_order\u0027, 0)"},{"line_number":50,"context_line":"        container_names \u003d self.runner.container_names(self.config_id)"},{"line_number":51,"context_line":"        desired_names \u003d set([cn[-1] for cn in container_names])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        for container in sorted(self.config, key\u003dkey_fltr):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9af3f209","line":50,"updated":"2019-08-27 14:52:05.000000000","message":"@Cedric, shall we as well expand the scope for the desired names to span all the configs?..","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d023149fc70ec2b478fd51b49bbabf8b9a370bc7","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    try:"},{"line_number":92,"context_line":"                        cstate \u003d inspect_container[\"State\"][\"Running\"]"},{"line_number":93,"context_line":"                        if inspect_container:"},{"line_number":94,"context_line":"                            # Only log for it, if had been earlier discovered"},{"line_number":95,"context_line":"                            if discover_container !\u003d container:"},{"line_number":96,"context_line":"                                self.log.debug("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_7dccfbba","line":93,"updated":"2019-08-27 06:34:09.000000000","message":"we don\u0027t need this if-statement, in this point of code inspect_container is always not empty dict","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"46c81040614bd4a632e3869997307dc854bcb348","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    try:"},{"line_number":92,"context_line":"                        cstate \u003d inspect_container[\"State\"][\"Running\"]"},{"line_number":93,"context_line":"                        if inspect_container:"},{"line_number":94,"context_line":"                            # Only log for it, if had been earlier discovered"},{"line_number":95,"context_line":"                            if discover_container !\u003d container:"},{"line_number":96,"context_line":"                                self.log.debug("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_dfdddc13","line":93,"in_reply_to":"7faddb67_7dccfbba","updated":"2019-08-27 14:26:09.000000000","message":"ah, you\u0027re 100% right","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"83d4e6d7b020f1d1561aeda99abaed16f7f35727","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    try:"},{"line_number":92,"context_line":"                        cstate \u003d inspect_container[\"State\"][\"Running\"]"},{"line_number":93,"context_line":"                        if inspect_container:"},{"line_number":94,"context_line":"                            # Only log for it, if had been earlier discovered"},{"line_number":95,"context_line":"                            if discover_container !\u003d container:"},{"line_number":96,"context_line":"                                self.log.debug("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_1f6614bd","line":93,"in_reply_to":"7faddb67_7dccfbba","updated":"2019-08-27 14:18:06.000000000","message":"at the line #86 it may be None. And we want to detect that situation here to omit calling inspect.","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8d8714d35379b34e083c713b5a32181b4b80ce7f","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    try:"},{"line_number":92,"context_line":"                        cstate \u003d inspect_container[\"State\"][\"Running\"]"},{"line_number":93,"context_line":"                        if inspect_container:"},{"line_number":94,"context_line":"                            # Only log for it, if had been earlier discovered"},{"line_number":95,"context_line":"                            if discover_container !\u003d container:"},{"line_number":96,"context_line":"                                self.log.debug("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_2daf187e","line":93,"in_reply_to":"7faddb67_7dccfbba","updated":"2019-08-28 07:54:19.000000000","message":"wrong - might be None, and we get a python crash with \"NoneType is not iterable\" or something like that. Had to add it in order to avoid that crash.","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d023149fc70ec2b478fd51b49bbabf8b9a370bc7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                        cstate \u003d inspect_container[\"State\"][\"Running\"]"},{"line_number":93,"context_line":"                        if inspect_container:"},{"line_number":94,"context_line":"                            # Only log for it, if had been earlier discovered"},{"line_number":95,"context_line":"                            if discover_container !\u003d container:"},{"line_number":96,"context_line":"                                self.log.debug("},{"line_number":97,"context_line":"                                    \"Container running state for %s discovered\""},{"line_number":98,"context_line":"                                    \" as %s: %s.\" % (container,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_3d768341","line":95,"updated":"2019-08-27 06:34:09.000000000","message":"this logs can be move bellow to this if-statement block:\nif inspect_container and inspect_container[\"State\"][\"Running\"]:","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d023149fc70ec2b478fd51b49bbabf8b9a370bc7","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                self.log.debug("},{"line_number":103,"context_line":"                                    \"Container running state for\""},{"line_number":104,"context_line":"                                    \" %s: %s.\" % (container, cstate))"},{"line_number":105,"context_line":"                    except Exception:"},{"line_number":106,"context_line":"                        self.log.warn(\"Unable to find the container state\" +"},{"line_number":107,"context_line":"                                      \" for %s.\" % container)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_fd6f8b5d","line":105,"updated":"2019-08-27 06:34:09.000000000","message":"this part can be a simple else part in block:\nif inspect_container and inspect_container[\"State\"][\"Running\"]:\n  (...)\nelif inspect_container:\n  (...)\nelse:\n  self.log.warn(\"Unable to find the container state\" +\n                                      \" for %s.\" % container)","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a456017fcbcd093b3b9e12a62e1a6750fb2c60f2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                        self.log.warn(\"Unable to find the container state\" +"},{"line_number":107,"context_line":"                                      \" for %s.\" % container)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"                    if inspect_container and \\"},{"line_number":110,"context_line":"                            inspect_container[\"State\"][\"Running\"]:"},{"line_number":111,"context_line":"                        if discover_container !\u003d container:"},{"line_number":112,"context_line":"                            self.log.debug(\"Container %s is already running as\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9f99a46e","line":109,"updated":"2019-08-27 14:24:31.000000000","message":"at this point inspect_container cannot be empty, or there will be an exception raised otherwise, see the line #92 -\u003e except {}","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bcb4e8d871c0a78a6ee89a207cf3cd859fb4bc1b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                        self.log.warn(\"Unable to find the container state\" +"},{"line_number":107,"context_line":"                                      \" for %s.\" % container)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"                    if inspect_container and \\"},{"line_number":110,"context_line":"                            inspect_container[\"State\"][\"Running\"]:"},{"line_number":111,"context_line":"                        if discover_container !\u003d container:"},{"line_number":112,"context_line":"                            self.log.debug(\"Container %s is already running as\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_7faf087d","line":109,"in_reply_to":"7faddb67_9f99a46e","updated":"2019-08-27 14:25:02.000000000","message":"s/will/would\u0027ve been/g","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"d023149fc70ec2b478fd51b49bbabf8b9a370bc7","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                    elif inspect_container:"},{"line_number":120,"context_line":"                        # only delete the container, if its state had been"},{"line_number":121,"context_line":"                        # discovered earlier"},{"line_number":122,"context_line":"                        if discover_container !\u003d container:"},{"line_number":123,"context_line":"                            self.log.debug("},{"line_number":124,"context_line":"                                \"Deleting stopped container %s \""},{"line_number":125,"context_line":"                                \"discovered as %s.\" % (container,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_bdb833c7","line":122,"updated":"2019-08-27 06:34:09.000000000","message":"this can be simplified a little bit. We can call self.runner.remove_container only once after if-else block because we always want to remove container that we have in variable discover_container. So block will look like this:\nif discover_container !\u003d container:\n  self.log.debug\nelse:\n  self.log.debug\nself.runner.remove_container(discover_container)","commit_id":"5f963dfead0bc5ebcbae671a66115a93272bcea7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2149b1d6ace5a83dd303f924b55837cc790447db","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            if action \u003d\u003d \u0027run\u0027:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"                discover_container \u003d None"},{"line_number":79,"context_line":"                if container in desired_names:"},{"line_number":80,"context_line":"                    discover_container \u003d self.runner.discover_container_name("},{"line_number":81,"context_line":"                        container, self.config_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_ed690026","line":78,"updated":"2019-08-28 08:10:18.000000000","message":"this is the outer scope initialization to use it safely at #138","commit_id":"edc593b99278d64a5fb4b7fde8f812089e3dec47"}]}