)]}'
{"paunch/runner.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f6f7615a960aecd6c65124dd429435edc3902ca0","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            \u0027{{.Names}}\u0027"},{"line_number":171,"context_line":"        ]"},{"line_number":172,"context_line":"        (cmd_stdout, cmd_stderr, returncode) \u003d self.execute(cmd, self.log)"},{"line_number":173,"context_line":"        results \u003d cmd_stdout.split()"},{"line_number":174,"context_line":"        if returncode \u003d\u003d 0 and results and results !\u003d [\u0027\u0027]:"},{"line_number":175,"context_line":"            return results[0]"},{"line_number":176,"context_line":"        # NOTE(bogdando): also look by a single-item list representation"},{"line_number":177,"context_line":"        # to identify such configs for the minor updates case"},{"line_number":178,"context_line":"        cmd \u003d ["},{"line_number":179,"context_line":"            self.cont_cmd,"},{"line_number":180,"context_line":"            \u0027ps\u0027,"},{"line_number":181,"context_line":"            \u0027-a\u0027,"},{"line_number":182,"context_line":"            \u0027--filter\u0027,"},{"line_number":183,"context_line":"            \u0027label\u003dcontainer_name\u003d%s\u0027 % container,"},{"line_number":184,"context_line":"            \u0027--filter\u0027,"},{"line_number":185,"context_line":"            \u0027label\u003dconfig_id\u003d[\\\u0027%s\\\u0027]\u0027 % cid,"},{"line_number":186,"context_line":"            \u0027--format\u0027,"},{"line_number":187,"context_line":"            \u0027{{.Names}}\u0027"},{"line_number":188,"context_line":"        ]"},{"line_number":189,"context_line":"        (cmd_stdout, cmd_stderr, returncode) \u003d self.execute(cmd, self.log)"},{"line_number":190,"context_line":"        results \u003d cmd_stdout.split()"},{"line_number":191,"context_line":"        if returncode \u003d\u003d 0 and results and results !\u003d [\u0027\u0027]:"},{"line_number":192,"context_line":"            return results[0]"},{"line_number":193,"context_line":"        self.log.warning(\u0027Did not find container with \"%s\" - retrying without \u0027"},{"line_number":194,"context_line":"                         \u0027config_id\u0027 % cmd)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9a78397e","line":192,"range":{"start_line":173,"start_character":0,"end_line":192,"end_character":29},"updated":"2019-12-12 13:32:20.000000000","message":"This is not efficient, you\u0027re adding a ps operation which isn\u0027t free.\n\nIMHO we should fix the config_id to not having [\\\u0027%s\\\u0027] in parameter, but rather have a simple string. We probably need to re-patch tripleo-ansible I guess. I\u0027m opposed to this proposed solution in any case.","commit_id":"88291ce6f0168f36205b74543aa658f5786f5e86"}]}