)]}'
{"paunch/utils/systemd.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5304fba7dafb8df1e8c317523a66b09bf7361f4b","unresolved":false,"context_lines":[{"line_number":195,"context_line":"[Service]"},{"line_number":196,"context_line":"Type\u003doneshot"},{"line_number":197,"context_line":"ExecStart\u003d/usr/bin/podman exec %(name)s %(test)s"},{"line_number":198,"context_line":"SyslogIdentifier\u003dhealthcheck_%(name)s"},{"line_number":199,"context_line":"[Install]"},{"line_number":200,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":201,"context_line":"\"\"\" % s_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f905747a","line":198,"updated":"2019-12-17 21:09:35.000000000","message":"why not tripleo_name_healthcheck? to be consistent with the healthcheck actual names. Is this choice deliberate?","commit_id":"505dc92a63292c763b274e8dd02d852bbe0ace8b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"98b33a0203a741336ce6d4ce057854c11cfde946","unresolved":false,"context_lines":[{"line_number":195,"context_line":"[Service]"},{"line_number":196,"context_line":"Type\u003doneshot"},{"line_number":197,"context_line":"ExecStart\u003d/usr/bin/podman exec %(name)s %(test)s"},{"line_number":198,"context_line":"SyslogIdentifier\u003dhealthcheck_%(name)s"},{"line_number":199,"context_line":"[Install]"},{"line_number":200,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":201,"context_line":"\"\"\" % s_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a1833baa","line":198,"in_reply_to":"3fa7e38b_f905747a","updated":"2019-12-18 13:17:56.000000000","message":"Yes, deliberate name choice.\n\nThe whole point is to avoid adding bad SELinux policies, and this Identifier will be used within rsyslog to expose a dedicated logfile to collectd container.\nIn order to do that, a third change is proposed:\nhttps://review.opendev.org/699226\n\nIt uses \"startswith\" in order to filter the relevant entries. I chose that one over regexp for:\n- readability\n- maintenance\n- performances","commit_id":"505dc92a63292c763b274e8dd02d852bbe0ace8b"}]}