)]}'
{"paunch/runner.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"644e417a12d1b7b0169f8e134e4a0a6ec2cd4688","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            self.log.error(\u0027Error removing container \u0027"},{"line_number":291,"context_line":"                           \u0027gracefully: %s\u0027 % container)"},{"line_number":292,"context_line":"            self.log.error(cmd_stderr)"},{"line_number":293,"context_line":"            cmd \u003d [self.cont_cmd, \u0027rm\u0027, \u0027-f\u0027, container]"},{"line_number":294,"context_line":"            cmd_stdout, cmd_stderr, returncode \u003d self.execute(cmd, self.log)"},{"line_number":295,"context_line":"            if returncode !\u003d 0:"},{"line_number":296,"context_line":"                self.log.error(\u0027Error removing container: %s\u0027 % container)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_4cbc2e69","line":293,"range":{"start_line":293,"start_character":12,"end_line":293,"end_character":56},"updated":"2020-02-24 10:02:09.000000000","message":"Though this is a backport\nrm -f won\u0027t clean storage at all times.. I think we should do rm --storage here.\n\nNot sure why the plan to backport https://github.com/containers/libpod/pull/4493/commits/25cc43c376c5ddfa70a6009526f8f03b5235c2c6 to podman 1.4.x was abandoned..","commit_id":"6dfd2d07d32abd078f6cf1590d99af71da98398c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b8dd1b093991cbff84813b1b8ff57cdb0f56abba","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            self.log.error(\u0027Error removing container \u0027"},{"line_number":291,"context_line":"                           \u0027gracefully: %s\u0027 % container)"},{"line_number":292,"context_line":"            self.log.error(cmd_stderr)"},{"line_number":293,"context_line":"            cmd \u003d [self.cont_cmd, \u0027rm\u0027, \u0027-f\u0027, container]"},{"line_number":294,"context_line":"            cmd_stdout, cmd_stderr, returncode \u003d self.execute(cmd, self.log)"},{"line_number":295,"context_line":"            if returncode !\u003d 0:"},{"line_number":296,"context_line":"                self.log.error(\u0027Error removing container: %s\u0027 % container)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_cc7c9eb7","line":293,"range":{"start_line":293,"start_character":12,"end_line":293,"end_character":56},"in_reply_to":"1fa4df85_4cbc2e69","updated":"2020-02-24 10:04:31.000000000","message":"rm --storage is another case for issue, please propose it in follow up. This patch is only to restore the original behavior for rm action to never fail (via doing stop \u0026 rm || rm -f). If we mess it with --storage action, that becomes too tricky to handle via a single change/backports/reverts.","commit_id":"6dfd2d07d32abd078f6cf1590d99af71da98398c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"64ffb109063df4d5a2f42023ecf107e831769b62","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            self.log.error(\u0027Error removing container \u0027"},{"line_number":291,"context_line":"                           \u0027gracefully: %s\u0027 % container)"},{"line_number":292,"context_line":"            self.log.error(cmd_stderr)"},{"line_number":293,"context_line":"            cmd \u003d [self.cont_cmd, \u0027rm\u0027, \u0027-f\u0027, container]"},{"line_number":294,"context_line":"            cmd_stdout, cmd_stderr, returncode \u003d self.execute(cmd, self.log)"},{"line_number":295,"context_line":"            if returncode !\u003d 0:"},{"line_number":296,"context_line":"                self.log.error(\u0027Error removing container: %s\u0027 % container)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_cc033e0f","line":293,"range":{"start_line":293,"start_character":12,"end_line":293,"end_character":56},"in_reply_to":"1fa4df85_cc7c9eb7","updated":"2020-02-24 10:12:00.000000000","message":"\u003e If we mess with --storage action\n\nNot sure I understand what it means. AFAIK, rm --storage only removes left behind storage for a container and not mess with container storage as a whole (it\u0027s been suggested by podman team before all the podman bug fixes in 1.4.x and 1.6.\n\nNo, I\u0027m not asking to modify this backport. Just frustrated that this is still a mess.","commit_id":"6dfd2d07d32abd078f6cf1590d99af71da98398c"}]}