)]}'
{"id":"openstack%2Fpaunch~711432","triplet_id":"openstack%2Fpaunch~stable%2Fqueens~I3c6d0670e11d035287d12f4207489a13e0891943","project":"openstack/paunch","branch":"stable/queens","hashtags":[],"change_id":"I3c6d0670e11d035287d12f4207489a13e0891943","subject":"Cleanup containers in the same loop as they are created","status":"MERGED","created":"2020-03-05 10:59:54.000000000","updated":"2020-09-17 20:27:04.000000000","submitted":"2020-03-23 18:34:09.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"711432-1584988449490-795c03e7","meta_rev_id":"1de71d7458ae8b51938412bf5c7a257a8ea8571f","_number":711432,"virtual_id_number":711432,"owner":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-23 18:34:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-05 17:09:35.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-19 09:51:14.000000000","_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"disliked":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":-1,"date":"2020-03-06 06:31:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"value":2,"date":"2020-03-23 13:10:29.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"value":1,"date":"2020-03-23 13:10:29.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-05 17:09:35.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-06 06:31:19.000000000","updated_by":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"reviewer":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"state":"REVIEWER"},{"updated":"2020-03-23 13:10:29.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-03-23 18:34:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c8fd603a46fef6886f4c2a6a605a824bb255f7c3","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-05 10:59:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7fa1351623f6df2b8dccabbc198c981be319eb7c","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-05 11:01:01.000000000","message":"Patch Set 1: Workflow-1\n\nmaster 1st","accounts_in_message":[],"_revision_number":1},{"id":"99585c73ecf899f246485943f20fc1b2adc5453a","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-05 11:05:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"90dbb62b7ba4f249673204e09f31c1d06c0c67ae","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-05 11:05:28.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"090b16bc5f1ef4a891ae05791134d0e6553228d7","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-03-05 11:28:33.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/12294ac575a4488dad7c2d9e7bdc6ebb : FAILURE in 21m 29s","accounts_in_message":[],"_revision_number":2},{"id":"b864f07178c3b881e7deb9e3f4a4f65351bd5b7b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 11:53:36.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/7454432374ff487ab1ad81d8af74470a : FAILURE in 26m 10s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/fd4b38ba067f484f8638c3634c906009 : FAILURE in 36m 14s (non-voting)\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/80de66e88cbc4c6991d3622ce2a7a4cc : SUCCESS in 4m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/177a9aba23a94cc39b31f7c36eb8a805 : SUCCESS in 3m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8a65d6a1a79a429392344aba55a938e5 : FAILURE in 4m 36s","accounts_in_message":[],"_revision_number":2},{"id":"4fad4ba6293c692952f7cf90cf5ef48aff825fb4","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-05 15:01:12.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"18f80eff6e19accbc2df716bf9e5cc4bc62932c3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-03-05 17:09:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/05898a30d9104ed89d049e79c687c3a7 : SUCCESS in 2h 06m 18s","accounts_in_message":[],"_revision_number":3},{"id":"36beac398f03a25504519ef0056116d4163d967a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 18:12:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/8b62e27d924e4bf897b03663d0468877 : SUCCESS in 2h 30m 01s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/c5f4c9c8d692480d9e0d1277e4c4afef : FAILURE in 1h 49m 54s (non-voting)\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/bbf1e8ab34a5433da3ab4a26bbaa749d : SUCCESS in 4m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cb7da7b528dd4468ba9ddf5d0bea5953 : SUCCESS in 2m 57s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a1357fe09fbb401aab8efb22d96d3789 : SUCCESS in 4m 13s","accounts_in_message":[],"_revision_number":3},{"id":"a5074518d3b723033d50afac80d492faaf17e7f2","author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"date":"2020-03-06 06:31:19.000000000","message":"Patch Set 3: Code-Review-1\n\nJust wondering why there isn\u0027t a rocky patch ?","accounts_in_message":[],"_revision_number":3},{"id":"8c018023c8b7330b50e61fba58220cf8f396c2e4","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-09 12:28:02.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"67b10c0b37e34ad505f0a870bc5df96ecbefc3b3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-03-09 13:03:44.000000000","message":"Patch Set 3:\n\nRocky is EOL downstream, unless there is some interest we can still backport it.","accounts_in_message":[],"_revision_number":3},{"id":"7fbe57b617563b7960291ffd8acb5854ca24bcb1","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-09 13:03:54.000000000","message":"Patch Set 3:\n\nRocky is no longer taking backports","accounts_in_message":[],"_revision_number":3},{"id":"cc56d4f2b12f0d2f2ff484ebe35d4ee99a9b4bc3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-03-09 14:32:11.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/5b11f3cd98054674bdbbac39b438120b : SUCCESS in 2h 02m 45s","accounts_in_message":[],"_revision_number":3},{"id":"49ce6011c0fbf5c1a4345364b28f795aaa83ebac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-09 14:55:20.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/ae23e6f693b54f25beaa0de52aec53cf : SUCCESS in 2h 24m 22s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/81b4f6f015954018b16563b6e215864e : SUCCESS in 2h 25m 44s (non-voting)\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/9af64be012f74e0c919c22f297af1dec : SUCCESS in 3m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84826cfbae25499782f69f3cad9da132 : SUCCESS in 4m 09s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6c3e66c0194043658e217c730c50588b : SUCCESS in 3m 25s","accounts_in_message":[],"_revision_number":3},{"id":"510600babaea58856829fc7d5329f056b9a13dbc","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-19 09:51:14.000000000","message":"Patch Set 3:\n\n@sofer, mind removing -1 please?","accounts_in_message":[],"_revision_number":3},{"id":"6cb91782830c1aae22c52a00bc937e1f206f4561","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-03-23 13:10:29.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"1c15d613e41303bb059d3391e84c8e431c1c24c1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 13:10:41.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"3622206ef6d2c4311cd19a81b45652e7721cff61","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 18:34:09.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/c1c07a6249b048248abf8921e0eb49ad : SUCCESS in 2h 20m 19s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/673d2451f4a740328719e1ccaded5ce1 : SUCCESS in 3m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a672ed03ab5e4820a5c6cb2c8004c51d : SUCCESS in 3m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/85dbf1ca03f94f9fbec2d1da50f3a1e0 : SUCCESS in 3m 22s","accounts_in_message":[],"_revision_number":3},{"id":"da95d7bf46b98c3951cf09e810d63c813aa3af30","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 18:34:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"1de71d7458ae8b51938412bf5c7a257a8ea8571f","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-09-17 20:27:04.000000000","message":"Patch Set 3:\n\nyou should have had rocky patch because it makes backporting from train/stein back to queens basically a one-off","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1031491ec689f3f965bd189f4d333bcb94ac27fa","revisions":{"8c4fc67d4fdade26b2d08f17249a9dac2b0540dd":{"kind":"REWORK","_number":1,"created":"2020-03-05 10:59:54.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/32/711432/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/paunch","ref":"refs/changes/32/711432/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/paunch refs/changes/32/711432/1"}}},"commit":{"parents":[{"commit":"5fa3028d11f34c69cf1a428b193e1361f72669a6","subject":"builder: include environment when running an exec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/5fa3028d11f34c69cf1a428b193e1361f72669a6"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2020-02-12 15:21:38.000000000","tz":-300},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-05 10:59:43.000000000","tz":60},"subject":"Cleanup containers in the same loop as they are created","message":"Cleanup containers in the same loop as they are created\n\nSplit delete_missing_and_updated() into 2 methods:\n\n  * delete_missing(), that will remove all containers installed on the\n    host but missing from the given config. This runs outside of the\n    loop, once.\n  * delete_updated(), that will remove a container installed on the host\n    (if present), that is part of the config, if config_data changed or\n    didn\u0027t exist. It runs within the create loop, so the downtime\n    between a container removal and creation should be shorter than\n    before.\n  * make delete_missing(), delete_updated() and rename_containers()\n    returning True, if any container has been touched by either. Use\n    that flag in order to keep the container_names contents always\n    actual.\n  * in order to make that cached container_names working and saving off\n    extra podman ps/inspect calls, rework it to return a list instead\n    of an iterator. There is no huge lists of containers, iterators buy\n    us nothing here, while podman CLI calls are the more expensive\n    thing and we optimize the latter instead.\n\n(cherry picked from commit eb3d3b75bb8bf300fb52390610a6a53ddbfaa48e)\nCo-Authored-By: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\nChange-Id: I3c6d0670e11d035287d12f4207489a13e0891943\nCloses-Bug: #1862954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/8c4fc67d4fdade26b2d08f17249a9dac2b0540dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/8c4fc67d4fdade26b2d08f17249a9dac2b0540dd"}]},"branch":"refs/heads/stable/queens"},"9a9a8e27b1a73fd2531a7a348799a404690979c6":{"kind":"REWORK","_number":2,"created":"2020-03-05 11:05:14.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/32/711432/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/paunch","ref":"refs/changes/32/711432/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/paunch refs/changes/32/711432/2"}}},"commit":{"parents":[{"commit":"5fa3028d11f34c69cf1a428b193e1361f72669a6","subject":"builder: include environment when running an exec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/5fa3028d11f34c69cf1a428b193e1361f72669a6"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2020-02-12 15:21:38.000000000","tz":-300},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-05 11:05:06.000000000","tz":60},"subject":"Cleanup containers in the same loop as they are created","message":"Cleanup containers in the same loop as they are created\n\nSplit delete_missing_and_updated() into 2 methods:\n\n  * delete_missing(), that will remove all containers installed on the\n    host but missing from the given config. This runs outside of the\n    loop, once.\n  * delete_updated(), that will remove a container installed on the host\n    (if present), that is part of the config, if config_data changed or\n    didn\u0027t exist. It runs within the create loop, so the downtime\n    between a container removal and creation should be shorter than\n    before.\n  * make delete_missing(), delete_updated() and rename_containers()\n    returning True, if any container has been touched by either. Use\n    that flag in order to keep the container_names contents always\n    actual.\n  * in order to make that cached container_names working and saving off\n    extra podman ps/inspect calls, rework it to return a list instead\n    of an iterator. There is no huge lists of containers, iterators buy\n    us nothing here, while podman CLI calls are the more expensive\n    thing and we optimize the latter instead.\n\n(cherry picked from commit eb3d3b75bb8bf300fb52390610a6a53ddbfaa48e)\nCo-Authored-By: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\nChange-Id: I3c6d0670e11d035287d12f4207489a13e0891943\nCloses-Bug: #1862954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/9a9a8e27b1a73fd2531a7a348799a404690979c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/9a9a8e27b1a73fd2531a7a348799a404690979c6"}]},"branch":"refs/heads/stable/queens"},"1031491ec689f3f965bd189f4d333bcb94ac27fa":{"kind":"REWORK","_number":3,"created":"2020-03-05 15:01:12.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/32/711432/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/paunch","ref":"refs/changes/32/711432/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/paunch refs/changes/32/711432/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/paunch refs/changes/32/711432/3"}}},"commit":{"parents":[{"commit":"5fa3028d11f34c69cf1a428b193e1361f72669a6","subject":"builder: include environment when running an exec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/5fa3028d11f34c69cf1a428b193e1361f72669a6"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2020-02-12 15:21:38.000000000","tz":-300},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-05 15:00:55.000000000","tz":60},"subject":"Cleanup containers in the same loop as they are created","message":"Cleanup containers in the same loop as they are created\n\nSplit delete_missing_and_updated() into 2 methods:\n\n  * delete_missing(), that will remove all containers installed on the\n    host but missing from the given config. This runs outside of the\n    loop, once.\n  * delete_updated(), that will remove a container installed on the host\n    (if present), that is part of the config, if config_data changed or\n    didn\u0027t exist. It runs within the create loop, so the downtime\n    between a container removal and creation should be shorter than\n    before.\n  * make delete_missing(), delete_updated() and rename_containers()\n    returning True, if any container has been touched by either. Use\n    that flag in order to keep the container_names contents always\n    actual.\n  * in order to make that cached container_names working and saving off\n    extra podman ps/inspect calls, rework it to return a list instead\n    of an iterator. There is no huge lists of containers, iterators buy\n    us nothing here, while podman CLI calls are the more expensive\n    thing and we optimize the latter instead.\n\n(cherry picked from commit eb3d3b75bb8bf300fb52390610a6a53ddbfaa48e)\nCo-Authored-By: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\nChange-Id: I3c6d0670e11d035287d12f4207489a13e0891943\nCloses-Bug: #1862954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/1031491ec689f3f965bd189f4d333bcb94ac27fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/1031491ec689f3f965bd189f4d333bcb94ac27fa"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}