)]}'
{"id":"openstack%2Fpaunch~762563","triplet_id":"openstack%2Fpaunch~stable%2Fussuri~I8b1fbbb7499a69e7a131fd8650c6f50fb4ab978e","project":"openstack/paunch","branch":"stable/ussuri","topic":"ussuri","hashtags":[],"change_id":"I8b1fbbb7499a69e7a131fd8650c6f50fb4ab978e","subject":"Fix inspect images calls to not use the index format keyword","status":"MERGED","created":"2020-11-12 18:23:07.000000000","updated":"2020-11-13 04:22:13.000000000","submitted":"2020-11-13 04:18:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"762563-1605241121983-e490bc4f","meta_rev_id":"6d62ad72ad865e8b3ac366bfc8f055df28084e90","_number":762563,"virtual_id_number":762563,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-13 04:18:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-11-12 22:34:48.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-12 18:59:54.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2020-11-12 22:51:04.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-12 18:59:54.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-11-12 22:34:48.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-12 22:51:04.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-11-13 04:18:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d6ebde8faa64d1cd347a0d08d2bede401b1177f9","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2020-11-12 18:23:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"491a507a9ddc1f5174bdc10d8d4ff9bd6dfb3ba0","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-11-12 18:59:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9c8475ae617e1943da77dba0551eaafe204c2742","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2020-11-12 19:03:14.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit 7e496911451b5d6fca9766fe1e294c7e5e5523ff","accounts_in_message":[],"_revision_number":1},{"id":"b04762548c2160bcfaaac144a48bc216603b6787","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 22:09:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/95b8ec42491d402982e1ee083e4d95c7 : SUCCESS in 3m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/50aa15df672147a5a2508451f4afea89 : SUCCESS in 3m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/df20e4dab1704780accdf22479e98041 : SUCCESS in 3m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cdebf4f00d2a46d497ba0115c8f2299a : SUCCESS in 3m 57s\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/8dc5e0bc4cd54f0a8c58ecdabcde4341 : SUCCESS in 2h 17m 26s\n- tripleo-ci-centos-8-scenario004-standalone https://zuul.opendev.org/t/openstack/build/14c0e4ffa02845b3bf13b6d62b5e4d77 : SUCCESS in 1h 23m 18s","accounts_in_message":[],"_revision_number":1},{"id":"1127024888d348d6a35bb96db9b31e510831afa8","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-11-12 22:34:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/f11106e2aba2483fae59fde2b759d746 : TIMED_OUT in 4h 10m 23s","accounts_in_message":[],"_revision_number":1},{"id":"f2a27dab52d4df500ea069e3159718b25cc7f2e8","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-11-12 22:51:04.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b2c5770942268b9b8b8358519c18fce37471ce06","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 22:51:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1b8c8c31e4179ca6d85b796a3bfcf9c0b7cab327","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 04:18:41.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1a348ec7c8b5421cbfcb4865a44d4e27 : SUCCESS in 2m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/59272d4b20e742bbbc2448aaaedbdefb : SUCCESS in 3m 14s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/321dc3fbc0454868a8eaf55408787325 : SUCCESS in 3m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/714af51ba4c84d4abe50d181abbe0b42 : SUCCESS in 3m 41s\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/5d0669b2fda04965b258ce8b38010af5 : SUCCESS in 2h 49m 59s\n- tripleo-ci-centos-8-scenario004-standalone https://zuul.opendev.org/t/openstack/build/a8c8d5db855d42508c32535112b1e5b7 : SUCCESS in 1h 34m 19s","accounts_in_message":[],"_revision_number":1},{"id":"a49ec46118ff12cdae291d055ea567b194f6970d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 04:18:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"667a7be659ed3af3e32eef20c63aa74c95e8bc11","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 04:22:13.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d158c7816fbd430c9eeec7fca48d297c : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"78e49e2862621f28a6c011ae376cad3ad74b81c5","revisions":{"78e49e2862621f28a6c011ae376cad3ad74b81c5":{"kind":"REWORK","_number":1,"created":"2020-11-12 18:23:07.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/63/762563/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/paunch","ref":"refs/changes/63/762563/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/paunch refs/changes/63/762563/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/paunch refs/changes/63/762563/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/paunch refs/changes/63/762563/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/paunch refs/changes/63/762563/1"}}},"commit":{"parents":[{"commit":"5d171180e29531ee7390a5483858075b04c439ab","subject":"[ussuri] Migrate to content provider jobs/templates","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/5d171180e29531ee7390a5483858075b04c439ab"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2020-11-12 18:21:48.000000000","tz":60},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2020-11-12 18:23:05.000000000","tz":60},"subject":"Fix inspect images calls to not use the index format keyword","message":"Fix inspect images calls to not use the index format keyword\n\nVia https://review.opendev.org/#/c/752937/ we added the following code:\n       if container_image:\n            image_id_str \u003d self.runner.inspect(\n                container_image, \"{{index .Id}}\", o_type\u003d\u0027image\u0027)\n            if str(image_id_str).strip() !\u003d inspect_info.get(\u0027Image\u0027):\n                self.log.debug(\"Deleting container (image updated): \"\n                               \"%s\" % container)\n                self.runner.remove_container(container)\n                return True\n\nThis code works fine in docker:\n[root@controller-0 ~]# docker inspect --type image --format \u0027{{index\n.Id}}\u0027 f6ec0f326154\nsha256:f6ec0f326154a80b6844a03c2de2904bbbefea6cdf87acb606ff869ace1a8dd4\n\nBut is problematic in podman (both on 1.6.4 and 2.1.1 versions):\n[root@controller-0 ~]# podman inspect --type image --format \u0027{{index\n.Id}}\u0027\nundercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp16-openstack-cinder-volume:16.2_20201110.2-hotfixupdate2\nERRO[0000] Error printing inspect output: Template parsing error:\ntemplate: image:1:8: executing \"image\" at \u003c.Id\u003e: can\u0027t evaluate field Id\nin type *entities.ImageInspectReport\n\nThis has the side-effect of restarting all containers at each identical\nredeploy.\n\nWe can just drop the \u0027index\u0027 in the query since it works in both docker\nand podman:\n[root@controller-0 ~]# docker inspect --type image --format \u0027{{.Id}}\u0027\nf6ec0f326154\nsha256:f6ec0f326154a80b6844a03c2de2904bbbefea6cdf87acb606ff869ace1a8dd4\n\n[root@controller-0 ~]# podman inspect --type image --format \u0027{{.Id}}\u0027\n5093412f3a08\n\nChange-Id: I8b1fbbb7499a69e7a131fd8650c6f50fb4ab978e\nCloses-Bug: #1904043\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/78e49e2862621f28a6c011ae376cad3ad74b81c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/paunch/commit/78e49e2862621f28a6c011ae376cad3ad74b81c5"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
