)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ee277efaf50daaf19d4052cd69e286f8c8d616dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6cfb721a_0dd9abf0","updated":"2021-11-22 15:15:11.000000000","message":"I\u0027ll let james merge","commit_id":"200d4dae2acab95fef17e81b539966ab8c0f6868"}],"paunch/builder/podman.py":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"471d4972e4a31234d3cdda50e1ee6152e2689afa","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            # let the container engine to figure out what CPUs are online."},{"line_number":99,"context_line":"            # https://bugs.launchpad.net/tripleo/+bug/1868135"},{"line_number":100,"context_line":"            # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1813091"},{"line_number":101,"context_line":"            cmd.append(\u0027--cpuset-cpus\u003d%s\u0027 % cconfig[\u0027cpuset_cpus\u0027])"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            with open(\u0027/proc/cmdline\u0027) as cmdline:"},{"line_number":104,"context_line":"                if \u0027isolcpus\u0027 in cmdline.read():"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4e8655d_e420991a","line":101,"updated":"2021-11-17 21:42:14.000000000","message":"this change doesn\u0027t mean that ContainerCpusetCpus was not provided. It just means that it\u0027s set to the default value.\n\nAre there scenarios where someone would have set ContainerCpusetCpus:all?","commit_id":"200d4dae2acab95fef17e81b539966ab8c0f6868"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"82286e49d301c433fc891b862baea34e56fe91be","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            # let the container engine to figure out what CPUs are online."},{"line_number":99,"context_line":"            # https://bugs.launchpad.net/tripleo/+bug/1868135"},{"line_number":100,"context_line":"            # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1813091"},{"line_number":101,"context_line":"            cmd.append(\u0027--cpuset-cpus\u003d%s\u0027 % cconfig[\u0027cpuset_cpus\u0027])"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            with open(\u0027/proc/cmdline\u0027) as cmdline:"},{"line_number":104,"context_line":"                if \u0027isolcpus\u0027 in cmdline.read():"}],"source_content_type":"text/x-python","patch_set":1,"id":"b543ff87_ab191720","line":101,"in_reply_to":"e4e8655d_e420991a","updated":"2021-11-18 02:59:54.000000000","message":"Not sure I understand the question.\n\nContainerCpusetCpus is a role specific parameter[1] with a default \u0027all\u0027. So \u0027not provided for a role\u0027 means, it\u0027s not provided in {{role.name}}Parameters and would use the default value \u0027all\u0027 for that role (nova_libvirt container).\n\nThe current issue is when used for a role, it overrides KernealArgs (isolcpus) for remaining roles and uses all cpus for nova_libvirt container. For example for the below case it would use \u0027all\u0027 cpus for Compute1 nova_libvirt container\n\n Compute1Parameters:\n    KernelArgs: \"isolcpus\u003d2-21,24-43,45-65,67-87\"\n\n  Compute2Parameters:\n    ContainerCpusetCpus: \"0,22,44,66\"\n\nI don\u0027t think there would be instances where KernelArgs/ContainerCpusetCpus used together for a role. If ContainerCpusetCpus: \u0027all\u0027 is used without KernelArgs(isolcpus) for a role it would not append  --cpuset-cpus, that would ensure it would use all cpus. If both KernelArgs(isolcpus) and ContainerCpusetCpus: \u0027all\u0027 are used for some reason, it would only use allowed ones (filtered by isolcpus).\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/nova/nova-libvirt-container-puppet.yaml#L262","commit_id":"200d4dae2acab95fef17e81b539966ab8c0f6868"}]}