)]}'
{"tools/integration.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48f0a4b1cdbf77874605c07190c00d7605dd3e15","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# NOTE(dhellmann): This logic is copied from apache_site_config_for"},{"line_number":106,"context_line":"# devstack/lib/apache with non-Ubuntu OSes left out because we don\u0027t"},{"line_number":107,"context_line":"# run this integration test anywhere else for now."},{"line_number":108,"context_line":"apache_version\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":109,"context_line":"if [[ \"$apache_version\" \u003d~ ^2\\.2\\. ]]"},{"line_number":110,"context_line":"then"},{"line_number":111,"context_line":"    # Ubuntu 12.04 - Apache 2.2"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_6b743636","line":108,"updated":"2014-06-25 19:46:24.000000000","message":"nit: sudo is not needed","commit_id":"21dbee64fa4aa7f1d23d5a41d75662ed6a865f64"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"af439680615798eb11162abbd76936646f4d96ed","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# NOTE(dhellmann): This logic is copied from apache_site_config_for"},{"line_number":106,"context_line":"# devstack/lib/apache with non-Ubuntu OSes left out because we don\u0027t"},{"line_number":107,"context_line":"# run this integration test anywhere else for now."},{"line_number":108,"context_line":"apache_version\u003d$(sudo /usr/sbin/apache2ctl -v | awk \u0027/Server version/ {print $3}\u0027 | cut -f2 -d/)"},{"line_number":109,"context_line":"if [[ \"$apache_version\" \u003d~ ^2\\.2\\. ]]"},{"line_number":110,"context_line":"then"},{"line_number":111,"context_line":"    # Ubuntu 12.04 - Apache 2.2"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_01b8f373","line":108,"in_reply_to":"1ae5cdf2_6b743636","updated":"2014-06-25 20:44:43.000000000","message":"I copied this from devstack, but I\u0027ll remove that.","commit_id":"21dbee64fa4aa7f1d23d5a41d75662ed6a865f64"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48f0a4b1cdbf77874605c07190c00d7605dd3e15","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Ubuntu 14.04 - Apache 2.4"},{"line_number":115,"context_line":"    apache_conf\u003d/etc/apache2/sites-available/pypi.conf"},{"line_number":116,"context_line":"fi"},{"line_number":117,"context_line":"sudo mv $tmpdir/pypi.conf $apache_conf"},{"line_number":118,"context_line":"sudo chown root:root $apache_conf"},{"line_number":119,"context_line":"sudo a2ensite pypi"},{"line_number":120,"context_line":"sudo service apache2 reload"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_8ba6e2a9","line":117,"updated":"2014-06-25 19:46:24.000000000","message":"we could also avoid the logic entirely by mv to /etc/apache2/sites-enabled/ instead of using a2ensite","commit_id":"21dbee64fa4aa7f1d23d5a41d75662ed6a865f64"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"af439680615798eb11162abbd76936646f4d96ed","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # Ubuntu 14.04 - Apache 2.4"},{"line_number":115,"context_line":"    apache_conf\u003d/etc/apache2/sites-available/pypi.conf"},{"line_number":116,"context_line":"fi"},{"line_number":117,"context_line":"sudo mv $tmpdir/pypi.conf $apache_conf"},{"line_number":118,"context_line":"sudo chown root:root $apache_conf"},{"line_number":119,"context_line":"sudo a2ensite pypi"},{"line_number":120,"context_line":"sudo service apache2 reload"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_a161ff12","line":117,"in_reply_to":"1ae5cdf2_8ba6e2a9","updated":"2014-06-25 20:44:43.000000000","message":"This feels slightly less likely to bite us with upgrade changes in the future, since it at least uses the apache command to activate the site, even though we have to know an implementation detail about the file name rules.","commit_id":"21dbee64fa4aa7f1d23d5a41d75662ed6a865f64"}]}