)]}'
{"pbr/packaging.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7ada49df6b118a627048537a42b02dc6ba7254c2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    return result"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _get_revno_and_last_tag():"},{"line_number":89,"context_line":"    \"\"\"Return the commit data about the most recent tag."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    We use git-describe to find this out, but if there are no"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_90f3e307","line":88,"updated":"2014-12-04 21:46:49.000000000","message":"It looks like you dropped the git_dir argument here, and in several of the following functions. Why?","commit_id":"0ca2aa51f73e3a7ece54174513dd8efbad06ddc8"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"3896cb1648910220a2ff36d25b4d14a324df1fad","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    return result"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _get_revno_and_last_tag():"},{"line_number":89,"context_line":"    \"\"\"Return the commit data about the most recent tag."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    We use git-describe to find this out, but if there are no"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f002670a","line":88,"in_reply_to":"5a890539_90f3e307","updated":"2014-12-04 22:14:57.000000000","message":"It looks like this is done in the iter_log_oneline() function now; line165 of pbr/git.py. Several other functions appear to use the same pattern.\n\nI\u0027m fairly new to oslo code, but that does seem to be somewhat confusing for anyone simply reading this file.","commit_id":"0ca2aa51f73e3a7ece54174513dd8efbad06ddc8"}]}