)]}'
{"pbr/tests/test_setup.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"80308dcfa0532d67404541d98ef5bb19945dada7","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def test_parse_requirements_with_versioned_ssh_egg_url(self):"},{"line_number":352,"context_line":"        with open(self.tmp_file, \u0027w\u0027) as fh:"},{"line_number":353,"context_line":"            fh.write(\"git+ssh://foo.com/zipball#egg\u003dbar-1.2.4\")"},{"line_number":354,"context_line":"        self.assertEqual([\u0027bar\u003e\u003d1.2.4\u0027],"},{"line_number":355,"context_line":"                         packaging.parse_requirements([self.tmp_file]))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_parse_requirements_with_git_https_egg_url(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ea8798d5","line":354,"updated":"2015-06-29 07:19:51.000000000","message":"these tests seem like the give reasonable coverage, but would likely be a lot more clear that they only vary in data if you used testscenarios for them. There are some examples in tree.","commit_id":"da7691413c750f7bd1220055ff1294f3079f4ee7"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9fc881043915c5c8d1337dc9069797c4056d80d8","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def setUp(self):"},{"line_number":352,"context_line":"        super(ParseRequirementsTestScenarios, self).setUp()"},{"line_number":353,"context_line":"        (fd, self.tmp_file) \u003d tempfile.mkstemp(prefix\u003d\u0027openstack\u0027,"},{"line_number":354,"context_line":"                                               suffix\u003d\u0027.setup\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def test_parse_requirements(self):"},{"line_number":357,"context_line":"        req_string \u003d self.url"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_a2158d40","line":354,"updated":"2015-11-03 03:19:52.000000000","message":"With only one test, using setUp isn\u0027t needed and harms readabilityIMO.\n\nlso using mkstemp is quite odd - NamedTemporaryFile would be better.","commit_id":"03b31c1069cbf1d3e1f190cfd59df7f9e2dcad8a"}]}