)]}'
{"pbr/pbr_json.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a3970fee6c54c7a74bd83562060e58195ac67f0a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def write_pbr_json(cmd, basename, filename):"},{"line_number":23,"context_line":"    if not cmd.distribution.pbr:"},{"line_number":24,"context_line":"        return"},{"line_number":25,"context_line":"    git_dir \u003d git._run_git_functions()"},{"line_number":26,"context_line":"    if not git_dir:"},{"line_number":27,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b1369de5","line":24,"updated":"2015-08-28 02:56:57.000000000","message":"I\u0027m not sure what the difficult with tests is - the integration tests show the way: make a venv, write a trivial package on disk, python setup.py egg_info it, and inspect the result.\n\n*that said*, I\u0027m happy for this to land as-is with tests as followup, as its clearly still functional and fixes a very embarrasing bug.","commit_id":"8047f2feafeead5f4913f9ab1d7d2c6d0ccf79e0"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"ae0b31e2168f34d58f818fe8256cf08eddeada5a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def write_pbr_json(cmd, basename, filename):"},{"line_number":23,"context_line":"    if not cmd.distribution.pbr:"},{"line_number":24,"context_line":"        return"},{"line_number":25,"context_line":"    git_dir \u003d git._run_git_functions()"},{"line_number":26,"context_line":"    if not git_dir:"},{"line_number":27,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_0f1e195f","line":24,"in_reply_to":"da20952f_277d6be7","updated":"2015-08-28 17:30:21.000000000","message":"There\u0027s potentially also setup(pbr\u003dTrue) in this matrix, and whether to ignore or error in this case.","commit_id":"8047f2feafeead5f4913f9ab1d7d2c6d0ccf79e0"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"ecbb2b643a3b9407eb72a853eaa8e4bb0376d70f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def write_pbr_json(cmd, basename, filename):"},{"line_number":23,"context_line":"    if not cmd.distribution.pbr:"},{"line_number":24,"context_line":"        return"},{"line_number":25,"context_line":"    git_dir \u003d git._run_git_functions()"},{"line_number":26,"context_line":"    if not git_dir:"},{"line_number":27,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_277d6be7","line":24,"in_reply_to":"da20952f_b1369de5","updated":"2015-08-28 05:43:54.000000000","message":"The main thing I\u0027m tripped up on here is how to stick a package with git into the tree gracefully as this explicitly requires that you\u0027re working in a package with a git tree.\n\n--\n\nI\u0027d like to get tests to look like this, all with pbr already installed.\n- setup(...) - Test doesn\u0027t run  \n- setup(setup_requires\u003d[\u0027pbr\u0027]) - Test doesn\u0027t run  \n- setup(setup_requires\u003d[\u0027pbr\u0027],pbr\u003dTrue) - Test that it does runs","commit_id":"8047f2feafeead5f4913f9ab1d7d2c6d0ccf79e0"}]}
