)]}'
{"pbr/util.py":[{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"b1c1e573e6c553ba1957e1fa551be6fff33a0970","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        config[section] \u003d dict(parser.items(section))"},{"line_number":213,"context_line":"        for key in config[section]:"},{"line_number":214,"context_line":"            value \u003d config[section][key].split(\u0027\\n\u0027)"},{"line_number":215,"context_line":"            value \u003d [re_comment.match(v).group(1) for v in value]"},{"line_number":216,"context_line":"            config[section][key] \u003d \u0027\\n\u0027.join(value)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # Run setup_hooks, if configured"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_bc688089","line":215,"range":{"start_line":215,"start_character":21,"end_line":215,"end_character":31},"updated":"2015-09-11 07:18:43.000000000","message":"It\u0027s a small thing and I wouldn\u0027t let it block this change from landing, but I have a preference for avoiding comprehensions wherever possible. In this case, I believe that a simple:\n\nvalue \u003d re.sub(\u0027#.*$\u0027, \u0027\u0027, value)\n\nis probably all that\u0027s needed here (this matches what was done at https://review.openstack.org/#/c/216030/2/pbr/packaging.py,cm)\n\nHowever, this certainly works, and it fixes the current breakage, and on that basis I\u0027m happy to give this a +1 - if there are no other reasons to edit this, I\u0027m happy to see tidying up done in a later patch.","commit_id":"ecc93fb7b87c84478f59146836d7eb237fbd8e35"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8937f89bfd40e6713a78b61edfbb950db40e8285","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            if arg \u003d\u003d \u0027install_requires\u0027:"},{"line_number":339,"context_line":"                # Split install_requires into package,env_marker tuples"},{"line_number":340,"context_line":"                # These will be re-assembled later"},{"line_number":341,"context_line":"                install_requires \u003d []"},{"line_number":342,"context_line":"                requirement_pattern \u003d \u0027(?P\u003cpackage\u003e[^;]*);?(?P\u003cenv_marker\u003e.*)$\u0027"},{"line_number":343,"context_line":"                for requirement in in_cfg_value:"},{"line_number":344,"context_line":"                    m \u003d re.match(requirement_pattern, requirement)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_fcd118fc","line":341,"updated":"2015-09-11 07:28:14.000000000","message":"I think the fix should be down here - the \u003cenv_marker\u003e regex is just too wide.\n\ne.g. rather than .* it should be ...  [^#]*)(?:#.*)?$","commit_id":"ecc93fb7b87c84478f59146836d7eb237fbd8e35"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"234c181c58f9690c3072946e7a6def409eda1a14","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    if \u0027extras\u0027 in config:"},{"line_number":397,"context_line":"        extras \u003d config[\u0027extras\u0027]"},{"line_number":398,"context_line":"        for extra in extras:"},{"line_number":399,"context_line":"            requirement_pattern \u003d \u0027(?P\u003cpackage\u003e[^:]*):?(?P\u003cenv_marker\u003e[^#]*?)(?:\\s*#.*)?$\u0027"},{"line_number":400,"context_line":"            extra_requirements \u003d []"},{"line_number":401,"context_line":"            requirements \u003d split_multiline(extras[extra])"},{"line_number":402,"context_line":"            for requirement in requirements:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_59dbed1b","line":399,"updated":"2015-09-14 08:24:23.000000000","message":"I\u0027m curious about the move of this into the loop: its not strictly wrong in a correctness sense, but I\u0027m not sure if the Python compiler optimiser will constant-fold it out.","commit_id":"082cc9058a70490336f5712a4cad623163fa612a"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"1888fdb3fd677e1509195dee1d53b912ee181210","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    if \u0027extras\u0027 in config:"},{"line_number":397,"context_line":"        extras \u003d config[\u0027extras\u0027]"},{"line_number":398,"context_line":"        for extra in extras:"},{"line_number":399,"context_line":"            requirement_pattern \u003d \u0027(?P\u003cpackage\u003e[^:]*):?(?P\u003cenv_marker\u003e[^#]*?)(?:\\s*#.*)?$\u0027"},{"line_number":400,"context_line":"            extra_requirements \u003d []"},{"line_number":401,"context_line":"            requirements \u003d split_multiline(extras[extra])"},{"line_number":402,"context_line":"            for requirement in requirements:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_7974b1fc","line":399,"in_reply_to":"ba15a1d1_59dbed1b","updated":"2015-09-14 08:28:22.000000000","message":"Whoops, that was not intentional.","commit_id":"082cc9058a70490336f5712a4cad623163fa612a"}]}
