)]}'
{"pbr/git.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"84713c0d0baf81364249257c99c2f847fa16c512","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def write_git_changelog(git_dir\u003dNone, dest_dir\u003dos.path.curdir,"},{"line_number":245,"context_line":"                        option_dict\u003dNone, changelog\u003dNone,"},{"line_number":246,"context_line":"                        changelog_extension\u003dNone):"},{"line_number":247,"context_line":"    \"\"\"Write a changelog based on the git changelog.\"\"\""},{"line_number":248,"context_line":"    start \u003d time.time()"},{"line_number":249,"context_line":"    if not option_dict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_4c67114d","line":246,"updated":"2015-10-08 20:44:57.000000000","message":"This doesn\u0027t seem like it\u0027s related to the escaping. Am I misunderstanding?","commit_id":"bbbb29c4e1c6a7c0463ff2a53729f2745b2295bf"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8de11cd8d2c9b9d68ea20777e24c1312fe50ca9d","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def write_git_changelog(git_dir\u003dNone, dest_dir\u003dos.path.curdir,"},{"line_number":245,"context_line":"                        option_dict\u003dNone, changelog\u003dNone,"},{"line_number":246,"context_line":"                        changelog_extension\u003dNone):"},{"line_number":247,"context_line":"    \"\"\"Write a changelog based on the git changelog.\"\"\""},{"line_number":248,"context_line":"    start \u003d time.time()"},{"line_number":249,"context_line":"    if not option_dict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_a204a949","line":246,"in_reply_to":"7a2fa921_4c67114d","updated":"2015-10-08 23:09:33.000000000","message":"Sooo the reason for this one was to not always do rst escaping; due to how this \u0027write_git_changelog\u0027 is called in a few odd places (with a prior changelog, unsure why thats done).\n\nThe reason to use an extension, was because the infra folks didn\u0027t think it made sense to always RST escape all the things, so this was an idea on how to compromise, if the extension is \u0027.rst\u0027 then escape for rst, otherwise leave commit messages alone. \n\nI\u0027m willing to always escape though, but others I don\u0027t think agree :)","commit_id":"bbbb29c4e1c6a7c0463ff2a53729f2745b2295bf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e615a8bdefb57996e8d876d03b21b434f0cda5d2","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def write_git_changelog(git_dir\u003dNone, dest_dir\u003dos.path.curdir,"},{"line_number":245,"context_line":"                        option_dict\u003dNone, changelog\u003dNone,"},{"line_number":246,"context_line":"                        changelog_extension\u003dNone):"},{"line_number":247,"context_line":"    \"\"\"Write a changelog based on the git changelog.\"\"\""},{"line_number":248,"context_line":"    start \u003d time.time()"},{"line_number":249,"context_line":"    if not option_dict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_b8b0c044","line":246,"in_reply_to":"7a2fa921_9998d879","updated":"2016-01-21 13:48:10.000000000","message":"The problem is in sphinx consumption of the ChangeLog, no? Perhaps writing some code in oslo.sphinx to add a thing that can import ChangeLogs and escape them properly and then use that to import the changelog would be a better place to put it? That way the ChangeLog is the ChangeLog - and the sphinxification of it can be located with sphinx code.","commit_id":"bbbb29c4e1c6a7c0463ff2a53729f2745b2295bf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"147123b5c796db188ae62b98e7428d7fab44dd79","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def write_git_changelog(git_dir\u003dNone, dest_dir\u003dos.path.curdir,"},{"line_number":245,"context_line":"                        option_dict\u003dNone, changelog\u003dNone,"},{"line_number":246,"context_line":"                        changelog_extension\u003dNone):"},{"line_number":247,"context_line":"    \"\"\"Write a changelog based on the git changelog.\"\"\""},{"line_number":248,"context_line":"    start \u003d time.time()"},{"line_number":249,"context_line":"    if not option_dict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_9998d879","line":246,"in_reply_to":"7a2fa921_a204a949","updated":"2015-10-09 19:18:41.000000000","message":"OK, that\u0027s not going to do us any good, really, then.\n\npbr writes to ChangeLog, and we have lots of places where we have a file like doc/source/history.rst that just imports ChangeLog. So there\u0027s no extension in the place that needs the RST escaped.\n\nI understand the point, since always escaping all of these characters is going to make the text much less legible. I don\u0027t have a good suggestion for how to work around that.","commit_id":"bbbb29c4e1c6a7c0463ff2a53729f2745b2295bf"}]}