)]}'
{"doc/source/index.rst":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8c9905e08c5bf10ab7cf04d97cebe59fae0e4cde","unresolved":false,"context_lines":[{"line_number":184,"context_line":"pbr requires a distribution to use setuptools.  Your distribution"},{"line_number":185,"context_line":"must include a distutils2-like setup.cfg file, and a minimal setup.py script."},{"line_number":186,"context_line":"It should also include a MANIFEST.in file if you wish to distribute additonal"},{"line_number":187,"context_line":"files with your package."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"A simple setup.cfg sample can be found in pbr\u0027s own setup.cfg"},{"line_number":190,"context_line":"(it uses its own machinery to install itself)::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_143b099e","line":187,"updated":"2015-10-23 18:38:27.000000000","message":"I think we should restructure this - the minimal docs are just muddied by talking about MANIFEST.in - since most projects don\u0027t need it with pbr, we shouldn\u0027t detract from the clarity we can otherwise achieve. Something like..\n\n Usage\n \u003d\u003d\u003d\u003d\u003d\n\n pbr is a setuptools plugin and so to use it you must use setuptools and call \n setuptools.setup(). While the normal setuptools facilities are available, pbr makes it \n possible to express them through static data files.\n\n setup.cfg\n ---------\n\n ... describe setup.cfg usage\n\n ... the files and entry points and so on descriptions\n\n requirements.txt\n ------\n\n .... describe requirements.txt, our support for PEP-426 markers, the\n limitations on urls and the non-support for pip options, and the deprecated\n nature of requirements-pyN.txt\n\n test-requirements.txt\n -------------\n\n ... similar to requirements.txt\n\n MANIFEST.in\n ----\n\n ... describe what we do here (auto populate MANIFEST from git, automatically\n include Authors and ChangeLog and automatically exclude .gitignore and .gitreview).","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36dc2c677b0fcf253e395e23568f646d1510a630","unresolved":false,"context_lines":[{"line_number":184,"context_line":"pbr requires a distribution to use setuptools.  Your distribution"},{"line_number":185,"context_line":"must include a distutils2-like setup.cfg file, and a minimal setup.py script."},{"line_number":186,"context_line":"It should also include a MANIFEST.in file if you wish to distribute additonal"},{"line_number":187,"context_line":"files with your package."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"A simple setup.cfg sample can be found in pbr\u0027s own setup.cfg"},{"line_number":190,"context_line":"(it uses its own machinery to install itself)::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_94acf936","line":187,"in_reply_to":"3a29b11f_143b099e","updated":"2015-10-23 18:59:14.000000000","message":"I only looked into pbr itself for the first time yesterday so I\u0027m not familiar with all of its functionality. Am I correct in thinking that this isn\u0027t currently documented anywhere yet? If so, should I pivot this patch to add what you\u0027ve described above or leave it to you?","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8c9905e08c5bf10ab7cf04d97cebe59fae0e4cde","unresolved":false,"context_lines":[{"line_number":244,"context_line":"A sample MANIFEST.in file should look something like this::"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":" include AUTHORS"},{"line_number":247,"context_line":" include ChangeLog"},{"line_number":248,"context_line":" include LICENSE"},{"line_number":249,"context_line":" include README.rst"},{"line_number":250,"context_line":" include requirements.txt"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_54b5012f","line":247,"updated":"2015-10-23 18:38:27.000000000","message":"These shouldn\u0027t be here (pbr does that automatically)/","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36dc2c677b0fcf253e395e23568f646d1510a630","unresolved":false,"context_lines":[{"line_number":244,"context_line":"A sample MANIFEST.in file should look something like this::"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":" include AUTHORS"},{"line_number":247,"context_line":" include ChangeLog"},{"line_number":248,"context_line":" include LICENSE"},{"line_number":249,"context_line":" include README.rst"},{"line_number":250,"context_line":" include requirements.txt"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_f4ba0d71","line":247,"updated":"2015-10-23 18:59:14.000000000","message":"Yup, this is my point exactly. This isn\u0027t clear and the fact that pbr itself includes a (incorrect, based on below) MANIFEST.in itself really doesn\u0027t help matters:\n\n    https://github.com/openstack-dev/pbr/blob/ae184c0742e672ce41212315029d1e8a83d45fec/MANIFEST.in","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8c9905e08c5bf10ab7cf04d97cebe59fae0e4cde","unresolved":false,"context_lines":[{"line_number":248,"context_line":" include LICENSE"},{"line_number":249,"context_line":" include README.rst"},{"line_number":250,"context_line":" include requirements.txt"},{"line_number":251,"context_line":" include tox.ini"},{"line_number":252,"context_line":" recursive-include doc *"},{"line_number":253,"context_line":" exclude .gitignore"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_1486a965","line":251,"updated":"2015-10-23 18:38:27.000000000","message":"None of these files should be here, since they are in git pbr includes them automatically.","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8c9905e08c5bf10ab7cf04d97cebe59fae0e4cde","unresolved":false,"context_lines":[{"line_number":249,"context_line":" include README.rst"},{"line_number":250,"context_line":" include requirements.txt"},{"line_number":251,"context_line":" include tox.ini"},{"line_number":252,"context_line":" recursive-include doc *"},{"line_number":253,"context_line":" exclude .gitignore"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":" global-exclude *.pyc"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_54e3c133","line":252,"updated":"2015-10-23 18:38:27.000000000","message":"This will pickup sphinx cache files in  doc/build/doctrees and so shouldn\u0027t be here.\n\nIncluding built docs should be:\n recursive-include doc/build/man *\n recursive-include doc/build/html *","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36dc2c677b0fcf253e395e23568f646d1510a630","unresolved":false,"context_lines":[{"line_number":249,"context_line":" include README.rst"},{"line_number":250,"context_line":" include requirements.txt"},{"line_number":251,"context_line":" include tox.ini"},{"line_number":252,"context_line":" recursive-include doc *"},{"line_number":253,"context_line":" exclude .gitignore"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":" global-exclude *.pyc"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_54542120","line":252,"in_reply_to":"3a29b11f_54e3c133","updated":"2015-10-23 18:59:14.000000000","message":"I just duplicated the MANIFEST.in file from pbr, figuring it would be correct :) Good to know though.","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8c9905e08c5bf10ab7cf04d97cebe59fae0e4cde","unresolved":false,"context_lines":[{"line_number":250,"context_line":" include requirements.txt"},{"line_number":251,"context_line":" include tox.ini"},{"line_number":252,"context_line":" recursive-include doc *"},{"line_number":253,"context_line":" exclude .gitignore"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":" global-exclude *.pyc"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_14d46945","line":253,"updated":"2015-10-23 18:38:27.000000000","message":"Automatically done by pbr","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8c9905e08c5bf10ab7cf04d97cebe59fae0e4cde","unresolved":false,"context_lines":[{"line_number":252,"context_line":" recursive-include doc *"},{"line_number":253,"context_line":" exclude .gitignore"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":" global-exclude *.pyc"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Note that the autogenerated AUTHORS and ChangeLog files are included, even"},{"line_number":258,"context_line":"though they don\u0027t technically exist (yet)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a29b11f_d4cd91b8","line":255,"updated":"2015-10-23 18:38:27.000000000","message":"Automatically done by pbr","commit_id":"4a26f3842832c142facef79065514bd0d96a5be0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7c27bdebbe15e8c4d3e729cf1a2492368743bd90","unresolved":false,"context_lines":[{"line_number":23,"context_line":" * **Version**: Manage version number based on git revisions and tags"},{"line_number":24,"context_line":" * **AUTHORS**: Generate AUTHORS file from git log"},{"line_number":25,"context_line":" * **ChangeLog**: Generate ChangeLog from git log"},{"line_number":26,"context_line":" * **MANIFEST.in**: Generate MANIFEST.in from git files and some sensible"},{"line_number":27,"context_line":"   standard files"},{"line_number":28,"context_line":" * **Sphinx Autodoc**: Generate autodoc stub files for your whole module"},{"line_number":29,"context_line":" * **Requirements**: Store your dependencies in a pip requirements file"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_e02c6ead","line":26,"updated":"2015-11-16 20:48:51.000000000","message":"Does it generate this file? I don\u0027t see where it\u0027s doing that.","commit_id":"5e514a17512c109b69fdf0b052a13bfceaa47d20"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3d41f2d556c38012dc3ac9224d288c3712995f87","unresolved":false,"context_lines":[{"line_number":23,"context_line":" * **Version**: Manage version number based on git revisions and tags"},{"line_number":24,"context_line":" * **AUTHORS**: Generate AUTHORS file from git log"},{"line_number":25,"context_line":" * **ChangeLog**: Generate ChangeLog from git log"},{"line_number":26,"context_line":" * **MANIFEST.in**: Generate MANIFEST.in from git files and some sensible"},{"line_number":27,"context_line":"   standard files"},{"line_number":28,"context_line":" * **Sphinx Autodoc**: Generate autodoc stub files for your whole module"},{"line_number":29,"context_line":" * **Requirements**: Store your dependencies in a pip requirements file"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_1eab0776","line":26,"in_reply_to":"ba8a016a_9e7377b1","updated":"2015-11-17 01:39:42.000000000","message":"Ah, yeah, I was definitely making the distinction between those two files, so let\u0027s make sure it\u0027s clear. Since it doesn\u0027t write the file to disk, let\u0027s just say that it automatically adds files to the manifest (no caps).","commit_id":"5e514a17512c109b69fdf0b052a13bfceaa47d20"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b8c70bbcd168ac9d5bfdcfdef93ae4b342d28870","unresolved":false,"context_lines":[{"line_number":23,"context_line":" * **Version**: Manage version number based on git revisions and tags"},{"line_number":24,"context_line":" * **AUTHORS**: Generate AUTHORS file from git log"},{"line_number":25,"context_line":" * **ChangeLog**: Generate ChangeLog from git log"},{"line_number":26,"context_line":" * **MANIFEST.in**: Generate MANIFEST.in from git files and some sensible"},{"line_number":27,"context_line":"   standard files"},{"line_number":28,"context_line":" * **Sphinx Autodoc**: Generate autodoc stub files for your whole module"},{"line_number":29,"context_line":" * **Requirements**: Store your dependencies in a pip requirements file"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_9e7377b1","line":26,"in_reply_to":"ba8a016a_e02c6ead","updated":"2015-11-17 01:26:34.000000000","message":"It does not write it to disk, but it does manipulate the default MANIFEST setuptools uses.\n\nI think this could be tweaked - MANIFEST.in -\u003e MANIFEST and then it would be less liable to be confusing.","commit_id":"5e514a17512c109b69fdf0b052a13bfceaa47d20"}]}