)]}'
{"pbr/git.py":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"34ff439ba179b04b21d48f95fc0874b056140ed6","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_submodules(git_dir):"},{"line_number":98,"context_line":"    submodules \u003d _run_git_command([\u0027submodule\u0027, \u0027status\u0027], git_dir)"},{"line_number":99,"context_line":"    submodules \u003d [s.strip().split(\u0027 \u0027)[1]"},{"line_number":100,"context_line":"                  for s in submodules.split(\u0027\\n\u0027)"},{"line_number":101,"context_line":"                  if s !\u003d \u0027\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_b53e478a","line":98,"updated":"2016-01-05 04:49:12.000000000","message":"Should this recurse?\n\n--recursive","commit_id":"530820917a995e9fd9bb43fa16646d912812be51"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"34ff439ba179b04b21d48f95fc0874b056140ed6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    if git_dir:"},{"line_number":115,"context_line":"        log.info(\"[pbr] In git context, generating filelist from git\")"},{"line_number":116,"context_line":"        file_list \u003d _run_git_command([\u0027ls-files\u0027, \u0027-z\u0027], git_dir)"},{"line_number":117,"context_line":"        file_list +\u003d _run_git_command("},{"line_number":118,"context_line":"            [\u0027submodule\u0027, \u0027foreach\u0027, \u0027--quiet\u0027, \u0027ls-files\u0027, \u0027-z\u0027],"},{"line_number":119,"context_line":"            git_dir"},{"line_number":120,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_557a6b78","line":117,"updated":"2016-01-05 04:49:12.000000000","message":"Inferencing the below means to call $(git submodule foreach --quiet git ls-files -z)\n\nif it looks like:\ngit_root/\ngit_root/file.txt\ngit_root/submod/thing.txt\n\nThis is going to end up as.\n[\u0027file.txt\u0027, \u0027thing.txt\u0027]\n\nThis does not seem right as \u0027git_root/thing.txt\u0027 does not exist","commit_id":"530820917a995e9fd9bb43fa16646d912812be51"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"34ff439ba179b04b21d48f95fc0874b056140ed6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        log.info(\"[pbr] In git context, generating filelist from git\")"},{"line_number":116,"context_line":"        file_list \u003d _run_git_command([\u0027ls-files\u0027, \u0027-z\u0027], git_dir)"},{"line_number":117,"context_line":"        file_list +\u003d _run_git_command("},{"line_number":118,"context_line":"            [\u0027submodule\u0027, \u0027foreach\u0027, \u0027--quiet\u0027, \u0027ls-files\u0027, \u0027-z\u0027],"},{"line_number":119,"context_line":"            git_dir"},{"line_number":120,"context_line":"        )"},{"line_number":121,"context_line":"        # Users can fix utf8 issues locally with a single commit, so we are"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_fa602e03","line":118,"range":{"start_line":118,"start_character":52,"end_line":118,"end_character":57},"updated":"2016-01-05 04:49:12.000000000","message":"My systems git does not like this.\n\n% git submodule status    \n c3c588713233609f5bbbb2d9e7f3fb4a660f3f72 exsub (heads/master)\n\n% git ls-files\n.gitmodules\nexsub\nfile\n\n% git submodule foreach --quiet ls-files -z\n/usr/lib/git-core/git-submodule: line 564: ls-files: command not found\nStopping at \u0027exsub\u0027; script returned non-zero status.\n\n% git --version\ngit version 2.6.4","commit_id":"530820917a995e9fd9bb43fa16646d912812be51"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a79f3a416000b009e0bb19d31a4b537f729d5c83","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_submodules(git_dir):"},{"line_number":98,"context_line":"    submodules \u003d _run_git_command([\u0027submodule\u0027, \u0027status\u0027], git_dir)"},{"line_number":99,"context_line":"    submodules \u003d [s.strip().split(\u0027 \u0027)[1]"},{"line_number":100,"context_line":"                  for s in submodules.split(\u0027\\n\u0027)"},{"line_number":101,"context_line":"                  if s !\u003d \u0027\u0027]"},{"line_number":102,"context_line":"    return submodules"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_a263c219","line":99,"updated":"2016-01-12 18:07:48.000000000","message":"What will this do if the path has a space in it?","commit_id":"0c74b0838f047872dc005acda89400ad3a5d9cb0"}]}