)]}'
{"doc/source/index.rst":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2b4ab3fccd9bdf253a6a6ec005315027c12d0f91","unresolved":false,"context_lines":[{"line_number":261,"context_line":"subdirectory of a virtualenv."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"You can specify where files targeted to `etc` should be installed on their own"},{"line_number":264,"context_line":"by passing the `--sysconfdir` option to the `install` command."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"entry_points"},{"line_number":267,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a57f1b5_806c999d","line":264,"updated":"2016-02-10 04:18:42.000000000","message":"(nit) It feels like this ends up being contradictory to the above.\nIt would be nice if it was re-worked where this logically flows on from it rather than contradicting it.","commit_id":"87fe166c6d327e8369f367537da780b485733766"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"27b8e8826ce5567f01282e630019848a54f8e593","unresolved":false,"context_lines":[{"line_number":261,"context_line":"subdirectory of a virtualenv."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"You can specify where files targeted to `etc` should be installed on their own"},{"line_number":264,"context_line":"by passing the `--sysconfdir` option to the `install` command."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"entry_points"},{"line_number":267,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a57f1b5_88811092","line":264,"in_reply_to":"3a57f1b5_806c999d","updated":"2016-02-10 13:29:48.000000000","message":"Done","commit_id":"87fe166c6d327e8369f367537da780b485733766"}],"pbr/packaging.py":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2b4ab3fccd9bdf253a6a6ec005315027c12d0f91","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Utilities with minimum-depends for use in setup.py"},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from __future__ import unicode_literals"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from distutils.command import install as du_install"},{"line_number":24,"context_line":"from distutils import log"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_53a0b9f4","side":"PARENT","line":21,"updated":"2016-02-10 04:18:42.000000000","message":"Is there a reason for the removal of this?","commit_id":"d19459daa8616dd18fde016c2970ffc41ff4ccdd"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"27b8e8826ce5567f01282e630019848a54f8e593","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Utilities with minimum-depends for use in setup.py"},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from __future__ import unicode_literals"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from distutils.command import install as du_install"},{"line_number":24,"context_line":"from distutils import log"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_2849fc8b","side":"PARENT","line":21,"in_reply_to":"3a57f1b5_53a0b9f4","updated":"2016-02-10 13:29:48.000000000","message":"Yes, user_options must be a str, not unicode.","commit_id":"d19459daa8616dd18fde016c2970ffc41ff4ccdd"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2b4ab3fccd9bdf253a6a6ec005315027c12d0f91","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if self.sysconfdir is not None:"},{"line_number":203,"context_line":"            data_files \u003d []"},{"line_number":204,"context_line":"            for target, sources in self.distribution.data_files:"},{"line_number":205,"context_line":"                if target.startswith(\"etc/\"):"},{"line_number":206,"context_line":"                    target \u003d os.path.join(self.sysconfdir, target[4:])"},{"line_number":207,"context_line":"                data_files.append((target, sources))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_20eda58b","line":204,"updated":"2016-02-10 04:18:42.000000000","message":"I managed to break it here:\n\npython setup.py install --prefix\u003d/tmp/testing/testpackage/dir1 --sysconfdir\u003d//tmp/testing/testpackage/dir2\nrunning install\n[pbr] Writing ChangeLog\n[pbr] Generating ChangeLog\n[pbr] ChangeLog complete (0.0s)\n[pbr] Generating AUTHORS\n[pbr] AUTHORS complete (0.0s)\nTraceback (most recent call last):\n  File \"setup.py\", line 21, in \u003cmodule\u003e\n    pbr\u003dTrue,\n  File \"/usr/lib64/python2.7/distutils/core.py\", line 151, in setup\n    dist.run_commands()\n  File \"/usr/lib64/python2.7/distutils/dist.py\", line 953, in run_commands\n    self.run_command(cmd)\n  File \"/usr/lib64/python2.7/distutils/dist.py\", line 972, in run_command\n    cmd_obj.run()\n  File \"/home/nakato/git/openstack-dev/pbr/ve2/lib/python2.7/site-packages/pbr/packaging.py\", line 204, in run\n    for target, sources in self.distribution.data_files:\nTypeError: \u0027NoneType\u0027 object is not iterable","commit_id":"87fe166c6d327e8369f367537da780b485733766"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"27b8e8826ce5567f01282e630019848a54f8e593","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if self.sysconfdir is not None:"},{"line_number":203,"context_line":"            data_files \u003d []"},{"line_number":204,"context_line":"            for target, sources in self.distribution.data_files:"},{"line_number":205,"context_line":"                if target.startswith(\"etc/\"):"},{"line_number":206,"context_line":"                    target \u003d os.path.join(self.sysconfdir, target[4:])"},{"line_number":207,"context_line":"                data_files.append((target, sources))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_08120063","line":204,"in_reply_to":"3a57f1b5_20eda58b","updated":"2016-02-10 13:29:48.000000000","message":"Done","commit_id":"87fe166c6d327e8369f367537da780b485733766"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2b4ab3fccd9bdf253a6a6ec005315027c12d0f91","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if self.sysconfdir is not None:"},{"line_number":203,"context_line":"            data_files \u003d []"},{"line_number":204,"context_line":"            for target, sources in self.distribution.data_files:"},{"line_number":205,"context_line":"                if target.startswith(\"etc/\"):"},{"line_number":206,"context_line":"                    target \u003d os.path.join(self.sysconfdir, target[4:])"},{"line_number":207,"context_line":"                data_files.append((target, sources))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_b341ed3b","line":205,"updated":"2016-02-10 04:18:42.000000000","message":"This is probably okay, but leaves me wondering if we should instead split config files out of data_files instead of deciding that the leading path is significant.","commit_id":"87fe166c6d327e8369f367537da780b485733766"}],"pbr/tests/testpackage/conf.cfg":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"2b4ab3fccd9bdf253a6a6ec005315027c12d0f91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"hello"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3a57f1b5_73905596","line":1,"updated":"2016-02-10 04:18:42.000000000","message":"While I believe it would be best to not use the testpackage package to test this feature, if used I would prefer if this had something more than hello in it.\n\nMaybe a description of why the file exists?","commit_id":"87fe166c6d327e8369f367537da780b485733766"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"27b8e8826ce5567f01282e630019848a54f8e593","unresolved":false,"context_lines":[{"line_number":1,"context_line":"hello"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3a57f1b5_e341c53a","line":1,"in_reply_to":"3a57f1b5_73905596","updated":"2016-02-10 13:29:48.000000000","message":"Done","commit_id":"87fe166c6d327e8369f367537da780b485733766"}]}
