)]}'
{"pbr/packaging.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9b5f29028783d2d43b3dae9cc424f8ddb8480477","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def generate_script(group, entry_point, name, header, template):"},{"line_number":312,"context_line":"    \"\"\"Generate the script based on the template.\"\"\""},{"line_number":313,"context_line":"    if not entry_point.attrs or len(entry_point.attrs) \u003e 2:"},{"line_number":314,"context_line":"        raise ValueError(\"Script targets must be of the form \""},{"line_number":315,"context_line":"                         \"\u0027func\u0027 or \u0027Class.class_method\u0027.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_43357bd8","line":312,"updated":"2016-02-15 22:26:09.000000000","message":"Please put some details in here.\n\ne.g.\n\n :param group: ???\n :param entry_point: A setuptools entry point object that the script is for.\n :param header: ???\n :param template: A string to be percent formatted to create the script body.\n :return: A tuple of (name, script_text).\n \"\"\"","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c440123f2358690d544265bf0f630224c5046064","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def generate_script(group, entry_point, name, header, template):"},{"line_number":312,"context_line":"    \"\"\"Generate the script based on the template.\"\"\""},{"line_number":313,"context_line":"    if not entry_point.attrs or len(entry_point.attrs) \u003e 2:"},{"line_number":314,"context_line":"        raise ValueError(\"Script targets must be of the form \""},{"line_number":315,"context_line":"                         \"\u0027func\u0027 or \u0027Class.class_method\u0027.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ac47dc1b","line":312,"in_reply_to":"dae33548_1eb74a3a","updated":"2016-02-16 21:51:42.000000000","message":"Done","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"4e59d5db8df16eb61f18a1d1dd9252eb151c16cd","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def generate_script(group, entry_point, name, header, template):"},{"line_number":312,"context_line":"    \"\"\"Generate the script based on the template.\"\"\""},{"line_number":313,"context_line":"    if not entry_point.attrs or len(entry_point.attrs) \u003e 2:"},{"line_number":314,"context_line":"        raise ValueError(\"Script targets must be of the form \""},{"line_number":315,"context_line":"                         \"\u0027func\u0027 or \u0027Class.class_method\u0027.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1eb74a3a","line":312,"in_reply_to":"dae33548_43357bd8","updated":"2016-02-15 23:05:14.000000000","message":"Certainly. I was just mimicking the string from override_get_script_args","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"6449c622cf6856a4a4f6d5ac6bf902650d8d798f","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            ei_cmd.egg_name, ei_cmd.egg_version,"},{"line_number":373,"context_line":"        )"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        bs_cmd \u003d self.get_finalized_command(\"build_scripts\")"},{"line_number":376,"context_line":"        executable \u003d getattr("},{"line_number":377,"context_line":"            bs_cmd, \u0027executable\u0027, easy_install.sys_executable)"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_dfca09a1","line":375,"updated":"2016-02-15 17:53:43.000000000","message":"I didn\u0027t mean to update this. I\u0027ll fix it (and the extra new-lines) when I update this review with tests \u0026 other feedback.","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c440123f2358690d544265bf0f630224c5046064","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            ei_cmd.egg_name, ei_cmd.egg_version,"},{"line_number":373,"context_line":"        )"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        bs_cmd \u003d self.get_finalized_command(\"build_scripts\")"},{"line_number":376,"context_line":"        executable \u003d getattr("},{"line_number":377,"context_line":"            bs_cmd, \u0027executable\u0027, easy_install.sys_executable)"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_0c57e8ce","line":375,"in_reply_to":"dae33548_434c5b70","updated":"2016-02-16 21:51:42.000000000","message":"Done","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9b5f29028783d2d43b3dae9cc424f8ddb8480477","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            ei_cmd.egg_name, ei_cmd.egg_version,"},{"line_number":373,"context_line":"        )"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        bs_cmd \u003d self.get_finalized_command(\"build_scripts\")"},{"line_number":376,"context_line":"        executable \u003d getattr("},{"line_number":377,"context_line":"            bs_cmd, \u0027executable\u0027, easy_install.sys_executable)"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_434c5b70","line":375,"in_reply_to":"dae33548_dfca09a1","updated":"2016-02-15 22:26:09.000000000","message":"Thanks. I don\u0027t mind making all the strings consistent, its a bit hodgepodge at the moment... but perhaps as a separate dedicated patch. The extra VWS is an issue though.","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9b5f29028783d2d43b3dae9cc424f8ddb8480477","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        if self.no_ep:"},{"line_number":389,"context_line":"            # don\u0027t install entry point scripts into .egg file!"},{"line_number":390,"context_line":"            return"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if os.name !\u003d \u0027nt\u0027:"},{"line_number":393,"context_line":"            get_script_args \u003d override_get_script_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_839b03c9","line":390,"updated":"2016-02-15 22:26:09.000000000","message":"Should that be before the bdist wheel check? Or is no_ep set for bdist wheel too? If so, perhaps we should change the comment here?","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c440123f2358690d544265bf0f630224c5046064","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        if self.no_ep:"},{"line_number":389,"context_line":"            # don\u0027t install entry point scripts into .egg file!"},{"line_number":390,"context_line":"            return"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if os.name !\u003d \u0027nt\u0027:"},{"line_number":393,"context_line":"            get_script_args \u003d override_get_script_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_2c62acad","line":390,"in_reply_to":"dae33548_1e8e2a78","updated":"2016-02-16 21:51:42.000000000","message":"Done","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"4e59d5db8df16eb61f18a1d1dd9252eb151c16cd","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        if self.no_ep:"},{"line_number":389,"context_line":"            # don\u0027t install entry point scripts into .egg file!"},{"line_number":390,"context_line":"            return"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if os.name !\u003d \u0027nt\u0027:"},{"line_number":393,"context_line":"            get_script_args \u003d override_get_script_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1e8e2a78","line":390,"in_reply_to":"dae33548_839b03c9","updated":"2016-02-15 23:05:14.000000000","message":"no_ep is set by wheel (the package) to True. So, yes this comment needs to be updated.","commit_id":"7fec49aeedab991f2ca608be9298d46aca682301"}],"pbr/tests/test_packaging.py":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"b66f812802c4688276f6dbe4b674aa64e07d271c","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"class TestPackagingWheels(base.BaseTestCase):"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def setUp(self):"},{"line_number":325,"context_line":"        super(TestPackagingWheels, self).setUp()"},{"line_number":326,"context_line":"        self.useFixture(TestRepo(self.package_dir))"},{"line_number":327,"context_line":"        self.run_setup(\u0027bdist_wheel\u0027, allow_fail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_207bc48d","line":324,"updated":"2016-02-17 05:05:43.000000000","message":"It seems to me that having the majority of the work being done in setUp for a single test obfuscates the test.  it would probably be best to just do this down in the test function.\n\nAlso the only variable used between setUp and the test is scripts_dir, yet everything is being created as an instance variable, this seems excessive.","commit_id":"fceb40009544e3bd5a9c03e71bb193443313435b"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c1c6640c9addf4943f5e464ee008eeb067e11c62","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"class TestPackagingWheels(base.BaseTestCase):"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def setUp(self):"},{"line_number":325,"context_line":"        super(TestPackagingWheels, self).setUp()"},{"line_number":326,"context_line":"        self.useFixture(TestRepo(self.package_dir))"},{"line_number":327,"context_line":"        self.run_setup(\u0027bdist_wheel\u0027, allow_fail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_a5e33dd8","line":324,"in_reply_to":"dae33548_207bc48d","updated":"2016-02-17 17:16:49.000000000","message":"I agree that there was no reason to assign those to instance variables. I was building those up when writing the test to make sure my own expectations of the structure and behaviour were correct.\n\nThat said, I disagree that this should all be in the test. I\u0027ve added another test which makes most of the setUp for analyzing the contents of the generated wheel necessary.\n\nI\u0027ve only added one instance variable in the new patchset but left most of this here as it relates to both tests (and we can probably add more tests as we start using gui_scripts as well).","commit_id":"fceb40009544e3bd5a9c03e71bb193443313435b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"06dffbb8db20657b1cbd58ce5fe6facd5f3a2ce3","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        # Ubuntu 14.04 archive."},{"line_number":720,"context_line":"        for suffix, _, _ in imp.get_suffixes():"},{"line_number":721,"context_line":"            if suffix.startswith(\u0027.pypy\u0027) and suffix.endswith(\u0027.so\u0027):"},{"line_number":722,"context_line":"                return suffix.split(\u0027.\u0027)[1]"},{"line_number":723,"context_line":"    else:"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            return sysconfig.get_config_var(\u0027SOABI\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_61799393","line":722,"updated":"2016-03-21 21:45:10.000000000","message":"So does this break on newer pypy?","commit_id":"48e0cc480b0a2baae4c26aefa99ee0e559f1977f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"1e6ae8633010a447fd068275c1c40687b0a0e72b","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        # Ubuntu 14.04 archive."},{"line_number":720,"context_line":"        for suffix, _, _ in imp.get_suffixes():"},{"line_number":721,"context_line":"            if suffix.startswith(\u0027.pypy\u0027) and suffix.endswith(\u0027.so\u0027):"},{"line_number":722,"context_line":"                return suffix.split(\u0027.\u0027)[1]"},{"line_number":723,"context_line":"    else:"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            return sysconfig.get_config_var(\u0027SOABI\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_c10fbfdf","line":722,"in_reply_to":"fa0719c6_61799393","updated":"2016-03-21 21:51:59.000000000","message":"Good question. This shouldn\u0027t break because I stole this from pypy\u0027s sysconfig standard library. That said, I should probably update this to attempt to use sysconfig first and *then* check for pypy and perform this tiny trick. Agreed?","commit_id":"48e0cc480b0a2baae4c26aefa99ee0e559f1977f"}]}