)]}'
{"pbr/tests/test_packaging.py":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"570582391558e020e03f48ab4f19bd526b675b1e","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    def test_generates_c_extensions(self):"},{"line_number":360,"context_line":"        built_package_dir \u003d os.path.join("},{"line_number":361,"context_line":"            self.extracted_wheel_dir, \u0027pbr_testpackage\u0027)"},{"line_number":362,"context_line":"        static_object_filename \u003d \u0027testext.so\u0027"},{"line_number":363,"context_line":"        soabi \u003d get_soabi()"},{"line_number":364,"context_line":"        if soabi:"},{"line_number":365,"context_line":"            static_object_filename \u003d \u0027testext.{0}.so\u0027.format(soabi)"},{"line_number":366,"context_line":"        static_object_path \u003d os.path.join("},{"line_number":367,"context_line":"            built_package_dir, static_object_filename)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.assertTrue(os.path.exists(built_package_dir))"},{"line_number":370,"context_line":"        self.assertTrue(os.path.exists(static_object_path))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_efed4ef0","line":367,"range":{"start_line":362,"start_character":0,"end_line":367,"end_character":54},"updated":"2016-04-06 07:51:04.000000000","message":"get_soabi may return None but the object filename may have an soabi listed, in the case of our CI \u0027pypy-22\u0027.  Causing the assert at 370 to fail.","commit_id":"009cff7621597b2e5ba1ad415134c2171cdf13d5"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"15a71eb876bdb62da02f348a261c1a9e1ec62a58","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    def test_generates_c_extensions(self):"},{"line_number":360,"context_line":"        built_package_dir \u003d os.path.join("},{"line_number":361,"context_line":"            self.extracted_wheel_dir, \u0027pbr_testpackage\u0027)"},{"line_number":362,"context_line":"        static_object_filename \u003d \u0027testext.so\u0027"},{"line_number":363,"context_line":"        soabi \u003d get_soabi()"},{"line_number":364,"context_line":"        if soabi:"},{"line_number":365,"context_line":"            static_object_filename \u003d \u0027testext.{0}.so\u0027.format(soabi)"},{"line_number":366,"context_line":"        static_object_path \u003d os.path.join("},{"line_number":367,"context_line":"            built_package_dir, static_object_filename)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self.assertTrue(os.path.exists(built_package_dir))"},{"line_number":370,"context_line":"        self.assertTrue(os.path.exists(static_object_path))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_72fe1aaf","line":367,"range":{"start_line":362,"start_character":0,"end_line":367,"end_character":54},"in_reply_to":"9a061dce_efed4ef0","updated":"2016-04-06 19:05:12.000000000","message":"I wrote all of this specifically to satisfy the pypy job at the gate. I\u0027m really disappointed it\u0027s already broken. Sorry for this.","commit_id":"009cff7621597b2e5ba1ad415134c2171cdf13d5"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"570582391558e020e03f48ab4f19bd526b675b1e","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"def get_soabi():"},{"line_number":738,"context_line":"    try:"},{"line_number":739,"context_line":"        return sysconfig.get_config_var(\u0027SOABI\u0027)"},{"line_number":740,"context_line":"    except (IOError, OSError):"},{"line_number":741,"context_line":"        pass"},{"line_number":742,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0f6ec294","line":739,"range":{"start_line":739,"start_character":15,"end_line":739,"end_character":48},"updated":"2016-04-06 07:51:04.000000000","message":"On 2.2.1 this returns None rather than raising an exception.  (not sure where the OSError is coming from in CI)\n\nAs such we don\u0027t try to figure it out for ourself from get_scheme_names.\n\nSo what\u0027s the right thing to do when we get None?  Try and figure it out, or expect testext.so?","commit_id":"009cff7621597b2e5ba1ad415134c2171cdf13d5"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"15a71eb876bdb62da02f348a261c1a9e1ec62a58","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"def get_soabi():"},{"line_number":738,"context_line":"    try:"},{"line_number":739,"context_line":"        return sysconfig.get_config_var(\u0027SOABI\u0027)"},{"line_number":740,"context_line":"    except (IOError, OSError):"},{"line_number":741,"context_line":"        pass"},{"line_number":742,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_5274b666","line":739,"range":{"start_line":739,"start_character":15,"end_line":739,"end_character":48},"in_reply_to":"9a061dce_0f6ec294","updated":"2016-04-06 19:05:12.000000000","message":"Hm, these problems weren\u0027t happening when I introduced this logic. We could do:\n\n    soabi \u003d None\n    try:\n        soabi \u003d sysconfig.get_config_var(\u0027SOABI\u0027)\n    except (IOError, OSError):\n        pass\n\n    if soabi is None and \u0027pypy\u0027 in sysconfig.get_scheme_names():\n        for suffix, _, _ in imp.get_suffixes():\n            if suffix.startswith(\u0027.pypy\u0027) and suffix.endswith(\u0027.so\u0027):\n                soabi \u003d suffix.split(\u0027.\u0027)[1]\n                break\n\n    return soabi","commit_id":"009cff7621597b2e5ba1ad415134c2171cdf13d5"}]}
