)]}'
{"pbr/extra_files.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_extra_files():"},{"line_number":23,"context_line":"    global _extra_files"},{"line_number":24,"context_line":"    return _extra_files"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def set_extra_files(extra_files):"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgKQ%3D","line":24,"updated":"2013-07-30 05:41:08.000000000","message":"is the method required? Whats wrong with attribute access?","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                \u0027%s from the extra_files option in setup.cfg does not \u0027"},{"line_number":33,"context_line":"                \u0027exist\u0027 % filename)"},{"line_number":34,"context_line":"    global _extra_files"},{"line_number":35,"context_line":"    _extra_files \u003d extra_files"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgKI%3D","line":35,"updated":"2013-07-30 05:41:08.000000000","message":"If this line is why there is a get_extra_files accessor, consider\nextra_files[:] \u003d new_extra_files[:]","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"43697d5375627d5b75c19d7e06d1f4c04a7e9200","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                \u0027%s from the extra_files option in setup.cfg does not \u0027"},{"line_number":33,"context_line":"                \u0027exist\u0027 % filename)"},{"line_number":34,"context_line":"    global _extra_files"},{"line_number":35,"context_line":"    _extra_files[:] \u003d extra_files[:]"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZZA%3D","line":35,"updated":"2013-07-31 20:09:33.000000000","message":"Is the slice on the left hand side here to make sure we update the existing list rather than create a new one so that people with references to _extra_files don\u0027t get out of date?","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"46f0f04d49ea86d5e944a9dd91607fa4c03aaf38","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                \u0027%s from the extra_files option in setup.cfg does not \u0027"},{"line_number":33,"context_line":"                \u0027exist\u0027 % filename)"},{"line_number":34,"context_line":"    global _extra_files"},{"line_number":35,"context_line":"    _extra_files[:] \u003d extra_files[:]"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FXP8%3D","line":35,"in_reply_to":"AAAAQn%2F%2FZWE%3D","updated":"2013-08-01 11:46:31.000000000","message":"\u0027From lifeless\u0027 :)","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7538ecc03f5b5a1e307d60490a7beca1f7001578","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                \u0027%s from the extra_files option in setup.cfg does not \u0027"},{"line_number":33,"context_line":"                \u0027exist\u0027 % filename)"},{"line_number":34,"context_line":"    global _extra_files"},{"line_number":35,"context_line":"    _extra_files[:] \u003d extra_files[:]"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZWE%3D","line":35,"in_reply_to":"AAAAQn%2F%2FZZA%3D","updated":"2013-07-31 20:14:05.000000000","message":"Yeah - it was a prior code review suggestion from jeblair.","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"}],"pbr/packaging.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"b261854ce38d2efe15801efe1de9987ae213375f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        matter one flip, and is actually destructive."},{"line_number":317,"context_line":"        \"\"\""},{"line_number":318,"context_line":"        manifest_filename \u003d os.path.join(self.egg_info, \"SOURCES.txt\")"},{"line_number":319,"context_line":"        if not os.path.exists(manifest_filename) or \u0027sdist\u0027 in sys.argv:"},{"line_number":320,"context_line":"            log.info(\"[pbr] Processing SOURCES.txt\")"},{"line_number":321,"context_line":"            mm \u003d LocalManifestMaker(self.distribution)"},{"line_number":322,"context_line":"            mm.manifest \u003d manifest_filename"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2Flh8%3D","line":319,"updated":"2013-05-29 21:40:06.000000000","message":"Poking at sys.argv kinda bothers me a bit - there\u0027s no way to run setuptools except from the command line?\n\nHowever, looking at the way distutils.core.run_setup() mangles sys.argv, it seems fairly clear that all setuptools code relies on sys.argv","commit_id":"41d53879271534c092ffcaae928a76e93dc40690"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6e562ca709cea8a373020daa50956d4dd1ffb185","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        matter one flip, and is actually destructive."},{"line_number":317,"context_line":"        \"\"\""},{"line_number":318,"context_line":"        manifest_filename \u003d os.path.join(self.egg_info, \"SOURCES.txt\")"},{"line_number":319,"context_line":"        if not os.path.exists(manifest_filename) or \u0027sdist\u0027 in sys.argv:"},{"line_number":320,"context_line":"            log.info(\"[pbr] Processing SOURCES.txt\")"},{"line_number":321,"context_line":"            mm \u003d LocalManifestMaker(self.distribution)"},{"line_number":322,"context_line":"            mm.manifest \u003d manifest_filename"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPX%2F%2FyH0%3D","line":319,"in_reply_to":"AAAAPH%2F%2Flh8%3D","updated":"2013-06-10 19:05:44.000000000","message":"It\u0027s some of the worst python code ever written, as evidenced by this file of code.","commit_id":"41d53879271534c092ffcaae928a76e93dc40690"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5d11bb76a64c504510537450879a0e0546e7a3f8","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.filelist.append(self.template)"},{"line_number":456,"context_line":"        self.filelist.append(self.manifest)"},{"line_number":457,"context_line":"        should_skip \u003d get_boolean_option(option_dict, \u0027skip_git_sdist\u0027,"},{"line_number":458,"context_line":"                                         \u0027SKIP_GIT_SDIST\u0027)"},{"line_number":459,"context_line":"        rcfiles \u003d find_git_files()"},{"line_number":460,"context_line":"        if rcfiles and not should_skip:"},{"line_number":461,"context_line":"            self.filelist.extend(rcfiles)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAPn%2F%2FtUw%3D","line":458,"updated":"2013-06-24 20:33:45.000000000","message":"Should that env variable be PBR_SKIP_GIT_SDIST?","commit_id":"20e0a4c6baa63fec2faf557642a80ac95c4b3734"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"47c388490ba9c7f2ecde014e38cc3a88d941ddc5","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.filelist.append(self.template)"},{"line_number":456,"context_line":"        self.filelist.append(self.manifest)"},{"line_number":457,"context_line":"        should_skip \u003d get_boolean_option(option_dict, \u0027skip_git_sdist\u0027,"},{"line_number":458,"context_line":"                                         \u0027SKIP_GIT_SDIST\u0027)"},{"line_number":459,"context_line":"        rcfiles \u003d find_git_files()"},{"line_number":460,"context_line":"        if rcfiles and not should_skip:"},{"line_number":461,"context_line":"            self.filelist.extend(rcfiles)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAPn%2F%2Fs2E%3D","line":458,"in_reply_to":"AAAAPn%2F%2FtBA%3D","updated":"2013-06-24 23:07:14.000000000","message":"Works for me.","commit_id":"20e0a4c6baa63fec2faf557642a80ac95c4b3734"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"cb2c2a5f7cb01bd6210badb01c835b5670143558","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.filelist.append(self.template)"},{"line_number":456,"context_line":"        self.filelist.append(self.manifest)"},{"line_number":457,"context_line":"        should_skip \u003d get_boolean_option(option_dict, \u0027skip_git_sdist\u0027,"},{"line_number":458,"context_line":"                                         \u0027SKIP_GIT_SDIST\u0027)"},{"line_number":459,"context_line":"        rcfiles \u003d find_git_files()"},{"line_number":460,"context_line":"        if rcfiles and not should_skip:"},{"line_number":461,"context_line":"            self.filelist.extend(rcfiles)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAPn%2F%2FtBA%3D","line":458,"in_reply_to":"AAAAPn%2F%2FtUw%3D","updated":"2013-06-24 22:01:51.000000000","message":"Eventually, that\u0027s probably a good idea. Right now all of the variables start with SKIP_ - so I think it would be less confusing to keep them the same and then in a future change with a major version bump, we should rename to PBR_","commit_id":"20e0a4c6baa63fec2faf557642a80ac95c4b3734"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b3b8f3b5acfad0dbdf6aa7af3d065f8798baf98e","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    \"\"\""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    file_list \u003d []"},{"line_number":312,"context_line":"    if git_dir is None:"},{"line_number":313,"context_line":"        git_dir \u003d _get_git_directory()"},{"line_number":314,"context_line":"    if git_dir:"},{"line_number":315,"context_line":"        log.info(\"[pbr] In git context, generating filelist from git\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAP3%2F%2Fiko%3D","line":312,"updated":"2013-07-16 20:51:10.000000000","message":"ISTM we could always pass a valid git_dir value, couldn\u0027t we?","commit_id":"aa3434124c99dda1edd8f910135bedfb17625653"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b3b8f3b5acfad0dbdf6aa7af3d065f8798baf98e","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        rcfiles \u003d find_git_files()"},{"line_number":472,"context_line":"        if rcfiles and not should_skip:"},{"line_number":473,"context_line":"            self.filelist.extend(rcfiles)"},{"line_number":474,"context_line":"        elif os.path.exists(self.manifest):"},{"line_number":475,"context_line":"            self.read_manifest()"},{"line_number":476,"context_line":"        ei_cmd \u003d self.get_finalized_command(\u0027egg_info\u0027)"},{"line_number":477,"context_line":"        self.add_pbr_defaults()"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAP3%2F%2FiaI%3D","line":474,"updated":"2013-07-16 20:51:10.000000000","message":"Should the manifest be ignored if we\u0027re pulling in files from git? What about files created by other steps of the build?","commit_id":"aa3434124c99dda1edd8f910135bedfb17625653"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    We don\u0027t actually use the entrypoints system for this because it runs"},{"line_number":312,"context_line":"    at absurd times. We only want to do this when we are building an sdist."},{"line_number":313,"context_line":"    \"\"\""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    file_list \u003d []"},{"line_number":316,"context_line":"    if git_dir is None:"},{"line_number":317,"context_line":"        git_dir \u003d _get_git_directory()"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgKE%3D","line":314,"updated":"2013-07-30 05:41:08.000000000","message":"Spurious VWS.","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        elif os.path.exists(self.manifest):"},{"line_number":544,"context_line":"            self.read_manifest()"},{"line_number":545,"context_line":"        ei_cmd \u003d self.get_finalized_command(\u0027egg_info\u0027)"},{"line_number":546,"context_line":"        self.add_pbr_defaults()"},{"line_number":547,"context_line":"        self.filelist.include_pattern(\"*\", prefix\u003dei_cmd.egg_info)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgJ8%3D","line":546,"updated":"2013-07-30 05:41:08.000000000","message":"add_pbr_defaults probably wants to be private.","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        self.filelist.include_pattern(\"*\", prefix\u003dei_cmd.egg_info)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"class LocalEggInfo(egg_info.egg_info):"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    command_name \u003d \u0027egg_info\u0027"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgJ0%3D","line":550,"updated":"2013-07-30 05:41:08.000000000","message":"class docstring please (or make private).","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        if not os.path.exists(manifest_filename) or \u0027sdist\u0027 in sys.argv:"},{"line_number":563,"context_line":"            log.info(\"[pbr] Processing SOURCES.txt\")"},{"line_number":564,"context_line":"            mm \u003d LocalManifestMaker(self.distribution)"},{"line_number":565,"context_line":"            mm.manifest \u003d manifest_filename"},{"line_number":566,"context_line":"            mm.run()"},{"line_number":567,"context_line":"            self.filelist \u003d mm.filelist"},{"line_number":568,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgJg%3D","line":565,"updated":"2013-07-30 05:41:08.000000000","message":"Pity you can\u0027t pass manifest_filename into the constructor, or could you?","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"976ee7fd4431c6e172cd48d3cb12b7dc5a14c85d","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            \u0027include ChangeLog\u0027,"},{"line_number":518,"context_line":"            \u0027exclude .gitignore\u0027,"},{"line_number":519,"context_line":"            \u0027exclude .gitreview\u0027,"},{"line_number":520,"context_line":"            \u0027global-exclude *.pyc\u0027"},{"line_number":521,"context_line":"        ]:"},{"line_number":522,"context_line":"            self.filelist.process_template_line(template_line)"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZYc%3D","line":520,"updated":"2013-07-31 19:56:28.000000000","message":"It seems odd to need to explicitly exclude pyc files.","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7538ecc03f5b5a1e307d60490a7beca1f7001578","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            \u0027include ChangeLog\u0027,"},{"line_number":518,"context_line":"            \u0027exclude .gitignore\u0027,"},{"line_number":519,"context_line":"            \u0027exclude .gitreview\u0027,"},{"line_number":520,"context_line":"            \u0027global-exclude *.pyc\u0027"},{"line_number":521,"context_line":"        ]:"},{"line_number":522,"context_line":"            self.filelist.process_template_line(template_line)"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZV8%3D","line":520,"in_reply_to":"AAAAQn%2F%2FZYc%3D","updated":"2013-07-31 20:14:05.000000000","message":"Yes. I agree - but it\u0027s in all of our MANIFEST.in files now...","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"976ee7fd4431c6e172cd48d3cb12b7dc5a14c85d","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        else:"},{"line_number":564,"context_line":"            log.info(\"[pbr] Reusing existing SOURCES.txt\")"},{"line_number":565,"context_line":"            self.filelist \u003d egg_info.FileList()"},{"line_number":566,"context_line":"            for entry in open(manifest_filename, \u0027r\u0027).read().split(\u0027\\n\u0027):"},{"line_number":567,"context_line":"                self.filelist.append(entry)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZZ0%3D","line":566,"updated":"2013-07-31 19:56:28.000000000","message":"This loop could be reduced to:\n\n  self.filelist.extend(open(manifest_filename, \u0027r\u0027).read().splitlines())\n\nMaybe in a later patch","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"30c7e1ad4cf5ad16a915f15b4dcb4ac5e12622d3","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            log.info(\"[pbr] Reusing existing SOURCES.txt\")"},{"line_number":565,"context_line":"            self.filelist \u003d egg_info.FileList()"},{"line_number":566,"context_line":"            for entry in open(manifest_filename, \u0027r\u0027).read().split(\u0027\\n\u0027):"},{"line_number":567,"context_line":"                self.filelist.append(entry)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class LocalSDist(sdist.sdist):"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAQn%2F%2FXNw%3D","line":567,"updated":"2013-08-01 11:48:38.000000000","message":"split returns a list:\n\nself.filelist \u003d egg_info.FileList() + open(manifest_filename, \u0027r\u0027).read().split(\u0027\\n\u0027)","commit_id":"36f768a0008e3871246210e9fbf50041fc84ab51"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2e19b6fbf4543c26cbb9146ad80a2554107a225b","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            log.info(\"[pbr] Reusing existing SOURCES.txt\")"},{"line_number":565,"context_line":"            self.filelist \u003d egg_info.FileList()"},{"line_number":566,"context_line":"            for entry in open(manifest_filename, \u0027r\u0027).read().split(\u0027\\n\u0027):"},{"line_number":567,"context_line":"                self.filelist.append(entry)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class LocalSDist(sdist.sdist):"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAQn%2F%2FPhs%3D","line":567,"in_reply_to":"AAAAQn%2F%2FQSs%3D","updated":"2013-08-04 14:20:03.000000000","message":"self.filelist is not a list though, it\u0027s a FileList, and I have no control over that design","commit_id":"36f768a0008e3871246210e9fbf50041fc84ab51"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"74e44aaeab2ce1df1c7a8ca1273d7369400a612a","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            log.info(\"[pbr] Reusing existing SOURCES.txt\")"},{"line_number":565,"context_line":"            self.filelist \u003d egg_info.FileList()"},{"line_number":566,"context_line":"            for entry in open(manifest_filename, \u0027r\u0027).read().split(\u0027\\n\u0027):"},{"line_number":567,"context_line":"                self.filelist.append(entry)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class LocalSDist(sdist.sdist):"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAQn%2F%2FQSs%3D","line":567,"in_reply_to":"AAAAQn%2F%2FXNw%3D","updated":"2013-08-03 16:29:09.000000000","message":"Done","commit_id":"36f768a0008e3871246210e9fbf50041fc84ab51"}],"pbr/tests/test_core.py":[{"author":{"_account_id":4375,"name":"Sascha Peilicke","email":"sascha@peilicke.de","username":"saschpe"},"change_message_id":"80ca3ebcfd03750a289bd925fc11a4eff4df2990","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        tf \u003d tarfile.open(tf_path)"},{"line_number":75,"context_line":"        names \u003d [\u0027/\u0027.join(p.split(\u0027/\u0027)[1:]) for p in tf.getnames()]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        print(names)"},{"line_number":78,"context_line":"        self.assertIn(\u0027extra-file.txt\u0027, names)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_console_script_install(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAQn%2F%2F1nQ%3D","line":77,"updated":"2013-07-22 12:20:23.000000000","message":"Hah!","commit_id":"305f217e90166a1458b9063813fdfadb786f788d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"0c28490f8bcfba3ff902dac4cf53091073a805e2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        tf \u003d tarfile.open(tf_path)"},{"line_number":75,"context_line":"        names \u003d [\u0027/\u0027.join(p.split(\u0027/\u0027)[1:]) for p in tf.getnames()]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        print(names)"},{"line_number":78,"context_line":"        self.assertIn(\u0027extra-file.txt\u0027, names)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_console_script_install(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAQn%2F%2F0rc%3D","line":77,"in_reply_to":"AAAAQn%2F%2F1nQ%3D","updated":"2013-07-22 17:11:42.000000000","message":"hehe","commit_id":"305f217e90166a1458b9063813fdfadb786f788d"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.assertIn(\"PBR\", stdout)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class TestGitSdist(tests.BaseTestCase):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def setUp(self):"},{"line_number":106,"context_line":"        super(TestGitSdist, self).setUp()"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgJY%3D","line":103,"updated":"2013-07-30 05:41:08.000000000","message":"Probably \u0027TestGitSDist\u0027 would be more correct.","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"0a8767cb2d2a5ea1bb718df22adcc9d8507bfe65","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_sdist_git_extra_files(self):"},{"line_number":119,"context_line":"        \"\"\"Test that extra files found in git are correctly added.\"\"\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # There can be only one"},{"line_number":122,"context_line":"        tf_path \u003d glob.glob(os.path.join(\u0027dist\u0027, \u0027*.tar.gz\u0027))[0]"},{"line_number":123,"context_line":"        tf \u003d tarfile.open(tf_path)"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAQn%2F%2FgJU%3D","line":120,"updated":"2013-07-30 05:41:08.000000000","message":"Spurious VWS.","commit_id":"1e9d4ad0a0327abede41310fd42141de5bbab551"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"43697d5375627d5b75c19d7e06d1f4c04a7e9200","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def setUp(self):"},{"line_number":128,"context_line":"        super(TestGitSDist, self).setUp()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        stdout, _, return_code \u003d self._run_cmd(\u0027git\u0027, (\u0027init\u0027,))"},{"line_number":131,"context_line":"        if return_code:"},{"line_number":132,"context_line":"            self.skipTest(\"git not installed\")"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZWc%3D","line":130,"updated":"2013-07-31 20:09:33.000000000","message":"Underscores creeping back in.","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7538ecc03f5b5a1e307d60490a7beca1f7001578","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def setUp(self):"},{"line_number":128,"context_line":"        super(TestGitSDist, self).setUp()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        stdout, _, return_code \u003d self._run_cmd(\u0027git\u0027, (\u0027init\u0027,))"},{"line_number":131,"context_line":"        if return_code:"},{"line_number":132,"context_line":"            self.skipTest(\"git not installed\")"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZVo%3D","line":130,"in_reply_to":"AAAAQn%2F%2FZWc%3D","updated":"2013-07-31 20:14:05.000000000","message":"I have a later patch that fixes them all.","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"43697d5375627d5b75c19d7e06d1f4c04a7e9200","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        stdout, _, return_code \u003d self._run_cmd("},{"line_number":136,"context_line":"            \u0027git\u0027, (\u0027commit\u0027, \u0027-m\u0027, \u0027Turn this into a git repo\u0027))"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        stdout, _, return_code \u003d self.run_setup(\u0027sdist\u0027, \u0027--formats\u003dgztar\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_sdist_git_extra_files(self):"},{"line_number":141,"context_line":"        \"\"\"Test that extra files found in git are correctly added.\"\"\""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZWU%3D","line":138,"updated":"2013-07-31 20:09:33.000000000","message":"I feel like the run in a git repo stuff should be done with a fixture.","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7538ecc03f5b5a1e307d60490a7beca1f7001578","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        stdout, _, return_code \u003d self._run_cmd("},{"line_number":136,"context_line":"            \u0027git\u0027, (\u0027commit\u0027, \u0027-m\u0027, \u0027Turn this into a git repo\u0027))"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        stdout, _, return_code \u003d self.run_setup(\u0027sdist\u0027, \u0027--formats\u003dgztar\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_sdist_git_extra_files(self):"},{"line_number":141,"context_line":"        \"\"\"Test that extra files found in git are correctly added.\"\"\""}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAQn%2F%2FZVg%3D","line":138,"in_reply_to":"AAAAQn%2F%2FZWU%3D","updated":"2013-07-31 20:14:05.000000000","message":"Yah. There\u0027s a bunch of re-engineering I want to do of the tests I inherited from d2to1.","commit_id":"7eec46fc0b4f7214a69e8cfc49fcf35a32117fa6"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"6559af1834c884923470a4dd531234f5f712f77e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"class TestCore(tests.BaseTestCase):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    cmd_names \u003d (\u0027pbr_test_cmd\u0027, \u0027pbr_test_cmd_with_class\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def check_script_install(self, install_stdout):"},{"line_number":55,"context_line":"        for cmd_name in self.cmd_names:"},{"line_number":56,"context_line":"            install_txt \u003d \u0027Installing %s script to %s\u0027 % (cmd_name,"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAQn%2F%2FXOo%3D","line":53,"updated":"2013-08-01 11:46:56.000000000","message":"Looks like a perfect case for testscenarios.","commit_id":"36f768a0008e3871246210e9fbf50041fc84ab51"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"74e44aaeab2ce1df1c7a8ca1273d7369400a612a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"class TestCore(tests.BaseTestCase):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    cmd_names \u003d (\u0027pbr_test_cmd\u0027, \u0027pbr_test_cmd_with_class\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def check_script_install(self, install_stdout):"},{"line_number":55,"context_line":"        for cmd_name in self.cmd_names:"},{"line_number":56,"context_line":"            install_txt \u003d \u0027Installing %s script to %s\u0027 % (cmd_name,"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAQn%2F%2FQSg%3D","line":53,"in_reply_to":"AAAAQn%2F%2FXOo%3D","updated":"2013-08-03 16:29:09.000000000","message":"Totally agree.","commit_id":"36f768a0008e3871246210e9fbf50041fc84ab51"}],"pbr/util.py":[{"author":{"_account_id":4375,"name":"Sascha Peilicke","email":"sascha@peilicke.de","username":"saschpe"},"change_message_id":"80ca3ebcfd03750a289bd925fc11a4eff4df2990","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                    raise DistutilsFileError("},{"line_number":269,"context_line":"                        \u0027%s from the extra_files option in setup.cfg does not \u0027"},{"line_number":270,"context_line":"                        \u0027exist\u0027 % filename)"},{"line_number":271,"context_line":"            extra_files.set_extra_files(_extra_files)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    finally:"},{"line_number":274,"context_line":"        # Perform cleanup if any paths were added to sys.path"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAQn%2F%2F1nU%3D","line":271,"updated":"2013-07-22 12:20:23.000000000","message":"Shouldn\u0027t that be _extra_files? Also, why is _extra_files used directly instead of using {get,set}_extra_files() from pbr/extra_files.py? While this file is more \"internal\" than pbr/packaging.py, it\u0027s probably better to use the same interface.","commit_id":"305f217e90166a1458b9063813fdfadb786f788d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"0c28490f8bcfba3ff902dac4cf53091073a805e2","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                    raise DistutilsFileError("},{"line_number":269,"context_line":"                        \u0027%s from the extra_files option in setup.cfg does not \u0027"},{"line_number":270,"context_line":"                        \u0027exist\u0027 % filename)"},{"line_number":271,"context_line":"            extra_files.set_extra_files(_extra_files)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    finally:"},{"line_number":274,"context_line":"        # Perform cleanup if any paths were added to sys.path"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAQn%2F%2F0rM%3D","line":271,"in_reply_to":"AAAAQn%2F%2F1nU%3D","updated":"2013-07-22 17:11:42.000000000","message":"_extra_files here is a local. extra_files is the module. Now that you mention it - that is probably confusing naming - lemme change that a bit.","commit_id":"305f217e90166a1458b9063813fdfadb786f788d"}]}
