)]}'
{"pbr/git.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9dd1cebdee82d51f234f73fbcbfa7ba3a933e304","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        [\u0027git\u0027, \u0027--git-dir\u003d%s\u0027 % git_dir] + cmd, **kwargs)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def get_git_directory():"},{"line_number":69,"context_line":"    \"Return the git directory, if any.\""},{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        return _run_shell_command([\u0027git\u0027, \u0027rev-parse\u0027, \u0027--git-dir\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_02de7e3d","line":68,"range":{"start_line":68,"start_character":21,"end_line":68,"end_character":24},"updated":"2016-06-17 19:46:04.000000000","message":"I think this should stay private: its not something we want to export to external users of pbr.","commit_id":"5d4fd8936d9ecb0f2950c1d62b1107f9178b318e"}],"pbr/packaging.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9dd1cebdee82d51f234f73fbcbfa7ba3a933e304","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                    allow_unicode\u003dTrue,"},{"line_number":581,"context_line":"                    explicit_start\u003dTrue,"},{"line_number":582,"context_line":"                    encoding\u003d\u0027utf-8\u0027,"},{"line_number":583,"context_line":"                )"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"class LocalSDist(sdist.sdist):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e2a092a7","line":583,"updated":"2016-06-17 19:46:04.000000000","message":"This seems like a layering issue: why does pbr know the reno cache filename and format?","commit_id":"5d4fd8936d9ecb0f2950c1d62b1107f9178b318e"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"1489334addcfe1150e1e1dd442221a015a41f15a","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"def _generate_reno_cache(distribution):"},{"line_number":539,"context_line":"    if not _have_reno:"},{"line_number":540,"context_line":"        log.debug(\u0027[pbr] Skipping reno cache build, reno not installed\u0027)"},{"line_number":541,"context_line":"        return"},{"line_number":542,"context_line":"    git_dir \u003d git._get_git_directory()"},{"line_number":543,"context_line":"    if not git_dir:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_afb52c32","line":540,"range":{"start_line":540,"start_character":8,"end_line":540,"end_character":17},"updated":"2016-07-05 03:02:25.000000000","message":"I think this should logged as info.\n\nIf PBR is doing this by default then when it doesn\u0027t happen the user should not have to set their log level to debug to see why.","commit_id":"9e2c6258f7b5f32efdfcc4802746e971a8a79b76"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"1489334addcfe1150e1e1dd442221a015a41f15a","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        return"},{"line_number":542,"context_line":"    git_dir \u003d git._get_git_directory()"},{"line_number":543,"context_line":"    if not git_dir:"},{"line_number":544,"context_line":"        log.debug("},{"line_number":545,"context_line":"            \u0027[pbr] Skipping reno cache build, this is not a git repository\u0027"},{"line_number":546,"context_line":"        )"},{"line_number":547,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_0f83a057","line":544,"range":{"start_line":544,"start_character":8,"end_line":544,"end_character":17},"updated":"2016-07-05 03:02:25.000000000","message":"Same as above, I think this should be an info level log.","commit_id":"9e2c6258f7b5f32efdfcc4802746e971a8a79b76"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"1489334addcfe1150e1e1dd442221a015a41f15a","unresolved":false,"context_lines":[{"line_number":568,"context_line":"            versions_to_include\u003dNone,"},{"line_number":569,"context_line":"            earliest_version\u003dNone,"},{"line_number":570,"context_line":"        )"},{"line_number":571,"context_line":"    except Exception as e:"},{"line_number":572,"context_line":"        log.info(\u0027[pbr] could not generate reno cache: %s\u0027, e)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_4fcbe8a5","line":571,"range":{"start_line":571,"start_character":4,"end_line":571,"end_character":26},"updated":"2016-07-05 03:02:25.000000000","message":"Should we continue to generate the sdist if we fail to generate the release notes?\n\nIt seems like we end up not giving the the end user what they expects by letting the error go.","commit_id":"9e2c6258f7b5f32efdfcc4802746e971a8a79b76"}]}