)]}'
{"pbr/hooks/files.py":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"136c4b8d15f404bb780bdbcd52cc36290727108c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self, config, name):"},{"line_number":43,"context_line":"        super(FilesConfig, self).__init__(config)"},{"line_number":44,"context_line":"        self.name \u003d name"},{"line_number":45,"context_line":"        if \u0027data-files\u0027 in self.config and \u0027data_files\u0027 not in self.config:"},{"line_number":46,"context_line":"            self.config[\u0027data_files\u0027 \u003d self.config.pop(\u0027data-files\u0027)"},{"line_number":47,"context_line":"        self.data_files \u003d self.config.get(\u0027data_files\u0027, \u0027\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2af7fb59","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":10},"updated":"2016-07-21 07:45:39.000000000","message":"Should take care of normalisation in the main cfg_to_(kw)args, for a centralised take on it.\n\nIf we just do it here we fix it for this one but leave it as a potential issue in the future for other config values, or if someplace sets data_files before this hook as FilesConfig.save() is doing.\n\nPlus it feels a bit messy to normalise here, deep in some function who\u0027s job is not to normalise anything.","commit_id":"78b85cdb4f9292c68939b192e0591584d21c54d1"}],"pbr/tests/testpackage/setup.cfg":[{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"136c4b8d15f404bb780bdbcd52cc36290727108c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[files]"},{"line_number":31,"context_line":"packages \u003d pbr_testpackage"},{"line_number":32,"context_line":"package-data \u003d testpackage \u003d package_data/*.txt"},{"line_number":33,"context_line":"data-files \u003d testpackage/data_files \u003d data_files/*"},{"line_number":34,"context_line":"extra-files \u003d extra-file.txt"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"dada55a8_ca98df6c","line":33,"range":{"start_line":33,"start_character":38,"end_line":33,"end_character":50},"updated":"2016-07-21 07:45:39.000000000","message":"There\u0027s 3 files in here.  a.txt, b.txt, and c.rst.  So right now I can assume that it was meant to test that a.txt and b.txt were grabbed by the glob but c.rst was not to be grabbed.  I\u0027ll have to look into the history of that.","commit_id":"78b85cdb4f9292c68939b192e0591584d21c54d1"}],"pbr/util.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cbc2de239f5d502a6f8459c28206497ba2adc630","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for section in parser.sections():"},{"line_number":214,"context_line":"        config[section] \u003d dict(parser.items(section))"},{"line_number":215,"context_line":"        for k in config[section]:"},{"line_number":216,"context_line":"            if \u0027-\u0027 in k and k !\u003d \u0027download-url\u0027:"},{"line_number":217,"context_line":"                config[section][k.replace(\u0027-\u0027, \u0027_\u0027)] \u003d config[section].pop(k)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    # Run setup_hooks, if configured"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_cadb3e1a","line":216,"updated":"2016-08-25 10:07:08.000000000","message":"The change looks good but when I see this kind of exception, I wonder if it\u0027s a good idea to \"fix\" the behaviour. Why not removing it altogether and keep with data_files?","commit_id":"dd61ba90e751d7452243bc13651029226244c0bd"},{"author":{"_account_id":12612,"name":"Sachi King","email":"nakato@nakato.io","username":"nakato"},"change_message_id":"4e60716dfc21dc16693daf55ccaf7f5f1e1886bf","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for section in parser.sections():"},{"line_number":214,"context_line":"        config[section] \u003d dict(parser.items(section))"},{"line_number":215,"context_line":"        for k in config[section]:"},{"line_number":216,"context_line":"            if \u0027-\u0027 in k and k !\u003d \u0027download-url\u0027:"},{"line_number":217,"context_line":"                config[section][k.replace(\u0027-\u0027, \u0027_\u0027)] \u003d config[section].pop(k)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    # Run setup_hooks, if configured"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_b31a276d","line":216,"in_reply_to":"1ac06dbe_cadb3e1a","updated":"2016-08-26 02:07:08.000000000","message":"I\u0027m glad you mentioned this...  This does look rather funny.\n\nCurrently we return the arg \u0027download-url\u003d\"contents\"\u0027, however, checking the upstream documentation, this is incorrect, it\u0027s \u0027download_url\u0027, with an underscore like everything else.  So that\u0027s another bug.\n\nI\u0027ll drop this conditional entirely.\n\n\n\u003e Why not removing it altogether and keep with data_files?\n\nWith PBR we must never break backwards compatibility.\n\nWhile data_files has been broke for a quite some time, we can\u0027t just remove the normalisation because we\u0027ve previously been supporting \u0027-\u0027 based keys for every other key, and in fact advocating the use of \u0027-\u0027 in our documentation for certain keys.","commit_id":"dd61ba90e751d7452243bc13651029226244c0bd"}]}