)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"37a1366774dd20de32bd51aec69cef3c347855f0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for globbing in data files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to the work in the packages argument, allow the specification"},{"line_number":10,"context_line":"of a directory to recursively include as part of the install."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ife0414af468e7fcd4fc419eafc3e19e29efcfc7b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAAQn%2F%2FvrQ%3D","line":10,"updated":"2013-07-24 02:06:28.000000000","message":"It might be good to say why this is desirable (per https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages) :)","commit_id":"5035471108ab6f9769a06235ba2f8934007e0d7b"}],"pbr/hooks/files.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"65bd765f8287eaf9f5dac3be2767c6fe87b32a2f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def expand_globs(self):"},{"line_number":54,"context_line":"        finished \u003d []"},{"line_number":55,"context_line":"        for line in self.data_files.split(\"\\n\"):"},{"line_number":56,"context_line":"            if line.rstrip().endswith(\u0027*\u0027) and \u0027\u003d\u0027 in line:"},{"line_number":57,"context_line":"                (target, source_glob) \u003d line.split(\u0027\u003d\u0027)"},{"line_number":58,"context_line":"                source_prefix \u003d source_glob.strip()[:-1]"},{"line_number":59,"context_line":"                target \u003d target.strip()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fi20%3D","line":56,"updated":"2013-07-16 19:11:20.000000000","message":"Is the file format documented somewhere? I get the \u0027*\u0027, but not the \u0027\u003d\u0027.","commit_id":"dcbd66af41fcc030e5f6feff95beee3877ab55c7"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c94d5fd3018e9fd65d4da1d89d42c7518d87f246","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def expand_globs(self):"},{"line_number":54,"context_line":"        finished \u003d []"},{"line_number":55,"context_line":"        for line in self.data_files.split(\"\\n\"):"},{"line_number":56,"context_line":"            if line.rstrip().endswith(\u0027*\u0027) and \u0027\u003d\u0027 in line:"},{"line_number":57,"context_line":"                (target, source_glob) \u003d line.split(\u0027\u003d\u0027)"},{"line_number":58,"context_line":"                source_prefix \u003d source_glob.strip()[:-1]"},{"line_number":59,"context_line":"                target \u003d target.strip()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fhso%3D","line":56,"in_reply_to":"AAAAP3%2F%2Fi20%3D","updated":"2013-07-16 23:37:26.000000000","message":"I would LOVE to find documentation of the whole file format. But good point - I should document this.","commit_id":"dcbd66af41fcc030e5f6feff95beee3877ab55c7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"65bd765f8287eaf9f5dac3be2767c6fe87b32a2f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                target \u003d target.strip()"},{"line_number":60,"context_line":"                if not target.endswith(os.path.sep):"},{"line_number":61,"context_line":"                    target +\u003d os.path.sep"},{"line_number":62,"context_line":"                for (dirpath, dirnames, fnames) in os.walk(source_prefix):"},{"line_number":63,"context_line":"                    finished.append("},{"line_number":64,"context_line":"                        \"%s \u003d \" % dirpath.replace(source_prefix, target))"},{"line_number":65,"context_line":"                    finished.extend("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fi1w%3D","line":62,"updated":"2013-07-16 19:11:20.000000000","message":"Are globbing and recursing naturally tied together like this in all cases?","commit_id":"dcbd66af41fcc030e5f6feff95beee3877ab55c7"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c94d5fd3018e9fd65d4da1d89d42c7518d87f246","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                target \u003d target.strip()"},{"line_number":60,"context_line":"                if not target.endswith(os.path.sep):"},{"line_number":61,"context_line":"                    target +\u003d os.path.sep"},{"line_number":62,"context_line":"                for (dirpath, dirnames, fnames) in os.walk(source_prefix):"},{"line_number":63,"context_line":"                    finished.append("},{"line_number":64,"context_line":"                        \"%s \u003d \" % dirpath.replace(source_prefix, target))"},{"line_number":65,"context_line":"                    finished.extend("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fhss%3D","line":62,"in_reply_to":"AAAAP3%2F%2Fi1w%3D","updated":"2013-07-16 23:37:26.000000000","message":"Yes.","commit_id":"dcbd66af41fcc030e5f6feff95beee3877ab55c7"}],"pbr/tests/__init__.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"37a1366774dd20de32bd51aec69cef3c347855f0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        super(DiveDir, self).setUp()"},{"line_number":67,"context_line":"        self.old_path \u003d os.getcwd()"},{"line_number":68,"context_line":"        os.chdir(self.path)"},{"line_number":69,"context_line":"        self.addCleanup(os.chdir, self.old_path)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class BaseTestCase(testtools.TestCase, testresources.ResourcedTestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAQn%2F%2Fvqo%3D","line":69,"updated":"2013-07-24 02:06:28.000000000","message":"Ugh, sad that you need this.\n\nThat said, a) this should be a patch to fixtures, not embedded here. Tis generic.\n\nb) You don\u0027t need the temporary variables:\n\ndef setUp(self):\n    super(DiveDir, self).setUp()\n    self.addCleanup(os.chdir, os.getcwd())\n    os.chdir(self.path)\n\n*always* put the cleanup in place before the action code, otherwise an interrupt will leave you unclean.","commit_id":"5035471108ab6f9769a06235ba2f8934007e0d7b"}],"pbr/tests/test_files.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4320885f6e0fe9bbebcb566bb889c2323bb06d50","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def load_tests(loader, in_tests, pattern):"},{"line_number":84,"context_line":"    return testscenarios.load_tests_apply_scenarios(loader, in_tests, pattern)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAQn%2F%2FztU%3D","line":84,"updated":"2013-07-22 22:25:14.000000000","message":"Is this necessary? We don\u0027t seem to be using scenarios in this particular test file.","commit_id":"a4cb67ef6b98885b1f35b5c483ff71a2551115b2"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"37a1366774dd20de32bd51aec69cef3c347855f0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            pkg_fixture.base, \u0027fake_package\u0027, \u0027subpackage\u0027)"},{"line_number":43,"context_line":"        os.mkdir(pkg_etc)"},{"line_number":44,"context_line":"        os.mkdir(pkg_sub)"},{"line_number":45,"context_line":"        os.mkdir(subpackage)"},{"line_number":46,"context_line":"        with open(os.path.join(pkg_etc, \"foo\"), \u0027w\u0027) as foo_file:"},{"line_number":47,"context_line":"            foo_file.write(\"Foo Data\")"},{"line_number":48,"context_line":"        with open(os.path.join(pkg_sub, \"bar\"), \u0027w\u0027) as foo_file:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAQn%2F%2Fvpk%3D","line":45,"updated":"2013-07-24 02:06:28.000000000","message":"os,makedirs is your friend.","commit_id":"5035471108ab6f9769a06235ba2f8934007e0d7b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"37a1366774dd20de32bd51aec69cef3c347855f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        with open(os.path.join(pkg_sub, \"bar\"), \u0027w\u0027) as foo_file:"},{"line_number":49,"context_line":"            foo_file.write(\"Bar Data\")"},{"line_number":50,"context_line":"        with open(os.path.join(subpackage, \"__init__.py\"), \u0027w\u0027) as foo_file:"},{"line_number":51,"context_line":"            foo_file.write(\"# empty\")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.useFixture(tests.DiveDir(pkg_fixture.base))"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAQn%2F%2FvpQ%3D","line":51,"updated":"2013-07-24 02:06:28.000000000","message":"pkg_fixture should be able to add these files for you; if not we should improve it I think.","commit_id":"5035471108ab6f9769a06235ba2f8934007e0d7b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"37a1366774dd20de32bd51aec69cef3c347855f0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"        files.FilesConfig(config, \u0027fake_package\u0027).run()"},{"line_number":79,"context_line":"        self.assertIn(\u0027sub/bar\u0027, config[\u0027files\u0027][\u0027data_files\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAQn%2F%2Fvo4%3D","line":79,"updated":"2013-07-24 02:06:28.000000000","message":"Might be nice to capture a larger substring in the assertion.","commit_id":"5035471108ab6f9769a06235ba2f8934007e0d7b"}]}
