)]}'
{"pbr/packaging.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2ebe8f4faa0bc471e8bb69e46f3b675dbb86d195","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(git_dir, mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    mailmap \u003d os.path.join(os.path.dirname(git_dir), mailmap)"},{"line_number":113,"context_line":"    if os.path.exists(mailmap):"},{"line_number":114,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"},{"line_number":115,"context_line":"    return dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F%2Bj8%3D","line":112,"updated":"2013-07-18 05:00:17.000000000","message":"Is there a better way to find the projects root dir? iirc for submodules `dirname git_dir` may not be correct.","commit_id":"8218f8c4bfdaaf3ae95e88618dc6ac703b84c29c"},{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"0dcf44841b4977f1705c4f0e46194ea622c2379f","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(git_dir, mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    mailmap \u003d os.path.join(os.path.dirname(git_dir), mailmap)"},{"line_number":113,"context_line":"    if os.path.exists(mailmap):"},{"line_number":114,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"},{"line_number":115,"context_line":"    return dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F%2BXI%3D","line":112,"in_reply_to":"AAAAQn%2F%2F%2Bfk%3D","updated":"2013-07-18 07:24:22.000000000","message":"This should do\n    git rev-parse --show-toplevel","commit_id":"8218f8c4bfdaaf3ae95e88618dc6ac703b84c29c"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"35148523f76f833b66bedc968d624df94194696a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(git_dir, mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    mailmap \u003d os.path.join(os.path.dirname(git_dir), mailmap)"},{"line_number":113,"context_line":"    if os.path.exists(mailmap):"},{"line_number":114,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"},{"line_number":115,"context_line":"    return dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F%2Bfk%3D","line":112,"in_reply_to":"AAAAQn%2F%2F%2Bgc%3D","updated":"2013-07-18 05:53:29.000000000","message":"I\u0027ll try to check it, but now have no ideas about how to fix it...","commit_id":"8218f8c4bfdaaf3ae95e88618dc6ac703b84c29c"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"e6916064dbeb241d6322dde78465d68b6fd3288b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(git_dir, mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    mailmap \u003d os.path.join(os.path.dirname(git_dir), mailmap)"},{"line_number":113,"context_line":"    if os.path.exists(mailmap):"},{"line_number":114,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"},{"line_number":115,"context_line":"    return dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F%2BjY%3D","line":112,"in_reply_to":"AAAAQn%2F%2F%2Bj8%3D","updated":"2013-07-18 05:06:20.000000000","message":"Did you mean the situation when we want to run setup.py from the submodule dir?","commit_id":"8218f8c4bfdaaf3ae95e88618dc6ac703b84c29c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"11f02b3f6657fd210e13309d5d86cccef8e5ccd6","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(git_dir, mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    mailmap \u003d os.path.join(os.path.dirname(git_dir), mailmap)"},{"line_number":113,"context_line":"    if os.path.exists(mailmap):"},{"line_number":114,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"},{"line_number":115,"context_line":"    return dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F%2Bgc%3D","line":112,"in_reply_to":"AAAAQn%2F%2F%2BjY%3D","updated":"2013-07-18 05:38:58.000000000","message":"Correct. The git_dir for a submodule isn\u0027t under the root of the submodule. IIRC it is in the git_dir of the parent project, but I would need to double check that. I do know that we had to change the way we determined git_dir to accomodate submodules because they do this weirdly.","commit_id":"8218f8c4bfdaaf3ae95e88618dc6ac703b84c29c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"047f32bf94ed9e468ac8ecb38169acac49898c3b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    git_dir \u003d _run_shell_command(\u0027git rev-parse --show-toplevel\u0027)"},{"line_number":113,"context_line":"    mailmap \u003d os.path.join(git_dir, mailmap)"},{"line_number":114,"context_line":"    if os.path.exists(mailmap):"},{"line_number":115,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F4Tk%3D","line":112,"updated":"2013-07-19 21:53:50.000000000","message":"I feel like removing git_dir from the parameter list has made it harder to test this function. Now the tests have to monkey patch _run_shell_command rather than just providing the desired input. I think keeping the git_dir parameter and supplying the necessary value is cleaner, particularly for testing.","commit_id":"57fe22067b1b024f06d449cedbd48eea10308023"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"e8b541921c95b414954acd48a3dd34883b18fdcf","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def read_git_mailmap(mailmap\u003d\u0027.mailmap\u0027):"},{"line_number":112,"context_line":"    git_dir \u003d _run_shell_command(\u0027git rev-parse --show-toplevel\u0027)"},{"line_number":113,"context_line":"    mailmap \u003d os.path.join(git_dir, mailmap)"},{"line_number":114,"context_line":"    if os.path.exists(mailmap):"},{"line_number":115,"context_line":"        return _parse_mailmap(open(mailmap, \u0027r\u0027).readlines())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FlY4%3D","line":112,"in_reply_to":"AAAAQn%2F%2F4Tk%3D","updated":"2013-07-27 07:01:03.000000000","message":"Done","commit_id":"57fe22067b1b024f06d449cedbd48eea10308023"}]}