)]}'
{"doc/source/compatibility.rst":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"31e3b5c05cbd788e9c06a7e8019e6e41c5f9c363","unresolved":false,"context_lines":[{"line_number":55,"context_line":"--------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The ``warning-is-error`` flag is only supported by Sphinx 1.5 and will cause"},{"line_number":58,"context_line":"errors when used with older versions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"da36d5c6_00670a26","line":58,"updated":"2017-02-27 21:08:22.000000000","message":"Should we retain the notes about the older versions of sphinx?","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86bc4a9567c2c52d3eff8c4a837acce829bd0da8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"--------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The ``warning-is-error`` flag is only supported by Sphinx 1.5 and will cause"},{"line_number":58,"context_line":"errors when used with older versions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"da36d5c6_b1859fae","line":58,"in_reply_to":"da36d5c6_00670a26","updated":"2017-02-28 11:03:07.000000000","message":"No, we shouldn\u0027t. We would only see warnings with older versions of Sphinx, but those versions of Sphinx don\u0027t support the \u0027warning-is-error\u0027 flag and therefore will not error out. We could include a note that warnings will be generated, but this seems unnecessary?","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"}],"pbr/builddoc.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"94550723d4c48a260b2f9612035843ce759da1a7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        sphinx_config \u003d config.Config(self.config_dir, \u0027conf.py\u0027, {}, [])"},{"line_number":138,"context_line":"        sphinx_ver \u003d pkg_resources.parse_version("},{"line_number":139,"context_line":"            pkg_resources.get_distribution(\"sphinx\").version)"},{"line_number":140,"context_line":"        if sphinx_ver \u003e pkg_resources.parse_version(\u00271.2.3\u0027):"},{"line_number":141,"context_line":"            sphinx_config.init_values(warnings.warn)"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            sphinx_config.init_values()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_626c5a9d","line":140,"updated":"2017-02-28 15:21:51.000000000","message":"Could remove this too while we\u0027re dropping compatibility code for older versions.","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"21c3078435152919d2e13baf6764e6752b221224","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        sphinx_config \u003d config.Config(self.config_dir, \u0027conf.py\u0027, {}, [])"},{"line_number":138,"context_line":"        sphinx_ver \u003d pkg_resources.parse_version("},{"line_number":139,"context_line":"            pkg_resources.get_distribution(\"sphinx\").version)"},{"line_number":140,"context_line":"        if sphinx_ver \u003e pkg_resources.parse_version(\u00271.2.3\u0027):"},{"line_number":141,"context_line":"            sphinx_config.init_values(warnings.warn)"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            sphinx_config.init_values()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_e31689a6","line":140,"in_reply_to":"ba2be162_626c5a9d","updated":"2017-02-28 17:20:55.000000000","message":"Not quite. We\u0027re dropping support for generating errors on Sphinx warnings for older versions of Sphinx. We can still support older Sphinx versions for non-warning-is-error use cases","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"31e3b5c05cbd788e9c06a7e8019e6e41c5f9c363","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # handle Sphinx \u003c 1.5.0"},{"line_number":235,"context_line":"        if not hasattr(self, \u0027warning_is_error\u0027):"},{"line_number":236,"context_line":"            self.warning_is_error \u003d False"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"class LocalBuildLatex(LocalBuildDoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_605d2648","line":236,"updated":"2017-02-27 21:08:22.000000000","message":"What sets this for newer versions of sphinx? It\u0027s plugin?","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86bc4a9567c2c52d3eff8c4a837acce829bd0da8","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # handle Sphinx \u003c 1.5.0"},{"line_number":235,"context_line":"        if not hasattr(self, \u0027warning_is_error\u0027):"},{"line_number":236,"context_line":"            self.warning_is_error \u003d False"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"class LocalBuildLatex(LocalBuildDoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_11490b8f","line":236,"in_reply_to":"da36d5c6_605d2648","updated":"2017-02-28 11:03:07.000000000","message":"Correct [1]\n\n[1] https://github.com/sphinx-doc/sphinx/blob/1.5/sphinx/setup_command.py#L94","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"}],"setup.cfg":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"76328e10fdd2dd0de24ad2eb8991df505e751587","unresolved":false,"context_lines":[{"line_number":52,"context_line":"all-files \u003d 1"},{"line_number":53,"context_line":"build-dir \u003d doc/build"},{"line_number":54,"context_line":"source-dir \u003d doc/source"},{"line_number":55,"context_line":"# enable the below once Sphinx is bumped to 1.5.0+ in g-r"},{"line_number":56,"context_line":"# warning-is-error \u003d 1"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"[wheel]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"da36d5c6_ab2468b2","line":55,"updated":"2017-02-27 17:25:48.000000000","message":"It already is, from what I can see.","commit_id":"72e8e42a34217e7f6847d221dc9751d0c350baa9"}]}