)]}'
{"pbr/builddoc.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4912a6505c5b25a38c53d58d16d74587e8d4c033","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"autodoc_exclude_modules\","},{"line_number":184,"context_line":"                        [None, \"\"])[1].split()))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # TODO(stephenfin): Deprecate this functionality once we depend on"},{"line_number":187,"context_line":"        # Sphinx 1.6, which includes a similar feature, in g-r"},{"line_number":188,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/3476"},{"line_number":189,"context_line":"        self.finalize_options()"},{"line_number":190,"context_line":"        if hasattr(self, \"builder_target_dirs\"):"},{"line_number":191,"context_line":"            # Sphinx \u003e\u003d 1.6.1"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_1ad07d50","line":188,"range":{"start_line":186,"start_character":0,"end_line":188,"end_character":56},"updated":"2017-05-17 11:06:49.000000000","message":"Yup, let\u0027s keep this note until the minimum is bumped","commit_id":"c02406601a7d7c453c77318ff5b5af6d760e80ae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a16277c81ff9f64f599940656bdc22c76b1152a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"autodoc_exclude_modules\","},{"line_number":184,"context_line":"                        [None, \"\"])[1].split()))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # TODO(stephenfin): Deprecate this functionality once we depend on"},{"line_number":187,"context_line":"        # Sphinx 1.6, which includes a similar feature, in g-r"},{"line_number":188,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/3476"},{"line_number":189,"context_line":"        self.finalize_options()"},{"line_number":190,"context_line":"        if hasattr(self, \"builder_target_dirs\"):"},{"line_number":191,"context_line":"            # Sphinx \u003e\u003d 1.6.1"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_23b678db","line":188,"range":{"start_line":186,"start_character":0,"end_line":188,"end_character":56},"in_reply_to":"ff0f0b1f_1ad07d50","updated":"2017-05-17 12:43:37.000000000","message":"totally agree. On the other hand, pbr has sphinx dependency only in test-requirements.txt. How can we specify sphinx \u003e\u003d1.6.1 dependency explicitly? pbr users are not limited to OpenStack community. I think there are more users. I wonder pbr can require users to use sphinx \u003e\u003d1.6.1....\n\nAnyway I am fine with this patch.","commit_id":"c02406601a7d7c453c77318ff5b5af6d760e80ae"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"32cab3f1b8c9f89fec25f40de89b05ef50da45eb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"autodoc_exclude_modules\","},{"line_number":184,"context_line":"                        [None, \"\"])[1].split()))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # TODO(stephenfin): Deprecate this functionality once we depend on"},{"line_number":187,"context_line":"        # Sphinx 1.6, which includes a similar feature, in g-r"},{"line_number":188,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/3476"},{"line_number":189,"context_line":"        self.finalize_options()"},{"line_number":190,"context_line":"        if hasattr(self, \"builder_target_dirs\"):"},{"line_number":191,"context_line":"            # Sphinx \u003e\u003d 1.6.1"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_37122fb3","line":188,"range":{"start_line":186,"start_character":0,"end_line":188,"end_character":56},"in_reply_to":"ff0f0b1f_23b678db","updated":"2017-05-17 15:32:58.000000000","message":"There is no way to specify any dependency on Sphinx. You can\u0027t really know what Sphinx version any pbr user will need… So the best thing to do is to document what version of Sphinx pbr supports and deal with it. :)\n\nI\u0027m pretty sure pbr can require sphinx \u003e\u003d 1.6.1, but maybe not today. Let\u0027s be gentle!","commit_id":"c02406601a7d7c453c77318ff5b5af6d760e80ae"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"37cfa9c6011b45e3ca3dccd7679baab28e4c6791","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        # TODO(stephenfin): Deprecate this functionality once we depend on"},{"line_number":187,"context_line":"        # Sphinx 1.6, which includes a similar feature, in g-r"},{"line_number":188,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/3476"},{"line_number":189,"context_line":"        self.finalize_options()"},{"line_number":190,"context_line":"        if hasattr(self, \"builder_target_dirs\"):"},{"line_number":191,"context_line":"            # Sphinx \u003e\u003d 1.6.1"},{"line_number":192,"context_line":"            return setup_command.BuildDoc.run(self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_4b829a51","line":189,"updated":"2017-05-17 17:14:37.000000000","message":"Below we set self.builder before calling this. Is self.builder already being set somewhere else earlier, or do we need to do that here, too?","commit_id":"c02406601a7d7c453c77318ff5b5af6d760e80ae"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"37cfa9c6011b45e3ca3dccd7679baab28e4c6791","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.finalize_options()"},{"line_number":190,"context_line":"        if hasattr(self, \"builder_target_dirs\"):"},{"line_number":191,"context_line":"            # Sphinx \u003e\u003d 1.6.1"},{"line_number":192,"context_line":"            return setup_command.BuildDoc.run(self)"},{"line_number":193,"context_line":"        # Sphinx \u003c 1.6"},{"line_number":194,"context_line":"        for builder in self.builders:"},{"line_number":195,"context_line":"            self.builder \u003d builder"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6bf2fe08","line":192,"updated":"2017-05-17 17:14:37.000000000","message":"This doesn\u0027t take into account multiple builders. Is that something we still need to do?","commit_id":"c02406601a7d7c453c77318ff5b5af6d760e80ae"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"be4c1d4adf64953eb8755fafde8afc90f3516bfb","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.finalize_options()"},{"line_number":190,"context_line":"        if hasattr(self, \"builder_target_dirs\"):"},{"line_number":191,"context_line":"            # Sphinx \u003e\u003d 1.6.1"},{"line_number":192,"context_line":"            return setup_command.BuildDoc.run(self)"},{"line_number":193,"context_line":"        # Sphinx \u003c 1.6"},{"line_number":194,"context_line":"        for builder in self.builders:"},{"line_number":195,"context_line":"            self.builder \u003d builder"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_ab5ff6e3","line":192,"in_reply_to":"ff0f0b1f_6bf2fe08","updated":"2017-05-17 17:16:27.000000000","message":"Oh, never mind, I see in the commit message that the underlying class deals with multiple builders  now.","commit_id":"c02406601a7d7c453c77318ff5b5af6d760e80ae"}]}
