)]}'
{"pbr/hooks/files.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ac8c82780850704febd496737ade6d56246105fe","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def write_version_file(self, packagename, version):"},{"line_number":88,"context_line":"        if not version:"},{"line_number":89,"context_line":"            return"},{"line_number":90,"context_line":"        version_filename \u003d os.path.join(packagename, \u0027__pbr_version_info.py\u0027)"},{"line_number":91,"context_line":"        with open(version_filename, \u0027w\u0027) as version_file:"},{"line_number":92,"context_line":"            version_file.write(\u0027\u0027\u0027# flake8: noqa"},{"line_number":93,"context_line":"# This file is autogenerated by pbr. It exists to provide"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_587c1082","line":90,"updated":"2017-06-02 21:46:52.000000000","message":"Is packagename always going to be the correct relative path for doing this? What happens if I \"pip install ../some-directory\"?","commit_id":"a449d66485c2310d89a6d271cbb7d38f7c20c00d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7cc9b91ffc9f757053ffdc7aa690768aa62c3450","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def write_version_file(self, packagename, version):"},{"line_number":88,"context_line":"        if not version:"},{"line_number":89,"context_line":"            return"},{"line_number":90,"context_line":"        version_filename \u003d os.path.join(packagename, \u0027__pbr_version_info.py\u0027)"},{"line_number":91,"context_line":"        with open(version_filename, \u0027w\u0027) as version_file:"},{"line_number":92,"context_line":"            version_file.write(\u0027\u0027\u0027# flake8: noqa"},{"line_number":93,"context_line":"# This file is autogenerated by pbr. It exists to provide"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_3825dc5c","line":90,"in_reply_to":"df140735_587c1082","updated":"2017-06-02 21:54:36.000000000","message":"this is executed in the context where the path is correct. (there are other bits that do an isdir() on packagename)","commit_id":"a449d66485c2310d89a6d271cbb7d38f7c20c00d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3bf132033d3460eee1455e11f481faaa2e9ce319","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return"},{"line_number":90,"context_line":"        version_filename \u003d os.path.join(packagename, \u0027__pbr_version_info.py\u0027)"},{"line_number":91,"context_line":"        with open(version_filename, \u0027w\u0027) as version_file:"},{"line_number":92,"context_line":"            version_file.write(\u0027\u0027\u0027# flake8: noqa"},{"line_number":93,"context_line":"# This file is autogenerated by pbr. It exists to provide"},{"line_number":94,"context_line":"# version information generated at build time from git tags"},{"line_number":95,"context_line":"# but is a python file to avoid pkg_resources loading costs."}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_58a1b0f7","line":92,"range":{"start_line":92,"start_character":34,"end_line":92,"end_character":48},"updated":"2017-06-02 21:47:04.000000000","message":"What rule are we violating here and is it in the end result output or in this files.py file being linted? We should be careful if it is in the output.","commit_id":"a449d66485c2310d89a6d271cbb7d38f7c20c00d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7cc9b91ffc9f757053ffdc7aa690768aa62c3450","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return"},{"line_number":90,"context_line":"        version_filename \u003d os.path.join(packagename, \u0027__pbr_version_info.py\u0027)"},{"line_number":91,"context_line":"        with open(version_filename, \u0027w\u0027) as version_file:"},{"line_number":92,"context_line":"            version_file.write(\u0027\u0027\u0027# flake8: noqa"},{"line_number":93,"context_line":"# This file is autogenerated by pbr. It exists to provide"},{"line_number":94,"context_line":"# version information generated at build time from git tags"},{"line_number":95,"context_line":"# but is a python file to avoid pkg_resources loading costs."}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_18b8d8e2","line":92,"range":{"start_line":92,"start_character":34,"end_line":92,"end_character":48},"in_reply_to":"df140735_58a1b0f7","updated":"2017-06-02 21:54:36.000000000","message":"Mostly making sure we don\u0027t trip on hacking\u0027s apache license check. (output)\n\nBut I\u0027ll make this a text file per doug\u0027s suggestion.","commit_id":"a449d66485c2310d89a6d271cbb7d38f7c20c00d"}],"pbr/version.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3bf132033d3460eee1455e11f481faaa2e9ce319","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            m \u003d importlib.import_module("},{"line_number":447,"context_line":"                _make_version_packagename(self.package))"},{"line_number":448,"context_line":"        except ImportError:"},{"line_number":449,"context_line":"            # Try stripping a leading python-"},{"line_number":450,"context_line":"            if self.package.startswith(\u0027python-\u0027):"},{"line_number":451,"context_line":"                name \u003d self.package[7:]"},{"line_number":452,"context_line":"            else:"},{"line_number":453,"context_line":"                # Try taking out .\u0027s"},{"line_number":454,"context_line":"                name \u003d self.package.replace(\u0027.\u0027, \u0027_\u0027)"},{"line_number":455,"context_line":"            # -\u0027s are always wrong"},{"line_number":456,"context_line":"            name \u003d name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":457,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_b8e32c34","line":454,"range":{"start_line":449,"start_character":11,"end_line":454,"end_character":53},"updated":"2017-06-02 21:47:04.000000000","message":"Rather than if elsing these two cases I think you may want to attempt one, then the other, then the two combined? Seems like they could overlap in those weird ways.","commit_id":"a449d66485c2310d89a6d271cbb7d38f7c20c00d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7cc9b91ffc9f757053ffdc7aa690768aa62c3450","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            m \u003d importlib.import_module("},{"line_number":447,"context_line":"                _make_version_packagename(self.package))"},{"line_number":448,"context_line":"        except ImportError:"},{"line_number":449,"context_line":"            # Try stripping a leading python-"},{"line_number":450,"context_line":"            if self.package.startswith(\u0027python-\u0027):"},{"line_number":451,"context_line":"                name \u003d self.package[7:]"},{"line_number":452,"context_line":"            else:"},{"line_number":453,"context_line":"                # Try taking out .\u0027s"},{"line_number":454,"context_line":"                name \u003d self.package.replace(\u0027.\u0027, \u0027_\u0027)"},{"line_number":455,"context_line":"            # -\u0027s are always wrong"},{"line_number":456,"context_line":"            name \u003d name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":457,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_58a770be","line":454,"range":{"start_line":449,"start_character":11,"end_line":454,"end_character":53},"in_reply_to":"df140735_b8e32c34","updated":"2017-06-02 21:54:36.000000000","message":"++","commit_id":"a449d66485c2310d89a6d271cbb7d38f7c20c00d"}]}