)]}'
{"pbr/builddoc.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"253582630c9f218b4b784ce5073a40e1635a35b1","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.finalize_options()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if self.builders !\u003d [\u0027html\u0027] and sphinx.__version__ \u003e\u003d \u00271.6\u0027:"},{"line_number":193,"context_line":"            self.builder \u003d self.builders"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # TODO(stephenfin): Deprecate this functionality once we depend on"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_50aec7e7","line":192,"updated":"2017-09-20 16:35:42.000000000","message":"Using string comparisons for the version check is a little fragile.  It will work as long as sphinx never hits double digits for its version (which, admittedly, seems like a pretty safe bet at this point).\n\nPer https://stackoverflow.com/questions/4806911/string-comparison-technique-used-by-python Python does a lexicographical comparison of strings, which works until you get to a situation where you\u0027re comparing versions like \u00279.0\u0027 and \u002710.0\u0027, at which point 9 \u003e 1 so the comparison doesn\u0027t work as intended.\n\nFortunately we have version-handling code in pbr, so I think we can just call pbr.version.SemanticVersion.from_pip_string to get always correct behavior here.  I guess I\u0027d prefer to do that just to be safe.","commit_id":"6147d89b5116d96602fd7ef0eb767c4e47a1ecc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0180b5bcc1e5481bb45e13d0d7102cf1fb38543d","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.finalize_options()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if self.builders !\u003d [\u0027html\u0027] and sphinx.__version__ \u003e\u003d \u00271.6\u0027:"},{"line_number":193,"context_line":"            self.builder \u003d self.builders"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # TODO(stephenfin): Deprecate this functionality once we depend on"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_056373de","line":192,"in_reply_to":"bf57530f_50aec7e7","updated":"2017-09-22 15:58:54.000000000","message":"Done","commit_id":"6147d89b5116d96602fd7ef0eb767c4e47a1ecc7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"253582630c9f218b4b784ce5073a40e1635a35b1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        # Sphinx 1.6, which includes a similar feature, in g-r"},{"line_number":197,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/3476"},{"line_number":198,"context_line":"        if sphinx.__version__ \u003e\u003d \u00271.6\u0027:"},{"line_number":199,"context_line":"            # Sphinx \u003e\u003d 1.6.1"},{"line_number":200,"context_line":"            return setup_command.BuildDoc.run(self)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Sphinx \u003c 1.6"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_eb4b90ad","line":199,"updated":"2017-09-20 16:35:42.000000000","message":"Will this actually work if sphinx is 1.6 exactly?  The existing comment would suggest not.","commit_id":"6147d89b5116d96602fd7ef0eb767c4e47a1ecc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0180b5bcc1e5481bb45e13d0d7102cf1fb38543d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        # Sphinx 1.6, which includes a similar feature, in g-r"},{"line_number":197,"context_line":"        # https://github.com/sphinx-doc/sphinx/pull/3476"},{"line_number":198,"context_line":"        if sphinx.__version__ \u003e\u003d \u00271.6\u0027:"},{"line_number":199,"context_line":"            # Sphinx \u003e\u003d 1.6.1"},{"line_number":200,"context_line":"            return setup_command.BuildDoc.run(self)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        # Sphinx \u003c 1.6"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_25666fef","line":199,"in_reply_to":"bf57530f_eb4b90ad","updated":"2017-09-22 15:58:54.000000000","message":"That feature was in Sphinx 1.6 so it will, yes. IIRC, that comment refers to a bug with Sphinx 1.6.1 that\u0027s unrelated to this. Have updated it","commit_id":"6147d89b5116d96602fd7ef0eb767c4e47a1ecc7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"e1fa2056e3f7aaaad3e97abae213822a5a272121","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.finalize_options()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        is_multibuilder_sphinx \u003d version.SemanticVersion.from_pip_string("},{"line_number":194,"context_line":"            sphinx.__version__) \u003d\u003d version.SemanticVersion(1, 6)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if self.builders !\u003d [\u0027html\u0027] and is_multibuilder_sphinx:"},{"line_number":197,"context_line":"            self.builder \u003d self.builders"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_7e8515ad","line":194,"range":{"start_line":194,"start_character":32,"end_line":194,"end_character":34},"updated":"2017-09-22 20:03:13.000000000","message":"\u003e\u003d ?  I\u0027m guessing this is why the unit tests failed.","commit_id":"c309d7fe7b91d0197ff3e71c5563bc2cf45c74c7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56bf39935042a25d21dc3cf5abbf0d5375841c19","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.finalize_options()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        is_multibuilder_sphinx \u003d version.SemanticVersion.from_pip_string("},{"line_number":194,"context_line":"            sphinx.__version__) \u003d\u003d version.SemanticVersion(1, 6)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if self.builders !\u003d [\u0027html\u0027] and is_multibuilder_sphinx:"},{"line_number":197,"context_line":"            self.builder \u003d self.builders"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_082fe3a1","line":194,"range":{"start_line":194,"start_character":32,"end_line":194,"end_character":34},"in_reply_to":"7f515b1d_7e8515ad","updated":"2017-09-26 15:47:09.000000000","message":"Doh. Done","commit_id":"c309d7fe7b91d0197ff3e71c5563bc2cf45c74c7"}]}